SpecificationQueryHandler - Code Metrics - Inspection of "test SpecificationQueryHandler" - gpslab/specification-query - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4476a6...356084 )

by Peter

created 2017-05-26 15:42 UTC

SpecificationQueryHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	3
lcom	1
cbo	3
dl	0
loc	32
ccs	8
cts	8
cp	1
rs	10
c	2
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	11	2

<?php

/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <[email protected]>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Component\Query\Specification;

use Doctrine\ORM\EntityManagerInterface;
use Happyr\DoctrineSpecification\EntitySpecificationRepositoryInterface;
use GpsLab\Component\Query\Handler\QueryHandler;
use GpsLab\Component\Query\Query;

class SpecificationQueryHandler implements QueryHandler
{
    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * @param EntityManagerInterface $em
     */
    public function __construct(EntityManagerInterface $em)
    {
        $this->em = $em;
    }

    /**
     * @param Query $query
     *
     * @return mixed
     */
    public function handle(Query $query)
    {
        if (!($query instanceof SpecificationQuery)) {
            return null;
        }

        /* @var $rep EntitySpecificationRepositoryInterface */
        $rep = $this->em->getRepository($query->entity());

        return $rep->match($query->spec(), $query->modifier());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}


1		<?php
2
3		/**
4		* GpsLab component.
5		*
6		* @author Peter Gribanov <[email protected]>
7		* @copyright Copyright (c) 2011, Peter Gribanov
8		* @license http://opensource.org/licenses/MIT
9		*/
10
11		namespace GpsLab\Component\Query\Specification;
12
13		use Doctrine\ORM\EntityManagerInterface;
14		use Happyr\DoctrineSpecification\EntitySpecificationRepositoryInterface;
15		use GpsLab\Component\Query\Handler\QueryHandler;
16		use GpsLab\Component\Query\Query;
17
18		class SpecificationQueryHandler implements QueryHandler
19		{
20		/**
21		* @var EntityManagerInterface
22		*/
23		private $em;
24
25		/**
26		* @param EntityManagerInterface $em
27		*/
28	2	public function __construct(EntityManagerInterface $em)
29		{
30	2	$this->em = $em;
31	2	}
32
33		/**
34		* @param Query $query
35		*
36		* @return mixed
37		*/
38	2	public function handle(Query $query)
39		{
40	2	if (!($query instanceof SpecificationQuery)) {
41	1	return null;
42		}
43
44		/* @var $rep EntitySpecificationRepositoryInterface */
45	1	$rep = $this->em->getRepository($query->entity());
46
47	1	return $rep->match($query->spec(), $query->modifier());
		0 ignored issues – show Bug introduced 2017-05-26 15:48 UTC by Report Bug Copy Issue Report It seems like `$query->modifier()` can be `null`; however, `match()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
48		}
49		}
50

gpslab / specification-query

Push — master ( 4476a6...356084 )

SpecificationQueryHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like