SpecificationQueryHandler::handleSpecification() - Code Metrics - Inspection of "add register specification query handler guide" - gpslab/specification-query - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3732b...aa3be6 )

by Peter

created 2017-06-16 14:59 UTC

SpecificationQueryHandler::handleSpecification() A

↳ Parent: SpecificationQueryHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
ccs	3
cts	3
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php

/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <[email protected]>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Component\Query\Specification;

use Doctrine\ORM\EntityManagerInterface;
use Happyr\DoctrineSpecification\EntitySpecificationRepositoryInterface;

class SpecificationQueryHandler
{
    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * @param EntityManagerInterface $em
     */
    public function __construct(EntityManagerInterface $em)
    {
        $this->em = $em;
    }

    /**
     * @param SpecificationQuery $query
     *
     * @return mixed
     */
    public function handleSpecification(SpecificationQuery $query)
    {
        /* @var $rep EntitySpecificationRepositoryInterface */
        $rep = $this->em->getRepository($query->entity());

        return $rep->match($query->spec(), $query->modifier());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}


1		<?php
2
3		/**
4		* GpsLab component.
5		*
6		* @author Peter Gribanov <[email protected]>
7		* @copyright Copyright (c) 2011, Peter Gribanov
8		* @license http://opensource.org/licenses/MIT
9		*/
10
11		namespace GpsLab\Component\Query\Specification;
12
13		use Doctrine\ORM\EntityManagerInterface;
14		use Happyr\DoctrineSpecification\EntitySpecificationRepositoryInterface;
15
16		class SpecificationQueryHandler
17		{
18		/**
19		* @var EntityManagerInterface
20		*/
21		private $em;
22
23		/**
24		* @param EntityManagerInterface $em
25		*/
26	1	public function __construct(EntityManagerInterface $em)
27		{
28	1	$this->em = $em;
29	1	}
30
31		/**
32		* @param SpecificationQuery $query
33		*
34		* @return mixed
35		*/
36	1	public function handleSpecification(SpecificationQuery $query)
37		{
38		/* @var $rep EntitySpecificationRepositoryInterface */
39	1	$rep = $this->em->getRepository($query->entity());
40
41	1	return $rep->match($query->spec(), $query->modifier());
		0 ignored issues – show Bug introduced 2017-05-26 15:48 UTC by Report Bug Copy Issue Report It seems like `$query->modifier()` can be `null`; however, `match()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
42		}
43		}
44

gpslab / specification-query

Push — master ( e3732b...aa3be6 )

SpecificationQueryHandler::handleSpecification() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like