SmartUrl::__construct() - Code Metrics - Inspection of "Merge branch '1.0'" - gpslab/sitemap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0d3592...0bb29a )

by Peter

created 2017-10-30 11:52 UTC

SmartUrl::__construct() B

↳ Parent: SmartUrl

Complexity

Conditions	5
Paths	8

Size

Total Lines	19
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	19
rs	8.8571
c	1
b	0
f	0
cc	5
eloc	8
nc	8
nop	4

<?php
/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <[email protected]>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Component\Sitemap\Url;

class SmartUrl extends Url
{
    /**
     * @param string                  $loc
     * @param \DateTimeImmutable|null $last_mod
     * @param string|null             $change_freq
     * @param string|null             $priority
     */
    public function __construct($loc, \DateTimeImmutable $last_mod = null, $change_freq = null, $priority = null)
    {
        // priority from loc
        if (!$priority) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $priority = $this->priorityFromLoc($loc);
        }

        // change freq from last mod
        if (!$change_freq && $last_mod instanceof \DateTimeImmutable) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $change_freq = $this->changeFreqFromLastMod($last_mod);
        }

        // change freq from priority
        if (!$change_freq) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $change_freq = $this->changeFreqFromPriority($priority);
        }

        parent::__construct($loc, $last_mod, $change_freq, $priority);
    }

    /**
     * @param string $loc
     *
     * @return string
     */
    private function priorityFromLoc($loc)
    {
        // number of slashes
        $num = count(array_filter(explode('/', trim($loc, '/'))));

        if (!$num) {
            return '1.0';
        }

        if (($p = (10 - $num) / 10) > 0) {
            return '0.'.($p * 10);
        }

        return '0.1';
    }

    /**
     * @param \DateTimeImmutable $last_mod
     *
     * @return string|null
     */
    private function changeFreqFromLastMod(\DateTimeImmutable $last_mod)
    {
        if ($last_mod < new \DateTimeImmutable('-1 year')) {
            return self::CHANGE_FREQ_YEARLY;
        }

        if ($last_mod < new \DateTimeImmutable('-1 month')) {
            return self::CHANGE_FREQ_MONTHLY;
        }

        return null;
    }

    /**
     * @param string $priority
     *
     * @return string
     */
    private function changeFreqFromPriority($priority)
    {
        switch ($priority) {
            case '1.0':
                return self::CHANGE_FREQ_HOURLY;
            case '0.9':
                return self::CHANGE_FREQ_DAILY;
            case '0.8':
                return self::CHANGE_FREQ_DAILY;
            case '0.7':
                return self::CHANGE_FREQ_WEEKLY;
            case '0.6':
                return self::CHANGE_FREQ_WEEKLY;
            case '0.5':
                return self::CHANGE_FREQ_WEEKLY;
            case '0.4':
                return self::CHANGE_FREQ_MONTHLY;
            case '0.3':
                return self::CHANGE_FREQ_MONTHLY;
            case '0.2':
                return self::CHANGE_FREQ_YEARLY;
            case '0.1':
                return self::CHANGE_FREQ_YEARLY;
            case '0.0':
                return self::CHANGE_FREQ_NEVER;
            default:
                return null;
        }
    }
}


1			<?php
2			/**
3			* GpsLab component.
4			*
5			* @author Peter Gribanov <[email protected]>
6			* @copyright Copyright (c) 2011, Peter Gribanov
7			* @license http://opensource.org/licenses/MIT
8			*/
9
10			namespace GpsLab\Component\Sitemap\Url;
11
12			class SmartUrl extends Url
13			{
14			/**
15			* @param string $loc
16			* @param \DateTimeImmutable\|null $last_mod
17			* @param string\|null $change_freq
18			* @param string\|null $priority
19			*/
20			public function __construct($loc, \DateTimeImmutable $last_mod = null, $change_freq = null, $priority = null)
21			{
22			// priority from loc
23			if (!$priority) {
			1 ignored issue – show Bug Best Practice introduced 2017-10-30 11:58 UTC by Report Bug Copy Issue Report The expression `$priority` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
24			$priority = $this->priorityFromLoc($loc);
25			}
26
27			// change freq from last mod
28			if (!$change_freq && $last_mod instanceof \DateTimeImmutable) {
			1 ignored issue – show Bug Best Practice introduced 2017-10-30 11:58 UTC by Report Bug Copy Issue Report The expression `$change_freq` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
29			$change_freq = $this->changeFreqFromLastMod($last_mod);
30			}
31
32			// change freq from priority
33			if (!$change_freq) {
			1 ignored issue – show Bug Best Practice introduced 2017-10-30 11:58 UTC by Report Bug Copy Issue Report The expression `$change_freq` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
34			$change_freq = $this->changeFreqFromPriority($priority);
35			}
36
37			parent::__construct($loc, $last_mod, $change_freq, $priority);
38			}
39
40			/**
41			* @param string $loc
42			*
43			* @return string
44			*/
45			private function priorityFromLoc($loc)
46			{
47			// number of slashes
48			$num = count(array_filter(explode('/', trim($loc, '/'))));
49
50			if (!$num) {
51			return '1.0';
52			}
53
54			if (($p = (10 - $num) / 10) > 0) {
55			return '0.'.($p * 10);
56			}
57
58			return '0.1';
59			}
60
61			/**
62			* @param \DateTimeImmutable $last_mod
63			*
64			* @return string\|null
65			*/
66			private function changeFreqFromLastMod(\DateTimeImmutable $last_mod)
67			{
68			if ($last_mod < new \DateTimeImmutable('-1 year')) {
69			return self::CHANGE_FREQ_YEARLY;
70			}
71
72			if ($last_mod < new \DateTimeImmutable('-1 month')) {
73			return self::CHANGE_FREQ_MONTHLY;
74			}
75
76			return null;
77			}
78
79			/**
80			* @param string $priority
81			*
82			* @return string
83			*/
84			private function changeFreqFromPriority($priority)
85			{
86			switch ($priority) {
87			case '1.0':
88			return self::CHANGE_FREQ_HOURLY;
89			case '0.9':
90			return self::CHANGE_FREQ_DAILY;
91			case '0.8':
92			return self::CHANGE_FREQ_DAILY;
93			case '0.7':
94			return self::CHANGE_FREQ_WEEKLY;
95			case '0.6':
96			return self::CHANGE_FREQ_WEEKLY;
97			case '0.5':
98			return self::CHANGE_FREQ_WEEKLY;
99			case '0.4':
100			return self::CHANGE_FREQ_MONTHLY;
101			case '0.3':
102			return self::CHANGE_FREQ_MONTHLY;
103			case '0.2':
104			return self::CHANGE_FREQ_YEARLY;
105			case '0.1':
106			return self::CHANGE_FREQ_YEARLY;
107			case '0.0':
108			return self::CHANGE_FREQ_NEVER;
109			default:
110			return null;
111			}
112			}
113			}
114

gpslab / sitemap

Push — master ( 0d3592...0bb29a )

SmartUrl::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like