Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
20 | class RenderBzip2FileStream implements FileStream |
||
21 | { |
||
22 | /** |
||
23 | * @var SitemapRender |
||
24 | */ |
||
25 | private $render; |
||
26 | |||
27 | /** |
||
28 | * @var StreamState |
||
29 | */ |
||
30 | private $state; |
||
31 | |||
32 | /** |
||
33 | * @var resource|null |
||
34 | */ |
||
35 | private $handle; |
||
36 | |||
37 | /** |
||
38 | * @var string |
||
39 | */ |
||
40 | private $filename; |
||
41 | |||
42 | /** |
||
43 | * @var string |
||
44 | */ |
||
45 | private $tmp_filename = ''; |
||
46 | |||
47 | /** |
||
48 | * @var int |
||
49 | */ |
||
50 | private $counter = 0; |
||
51 | |||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | private $end_string = ''; |
||
56 | |||
57 | /** |
||
58 | * @var int |
||
59 | */ |
||
60 | private $used_bytes = 0; |
||
61 | |||
62 | /** |
||
63 | * @param SitemapRender $render |
||
64 | * @param string $filename |
||
65 | */ |
||
66 | 11 | public function __construct(SitemapRender $render, $filename) |
|
72 | |||
73 | /** |
||
74 | * @return string |
||
75 | */ |
||
76 | 1 | public function getFilename() |
|
80 | |||
81 | 7 | public function open() |
|
108 | |||
109 | 11 | View Code Duplication | public function close() |
126 | |||
127 | /** |
||
128 | * @param Url $url |
||
129 | */ |
||
130 | 5 | View Code Duplication | public function push(Url $url) |
131 | { |
||
132 | 5 | if (!$this->state->isReady()) { |
|
133 | 2 | throw StreamStateException::notReady(); |
|
134 | } |
||
135 | |||
136 | 3 | if ($this->counter >= self::LINKS_LIMIT) { |
|
137 | 1 | throw LinksOverflowException::withLimit(self::LINKS_LIMIT); |
|
138 | } |
||
139 | |||
140 | 3 | $render_url = $this->render->url($url); |
|
141 | |||
142 | 3 | $expected_bytes = $this->used_bytes + strlen($render_url) + strlen($this->end_string); |
|
143 | 3 | if ($expected_bytes > self::BYTE_LIMIT) { |
|
144 | throw SizeOverflowException::withLimit(self::BYTE_LIMIT); |
||
145 | } |
||
146 | |||
147 | 3 | $this->write($render_url); |
|
148 | 3 | ++$this->counter; |
|
149 | 3 | } |
|
150 | |||
151 | /** |
||
152 | * @return int |
||
153 | */ |
||
154 | 2 | public function count() |
|
158 | |||
159 | /** |
||
160 | * @param string $string |
||
161 | */ |
||
162 | 7 | private function write($string) |
|
167 | } |
||
168 |