Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 20 | class RenderFileStream implements FileStream |
||
| 21 | { |
||
| 22 | /** |
||
| 23 | * @var SitemapRender |
||
| 24 | */ |
||
| 25 | private $render; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var StreamState |
||
| 29 | */ |
||
| 30 | private $state; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var resource|null |
||
| 34 | */ |
||
| 35 | private $handle; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | private $filename = ''; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var string |
||
| 44 | */ |
||
| 45 | private $tmp_filename = ''; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var int |
||
| 49 | */ |
||
| 50 | private $counter = 0; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var string |
||
| 54 | */ |
||
| 55 | private $end_string = ''; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var int |
||
| 59 | */ |
||
| 60 | private $used_bytes = 0; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @param SitemapRender $render |
||
| 64 | * @param string $filename |
||
| 65 | */ |
||
| 66 | 22 | public function __construct(SitemapRender $render, $filename) |
|
| 72 | |||
| 73 | /** |
||
| 74 | * @return string |
||
| 75 | */ |
||
| 76 | 9 | public function getFilename() |
|
| 80 | |||
| 81 | 16 | View Code Duplication | public function open() |
| 104 | |||
| 105 | 19 | View Code Duplication | public function close() |
| 122 | |||
| 123 | /** |
||
| 124 | * @param Url $url |
||
| 125 | */ |
||
| 126 | 10 | View Code Duplication | public function push(Url $url) |
| 146 | |||
| 147 | /** |
||
| 148 | * @return int |
||
| 149 | */ |
||
| 150 | 2 | public function count() |
|
| 154 | |||
| 155 | /** |
||
| 156 | * @param string $string |
||
| 157 | */ |
||
| 158 | 16 | private function write($string) |
|
| 163 | } |
||
| 164 |