GpsLab\Component\Payload\PayloadTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	payload()	0	4	1
C	setPayload()	0	22	7
B	analyze()	0	16	5

<?php

/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Component\Payload;

use GpsLab\Component\Payload\Exception\PropertyException;

trait PayloadTrait
{
    /**
     * @var array
     */
    private $payload = [];

    /**
     * @var array
     */
    private $properties = [];

    /**
     * @var array
     */
    private $methods = [];

    /**
     * @return array
     */
    final public function payload()
    {
        return $this->payload;
    }

    /**
     * @param array $payload
     * @param array $required
     *
     * @throws PropertyException
     */
    final protected function setPayload(array $payload, array $required = [])
    {
        if ($required && ($lost = array_diff($required, array_keys($payload)))) {

The expression $required of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw PropertyException::noRequiredProperties($lost, $this);
        }

        $this->analyze();

        foreach ($payload as $name => $value) {
            if (in_array($name, $this->properties)) {
                $this->$name = $value;
                continue;
            } elseif (($method = 'set'.ucfirst($name)) && in_array($method, $this->methods)) {
                $this->{$method}($value);
                continue;
            }

            throw PropertyException::undefinedProperty($name, $this);
        }

        $this->payload = $payload;
    }

    /**
     * @return array
     */
    private function analyze()
    {
        if (!$this->properties && !$this->methods) {
            $ref = new \ReflectionClass($this);

            $properties = $ref->getProperties(\ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED);
            foreach ($properties as $property) {
                $this->properties[] = $property->getName();
            }

            $methods = $ref->getMethods(\ReflectionMethod::IS_PUBLIC | \ReflectionMethod::IS_PROTECTED);
            foreach ($methods as $method) {
                $this->methods[] = $method->getName();

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            }
        }
    }
}