GpsLab\Bundle\PaginationBundle\GpsLabPaginationBundle::getContainerExtension()

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getContainerExtension()
    {
        if (null === $this->extension) {
            $this->extension = false;
            $class = $this->getContainerExtensionClass();

            if (class_exists($class)) {
                $extension = new $class();

                if ($extension instanceof ExtensionInterface) {
                    $this->extension = $extension;
                }
            }

        }

        return $this->extension;

The expression $this->extension; of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|false adds false to the return on line 36 which is incompatible with the return type declared by the interface Symfony\Component\HttpKernel\Bundle\BundleInterface::getContainerExtension of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. It seems like you forgot to handle an error condition.

    }
}