GpsLab\Bundle\PaginationBundle\GpsLabPaginationBundle

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getContainerExtension()	0	18	4

<?php
/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Bundle\PaginationBundle;

use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

class GpsLabPaginationBundle extends Bundle
{
    /**
     * @return ExtensionInterface|bool
     */
    public function getContainerExtension()
    {
        if (null === $this->extension) {
            $this->extension = false;
            $class = $this->getContainerExtensionClass();

            if (class_exists($class)) {
                $extension = new $class();

                if ($extension instanceof ExtensionInterface) {
                    $this->extension = $extension;
                }
            }

        }

        return $this->extension;

The expression $this->extension; of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|false adds false to the return on line 36 which is incompatible with the return type declared by the interface Symfony\Component\HttpKernel\Bundle\BundleInterface::getContainerExtension of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. It seems like you forgot to handle an error condition.

    }
}