NumberInterval   A
last analyzed

Complexity

Total Complexity 34

Size/Duplication

Total Lines 368
Duplicated Lines 3.8 %

Coupling/Cohesion

Components 2
Dependencies 5

Test Coverage

Coverage 69.01%

Importance

Changes 0
Metric Value
wmc 34
lcom 2
cbo 5
dl 14
loc 368
ccs 49
cts 71
cp 0.6901
rs 9.68
c 0
b 0
f 0

28 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 11 2
A create() 0 4 1
A closed() 0 4 1
A halfClosed() 0 4 1
A halfOpen() 0 4 1
A open() 0 4 1
A fromString() 0 8 2
A equal() 0 4 1
A contains() 0 4 1
A intersects() 0 4 1
A intersection() 0 4 1
A cover() 0 4 1
A gap() 0 4 1
A abuts() 0 4 1
A join() 0 4 1
A union() 0 4 1
A after() 0 4 1
A type() 0 4 1
A start() 0 4 1
A end() 0 4 1
A startPoint() 0 4 1
A endPoint() 0 4 1
A withStart() 0 4 1
A withEnd() 0 4 1
A withType() 0 4 1
A __toString() 0 4 1
A before() 0 4 1
A iterate() 14 14 5

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * GpsLab component.
5
 *
6
 * @author    Peter Gribanov <[email protected]>
7
 * @copyright Copyright (c) 2016, Peter Gribanov
8
 * @license   http://opensource.org/licenses/MIT
9
 */
10
11
namespace GpsLab\Component\Interval\Number;
12
13
use GpsLab\Component\Interval\Exception\IncorrectIntervalException;
14
use GpsLab\Component\Interval\Exception\InvalidIntervalFormatException;
15
use GpsLab\Component\Interval\IntervalComparator;
16
use GpsLab\Component\Interval\ComparableIntervalInterface;
17
use GpsLab\Component\Interval\IntervalPointInterface;
18
use GpsLab\Component\Interval\IntervalType;
19
20
class NumberInterval implements ComparableIntervalInterface
21
{
22
    /**
23
     * @var string
24
     */
25
    const REGEXP = '/^
26
        (?:\(|\[)        # start type char
27
        \s*
28
        (?<start>\-?\d+) # start point
29
        \s*,\s*          # separator
30
        (?<end>\-?\d+)   # end point
31
        \s*
32
        (?:\)|\])        # end type char
33
    $/x';
34
35
    /**
36
     * @var IntervalType
37
     */
38
    private $type;
39
40
    /**
41
     * @var IntervalComparator
42
     */
43
    private $comparator;
44
45
    /**
46
     * @var NumberIntervalPoint
47
     */
48
    private $start;
49
50
    /**
51
     * @var NumberIntervalPoint
52
     */
53
    private $end;
54
55
    /**
56
     * @param NumberIntervalPoint $start
57
     * @param NumberIntervalPoint $end
58
     * @param IntervalType $type
59
     */
60 31
    private function __construct(NumberIntervalPoint $start, NumberIntervalPoint $end, IntervalType $type)
61
    {
62 31
        if ($start->gte($end)) {
63
            throw IncorrectIntervalException::create();
64
        }
65
66 31
        $this->start = $start;
67 31
        $this->end = $end;
68 31
        $this->type = $type;
69 31
        $this->comparator = new IntervalComparator($this);
70 31
    }
71
72
    /**
73
     * @param int|float $start
74
     * @param int|float $end
75
     * @param IntervalType $type
76
     *
77
     * @return self
78
     */
79 31
    public static function create($start, $end, IntervalType $type)
80
    {
81 31
        return new self(new NumberIntervalPoint($start), new NumberIntervalPoint($end), $type);
82
    }
83
84
    /**
85
     * @param int|float $start
86
     * @param int|float $end
87
     *
88
     * @return self
89
     */
90 1
    public static function closed($start, $end)
91
    {
92 1
        return self::create($start, $end, IntervalType::closed());
93
    }
94
95
    /**
96
     * @param int|float $start
97
     * @param int|float $end
98
     *
99
     * @return self
100
     */
101
    public static function halfClosed($start, $end)
102
    {
103
        return self::create($start, $end, IntervalType::halfClosed());
104
    }
105
106
    /**
107
     * @param int|float $start
108
     * @param int|float $end
109
     *
110
     * @return self
111
     */
112
    public static function halfOpen($start, $end)
113
    {
114
        return self::create($start, $end, IntervalType::halfOpen());
115
    }
116
117
    /**
118
     * @param int|float $start
119
     * @param int|float $end
120
     *
121
     * @return self
122
     */
123 1
    public static function open($start, $end)
124
    {
125 1
        return self::create($start, $end, IntervalType::open());
126
    }
127
128
    /**
129
     * Create interval from string.
130
     *
131
     * Example formats:
132
     *   [0, 5]
133
     *   (-3, 2]
134
     *   [-3, -1)
135
     *   (3, 9)
136
     *
137
     * Spaces are ignored in format.
138
     *
139
     * @param string $string
140
     *
141
     * @return self
142
     */
143 29
    public static function fromString($string)
144
    {
145 29
        if (!preg_match(self::REGEXP, $string, $match)) {
146
            throw InvalidIntervalFormatException::create('[N, N]', $string);
147
        }
148
149 29
        return self::create($match['start'], $match['end'], IntervalType::fromString($string));
150
    }
151
152
    /**
153
     * Checks if this interval is equal to the specified interval.
154
     *
155
     * @param NumberInterval $interval
156
     *
157
     * @return bool
158
     */
159
    public function equal(self $interval)
160
    {
161
        return $this->comparator->equal($interval);
162
    }
163
164
    /**
165
     * Does this interval contain the specified point.
166
     *
167
     * @param int|float $point
168
     *
169
     * @return bool
170
     */
171 7
    public function contains($point)
172
    {
173 7
        return $this->comparator->contains(new NumberIntervalPoint($point));
174
    }
175
176
    /**
177
     * Does this interval intersect the specified interval.
178
     *
179
     * @param NumberInterval $interval
180
     *
181
     * @return bool
182
     */
183 8
    public function intersects(self $interval)
184
    {
185 8
        return $this->comparator->intersects($interval);
186
    }
187
188
    /**
189
     * Gets the intersection between this interval and another interval.
190
     *
191
     * @param NumberInterval $interval
192
     *
193
     * @return self|null
194
     */
195 12
    public function intersection(self $interval)
196
    {
197 12
        return $this->comparator->intersection($interval);
198
    }
199
200
    /**
201
     * Gets the covered interval between this Interval and another interval.
202
     *
203
     * @param NumberInterval $interval
204
     *
205
     * @return self
206
     */
207
    public function cover(self $interval)
208
    {
209
        return $this->comparator->cover($interval);
210
    }
211
212
    /**
213
     * Gets the gap between this interval and another interval.
214
     *
215
     * @param NumberInterval $interval
216
     *
217
     * @return self|null
218
     */
219
    public function gap(self $interval)
220
    {
221
        return $this->comparator->gap($interval);
222
    }
223
224
    /**
225
     * Does this interval abuts with the interval specified.
226
     *
227
     * @param NumberInterval $interval
228
     *
229
     * @return bool
230
     */
231
    public function abuts(self $interval)
232
    {
233
        return $this->comparator->abuts($interval);
234
    }
235
236
    /**
237
     * Joins the interval between the adjacent.
238
     *
239
     * @param NumberInterval $interval
240
     *
241
     * @return self|null
242
     */
243
    public function join(self $interval)
244
    {
245
        return $this->comparator->join($interval);
246
    }
247
248
    /**
249
     * Gets the union between this interval and another interval.
250
     *
251
     * @param NumberInterval $interval
252
     *
253
     * @return self|null
254
     */
255
    public function union(self $interval)
256
    {
257
        return $this->comparator->union($interval);
258
    }
259
260
    /**
261
     * The point is before the interval.
262
     *
263
     * @param int|float $point
264
     *
265
     * @return bool
266
     */
267
    public function before($point)
268
    {
269
        return $this->comparator->before(new NumberIntervalPoint($point));
270
    }
271
272
    /**
273
     * The point is after the interval.
274
     *
275
     * @param int|float $point
276
     *
277
     * @return bool
278
     */
279
    public function after($point)
280
    {
281
        return $this->comparator->after(new NumberIntervalPoint($point));
282
    }
283
284
    /**
285
     * @param int $step
286
     *
287
     * @return \Generator
288
     */
289 2 View Code Duplication
    public function iterate($step = 1)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
290
    {
291 2
        $end = $this->end();
292 2
        $number = $this->start();
293
294 2
        if ($this->type->startExcluded()) {
295 1
            $number += $step;
296
        }
297
298 2
        while ($number < $end || (!$this->type->endExcluded() && $number == $end)) {
299 2
            yield $number;
300 2
            $number += $step;
301
        }
302 2
    }
303
304
    /**
305
     * @return IntervalType
306
     */
307 18
    public function type()
308
    {
309 18
        return $this->type;
310
    }
311
312
    /**
313
     * @return int|float
314
     */
315 2
    public function start()
316
    {
317 2
        return $this->start->value();
318
    }
319
320
    /**
321
     * @return int|float
322
     */
323 2
    public function end()
324
    {
325 2
        return $this->end->value();
326
    }
327
328
    /**
329
     * @return NumberIntervalPoint
330
     */
331 28
    public function startPoint()
332
    {
333 28
        return $this->start;
334
    }
335
336
    /**
337
     * @return NumberIntervalPoint
338
     */
339 26
    public function endPoint()
340
    {
341 26
        return $this->end;
342
    }
343
344
    /**
345
     * Returns a copy of this Interval with the start point altered.
346
     *
347
     * @param IntervalPointInterface|NumberIntervalPoint $start
348
     *
349
     * @return self
350
     */
351 8
    public function withStart(IntervalPointInterface $start)
352
    {
353 8
        return new self($start, $this->end, $this->type);
0 ignored issues
show
Compatibility introduced by
$start of type object<GpsLab\Component\...IntervalPointInterface> is not a sub-type of object<GpsLab\Component\...er\NumberIntervalPoint>. It seems like you assume a concrete implementation of the interface GpsLab\Component\Interval\IntervalPointInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
354
    }
355
356
    /**
357
     * Returns a copy of this Interval with the end point altered.
358
     *
359
     * @param IntervalPointInterface|NumberIntervalPoint $end
360
     *
361
     * @return self
362
     */
363 8
    public function withEnd(IntervalPointInterface $end)
364
    {
365 8
        return new self($this->start, $end, $this->type);
0 ignored issues
show
Compatibility introduced by
$end of type object<GpsLab\Component\...IntervalPointInterface> is not a sub-type of object<GpsLab\Component\...er\NumberIntervalPoint>. It seems like you assume a concrete implementation of the interface GpsLab\Component\Interval\IntervalPointInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
366
    }
367
368
    /**
369
     * Returns a copy of this Interval with the interval type altered.
370
     *
371
     * @param IntervalType $type
372
     *
373
     * @return self
374
     */
375 8
    public function withType(IntervalType $type)
376
    {
377 8
        return new self($this->start, $this->end, $type);
378
    }
379
380
    /**
381
     * @return string
382
     */
383 1
    public function __toString()
384
    {
385 1
        return $this->type->formatInterval($this);
386
    }
387
}
388