Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
20 | class IPv4Interval implements ComparableIntervalInterface |
||
21 | { |
||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | const REGEXP = '/^ |
||
26 | (?:\(|\[) # start type char |
||
27 | \s* |
||
28 | (?<start>'.IPv4IntervalPoint::IPV4_ADDR.') # start point |
||
29 | \s*,\s* # separator |
||
30 | (?<end>'.IPv4IntervalPoint::IPV4_ADDR.') # end point |
||
31 | \s* |
||
32 | (?:\)|\]) # end type char |
||
33 | $/x'; |
||
34 | |||
35 | /** |
||
36 | * @var IntervalType |
||
37 | */ |
||
38 | private $type; |
||
39 | |||
40 | /** |
||
41 | * @var IntervalComparator |
||
42 | */ |
||
43 | private $comparator; |
||
44 | |||
45 | /** |
||
46 | * @var IPv4IntervalPoint |
||
47 | */ |
||
48 | private $start; |
||
49 | |||
50 | /** |
||
51 | * @var IPv4IntervalPoint |
||
52 | */ |
||
53 | private $end; |
||
54 | |||
55 | /** |
||
56 | * @param IPv4IntervalPoint $start |
||
57 | * @param IPv4IntervalPoint $end |
||
58 | * @param IntervalType $type |
||
59 | */ |
||
60 | 4 | private function __construct(IPv4IntervalPoint $start, IPv4IntervalPoint $end, IntervalType $type) |
|
71 | |||
72 | /** |
||
73 | * @param string $start |
||
74 | * @param string $end |
||
75 | * @param IntervalType $type |
||
76 | * |
||
77 | * @return self |
||
78 | */ |
||
79 | 4 | public static function create($start, $end, IntervalType $type) |
|
83 | |||
84 | /** |
||
85 | * @param string $start |
||
86 | * @param string $end |
||
87 | * |
||
88 | * @return self |
||
89 | */ |
||
90 | 1 | public static function closed($start, $end) |
|
94 | |||
95 | /** |
||
96 | * @param string $start |
||
97 | * @param string $end |
||
98 | * |
||
99 | * @return self |
||
100 | */ |
||
101 | public static function halfClosed($start, $end) |
||
105 | |||
106 | /** |
||
107 | * @param string $start |
||
108 | * @param string $end |
||
109 | * |
||
110 | * @return self |
||
111 | */ |
||
112 | public static function halfOpen($start, $end) |
||
116 | |||
117 | /** |
||
118 | * @param string $start |
||
119 | * @param string $end |
||
120 | * |
||
121 | * @return self |
||
122 | */ |
||
123 | 1 | public static function open($start, $end) |
|
127 | |||
128 | /** |
||
129 | * Create interval from string. |
||
130 | * |
||
131 | * Example formats for all interval types: |
||
132 | * [10.0.1.0, 10.0.1.255] |
||
133 | * (10.0.0.0, 10.255.255.255] |
||
134 | * [172.16.0.0, 172.31.255.255) |
||
135 | * (192.168.0.0, 192.168.255.255) |
||
136 | * |
||
137 | * Spaces are ignored in format. |
||
138 | * |
||
139 | * @param string $string |
||
140 | * |
||
141 | * @return self |
||
142 | */ |
||
143 | 2 | public static function fromString($string) |
|
151 | |||
152 | /** |
||
153 | * Checks if this interval is equal to the specified interval. |
||
154 | * |
||
155 | * @param IPv4Interval $interval |
||
156 | * |
||
157 | * @return bool |
||
158 | */ |
||
159 | public function equal(self $interval) |
||
163 | |||
164 | /** |
||
165 | * Does this interval contain the specified point. |
||
166 | * |
||
167 | * @param string $point |
||
168 | * |
||
169 | * @return bool |
||
170 | */ |
||
171 | public function contains($point) |
||
175 | |||
176 | /** |
||
177 | * Does this interval intersect the specified interval. |
||
178 | * |
||
179 | * @param IPv4Interval $interval |
||
180 | * |
||
181 | * @return bool |
||
182 | */ |
||
183 | public function intersects(self $interval) |
||
187 | |||
188 | /** |
||
189 | * Gets the intersection between this interval and another interval. |
||
190 | * |
||
191 | * @param IPv4Interval $interval |
||
192 | * |
||
193 | * @return self|null |
||
194 | */ |
||
195 | public function intersection(self $interval) |
||
199 | |||
200 | /** |
||
201 | * Gets the covered interval between this Interval and another interval. |
||
202 | * |
||
203 | * @param IPv4Interval $interval |
||
204 | * |
||
205 | * @return self |
||
206 | */ |
||
207 | public function cover(self $interval) |
||
211 | |||
212 | /** |
||
213 | * Gets the gap between this interval and another interval. |
||
214 | * |
||
215 | * @param IPv4Interval $interval |
||
216 | * |
||
217 | * @return self|null |
||
218 | */ |
||
219 | public function gap(self $interval) |
||
223 | |||
224 | /** |
||
225 | * Does this interval abuts with the interval specified. |
||
226 | * |
||
227 | * @param IPv4Interval $interval |
||
228 | * |
||
229 | * @return bool |
||
230 | */ |
||
231 | public function abuts(self $interval) |
||
235 | |||
236 | /** |
||
237 | * Joins the interval between the adjacent. |
||
238 | * |
||
239 | * @param IPv4Interval $interval |
||
240 | * |
||
241 | * @return self|null |
||
242 | */ |
||
243 | public function join(self $interval) |
||
247 | |||
248 | /** |
||
249 | * Gets the union between this interval and another interval. |
||
250 | * |
||
251 | * @param IPv4Interval $interval |
||
252 | * |
||
253 | * @return self|null |
||
254 | */ |
||
255 | public function union(self $interval) |
||
259 | |||
260 | /** |
||
261 | * The point is before the interval. |
||
262 | * |
||
263 | * @param string $point |
||
264 | * |
||
265 | * @return bool |
||
266 | */ |
||
267 | public function before($point) |
||
268 | { |
||
269 | return $this->comparator->before(new IPv4IntervalPoint($point)); |
||
270 | } |
||
271 | |||
272 | /** |
||
273 | * The point is after the interval. |
||
274 | * |
||
275 | * @param string $point |
||
276 | * |
||
277 | * @return bool |
||
278 | */ |
||
279 | public function after($point) |
||
283 | |||
284 | /** |
||
285 | * @param int $step |
||
286 | * |
||
287 | * @return \Generator |
||
288 | */ |
||
289 | 2 | View Code Duplication | public function iterate($step = 1) |
|
|||
290 | { |
||
291 | 2 | $end = $this->endPoint()->value(); |
|
292 | 2 | $ip = $this->startPoint()->value(); |
|
293 | |||
294 | 2 | if ($this->type->startExcluded()) { |
|
295 | 1 | $ip += $step; |
|
296 | } |
||
297 | |||
298 | 2 | while ($ip < $end || (!$this->type->endExcluded() && $ip == $end)) { |
|
299 | 2 | yield long2ip($ip); |
|
300 | 2 | $ip += $step; |
|
301 | } |
||
302 | 2 | } |
|
303 | |||
304 | /** |
||
305 | * @return IntervalType |
||
306 | */ |
||
307 | public function type() |
||
311 | |||
312 | /** |
||
313 | * @return string |
||
314 | */ |
||
315 | public function start() |
||
319 | |||
320 | /** |
||
321 | * @return string |
||
322 | */ |
||
323 | public function end() |
||
327 | |||
328 | /** |
||
329 | * @return IPv4IntervalPoint |
||
330 | */ |
||
331 | 3 | public function startPoint() |
|
335 | |||
336 | /** |
||
337 | * @return IPv4IntervalPoint |
||
338 | */ |
||
339 | 3 | public function endPoint() |
|
343 | |||
344 | /** |
||
345 | * Returns a copy of this Interval with the start point altered. |
||
346 | * |
||
347 | * @param IntervalPointInterface|IPv4IntervalPoint $start |
||
348 | * |
||
349 | * @return self |
||
350 | */ |
||
351 | public function withStart(IntervalPointInterface $start) |
||
355 | |||
356 | /** |
||
357 | * Returns a copy of this Interval with the end point altered. |
||
358 | * |
||
359 | * @param IntervalPointInterface|IPv4IntervalPoint $end |
||
360 | * |
||
361 | * @return self |
||
362 | */ |
||
363 | public function withEnd(IntervalPointInterface $end) |
||
367 | |||
368 | /** |
||
369 | * Returns a copy of this Interval with the interval type altered. |
||
370 | * |
||
371 | * @param IntervalType $type |
||
372 | * |
||
373 | * @return self |
||
374 | */ |
||
375 | public function withType(IntervalType $type) |
||
379 | |||
380 | /** |
||
381 | * @return string |
||
382 | */ |
||
383 | 1 | public function __toString() |
|
387 | } |
||
388 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.