GpsLab\Bundle\GeoIP2Bundle\GpsLabGeoIP2Bundle::getContainerExtension()

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function getContainerExtension()
    {
        if (null === $this->extension) {
            $extension = $this->createContainerExtension();

            if ($extension instanceof ExtensionInterface) {
                $this->extension = $extension;
            } else {
                $this->extension = false;
            }
        }

        return $this->extension;

The expression $this->extension; of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|false adds false to the return on line 32 which is incompatible with the return type declared by the interface Symfony\Component\HttpKernel\Bundle\BundleInterface::getContainerExtension of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. It seems like you forgot to handle an error condition.

    }
}