GpsLab\Component\Command\Queue\PredisCommandQueue

Complexity

Total Complexity

5

Size/Duplication

Total Lines	73
Duplicated Lines	28.77 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	push()	0	6	1
A	pop()	21	21	3

<?php

/**
 * GpsLab component.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/MIT
 */

namespace GpsLab\Component\Command\Queue;

use GpsLab\Component\Command\Command;
use Predis\Client;
use Psr\Log\LoggerInterface;
use Symfony\Component\Serializer\Serializer;

class PredisCommandQueue implements CommandQueue
{
    const LIST_KEY = 'commands';
    const FORMAT = 'predis';

    /**
     * @var Client
     */
    private $client;

    /**
     * @var Serializer
     */
    private $serializer;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @param Client          $client
     * @param Serializer      $serializer
     * @param LoggerInterface $logger
     */
    public function __construct(Client $client, Serializer $serializer, LoggerInterface $logger)
    {
        $this->client = $client;
        $this->serializer = $serializer;
        $this->logger = $logger;
    }

    /**
     * Push command to queue.
     *
     * @param Command $command
     *
     * @return bool
     */
    public function push(Command $command)
    {
        $value = $this->serializer->normalize($command, self::FORMAT);

        return (bool) $this->client->rpush(self::LIST_KEY, [$value]);
    }

    /**
     * Pop command from queue. Return NULL if queue is empty.
     *
     * @return Command|null
     */
    public function pop()

This method seems to be duplicated in your project.

    {
        $value = $this->client->lpop(self::LIST_KEY);

        if (!$value) {
            return null;
        }

        try {
            return $this->serializer->denormalize($value, Command::class, self::FORMAT);
        } catch (\Exception $e) {
            // it's a critical error
            // it is necessary to react quickly to it
            $this->logger->critical('Failed denormalize a command in the Redis queue', [$value, $e->getMessage()]);

            // try denormalize in later
            $this->client->rpush(self::LIST_KEY, [$value]);

            return null;
        }
    }
}