Generator - Code Metrics - Inspection of "Refactoring" - gplcart/skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f62bbe...8c83be )

by Iurii

created 2017-09-04 13:15 UTC

Generator B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	408
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	49
lcom	1
cbo	0
dl	0
loc	408
rs	8.5454
c	0
b	0
f	0

21 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	getLicenses()	9	1
A	generate()	10	1
A	createManifest()	19	3
C	createStructure()	40	11
A	createStructureAsset()	10	3
A	generateImage()	16	2
A	createStructureLocale()	9	2
A	createStructureController()	8	2
A	createMainClass()	6	2
A	createStructureModel()	8	2
A	createStructureHelper()	8	2
A	createStructureHandler()	8	2
A	createStructureOverride()	8	2
A	createStructureTemplate()	8	2
A	createZip()	12	2
A	getZip()	4	1
A	prepareFolder()	4	2
A	setData()	11	1
A	render()	13	2
A	write()	14	3

How to fix Complexity

<?php

/**
 * @package Skeleton module
 * @author Iurii Makukh <[email protected]>
 * @copyright Copyright (c) 2015, Iurii Makukh
 * @license https://www.gnu.org/licenses/gpl.html GNU/GPLv3
 */

namespace gplcart\modules\skeleton\models;

use gplcart\core\Model;
use gplcart\core\helpers\Zip as ZipHelper;

/**
 * Methods to generate module skeletons
 */
class Generator extends Model
{

    /**
     * Name of folder that contains module controllers
     */
    const FOLDER_CONTROLLER = 'controllers';

    /**
     * Name of folder that contains module helpers
     */
    const FOLDER_HELPER = 'helpers';

    /**
     * Name of folder that contains module models
     */
    const FOLDER_MODEL = 'models';

    /**
     * Name of folder that contains module handlers
     */
    const FOLDER_HANDLER = 'handlers';

    /**
     * Name of folder that contains module templates
     */
    const FOLDER_TEMPLATE = 'templates';

    /**
     * Name of folder that contains module overrides
     */
    const FOLDER_OVERRIDE = 'override';

    /**
     * Name of folder that contains module translations
     */
    const FOLDER_LOCALE = 'locale';

    /**
     * Name of folder that contains JS assets
     */
    const FOLDER_JS = 'js';

    /**
     * Name of folder that contains CSS assets
     */
    const FOLDER_CSS = 'css';

    /**
     * Name of folder that contains images
     */
    const FOLDER_IMAGE = 'image';

    /**
     * Zip class instance
     * @var \gplcart\core\helpers\Zip $zip
     */
    protected $zip;

    /**
     * Full path to a ZIP file containing generated module
     * @var string
     */
    protected $file;

    /**
     * The current module directory
     * @var string
     */
    protected $directory;

    /**
     * An array of module data
     * @var array
     */
    protected $data = array();

    /**
     * @param ZipHelper $zip
     */
    public function __construct(ZipHelper $zip)
    {
        parent::__construct();

        $this->zip = $zip;
    }

    /**
     * Returns an array of licenses and their URLs
     * @return array
     */
    public function getLicenses()
    {
        return array(
            'GPL-3.0+' => 'https://www.gnu.org/licenses/gpl-3.0.en.html',
            'MIT' => 'https://opensource.org/licenses/MIT',
            'Apache-2.0' => 'https://www.apache.org/licenses/LICENSE-2.0',
            'BSD-3-Clause' => 'https://opensource.org/licenses/BSD-3-Clause'
        );
    }

    /**
     * Generates module files and folders
     * @param array $data
     * @return bool
     */
    public function generate(array $data)
    {
        $this->setData($data);

        $this->createMainClass();
        $this->createManifest();
        $this->createStructure();

        return $this->createZip();
    }

    /**
     * Create module manifest file
     */
    protected function createManifest()
    {
        $data = array(
            'name' => $this->data['module']['name'],
            'version' => $this->data['module']['version'],
            'description' => $this->data['module']['description'],
            'author' => $this->data['module']['author'],
            'core' => $this->data['module']['core'],
            'license' => $this->data['module']['license']
        );

        if (!empty($this->data['structure']) && in_array('configurable', $this->data['structure'])) {
            $data['configure'] = 'admin/module/settings/' . $this->data['module']['id'];
            $data['settings'] = array();
        }

        $json = json_encode($data, JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT);
        file_put_contents("{$this->directory}/module.json", $json);
    }

    /**
     * Creates various structure elements
     */
    protected function createStructure()
    {
        $this->write("{$this->directory}/README.md", 'readme');
        $this->write("{$this->directory}/.gitignore", 'gitignore');
        $this->write("{$this->directory}/composer.json", 'composer');
        $this->write("{$this->directory}/.scrutinizer.yml", 'scrutinizer');

        if (empty($this->data['structure'])) {
            return null;
        }

        foreach ($this->data['structure'] as $element) {
            switch ($element) {
                case 'controller':
                    $this->createStructureController();
                    break;
                case 'model':
                    $this->createStructureModel();
                    break;
                case 'helper':
                    $this->createStructureHelper();
                    break;
                case 'handler':
                    $this->createStructureHandler();
                    break;
                case 'override':
                    $this->createStructureOverride();
                    break;
                case 'template':
                    $this->createStructureTemplate();
                    break;
                case 'asset':
                    $this->createStructureAsset();
                    break;
                case 'locale':
                    $this->createStructureLocale();
                    break;
            }
        }
    }

    /**
     * Creates asset structure
     */
    protected function createStructureAsset()
    {
        foreach (array(self::FOLDER_CSS, self::FOLDER_JS) as $folder) {
            if ($this->prepareFolder("{$this->directory}/$folder")) {
                $this->write("{$this->directory}/$folder/common.$folder", $folder);
            }
        }

        $this->generateImage();
    }

    /**
     * Generate an image sample
     * @return bool
     */
    protected function generateImage()
    {
        $directory = $this->directory . '/' . self::FOLDER_IMAGE;

        if (!mkdir($directory, 0775, true)) {
            return false;
        }

        $im = imagecreate(100, 100);
        $bg = imagecolorallocate($im, 255, 255, 255);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $text = imagecolorallocate($im, 0, 0, 255);
        imagestring($im, 5, 0, 0, $this->data['module']['name'], $text);
        $result = imagepng($im, "$directory/image.png");
        imagedestroy($im);
        return $result;
    }

    /**
     * Creates locale structure
     */
    protected function createStructureLocale()
    {
        $folder = $this->directory . '/' . self::FOLDER_LOCALE;

        if ($this->prepareFolder($folder)) {
            $name = $this->data['module']['name'];
            gplcart_file_csv("$folder/en.csv", array($name, $name));
        }
    }

    /**
     * Creates a controller class
     */
    protected function createStructureController()
    {
        $folder = $this->directory . '/' . self::FOLDER_CONTROLLER;

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/Settings.php", 'controller');
        }
    }

    /**
     * Creates module main class
     */
    protected function createMainClass()
    {
        if ($this->prepareFolder($this->directory)) {
            $this->write("{$this->directory}/{$this->data['module']['class_name']}.php", 'main');
        }
    }

    /**
     * Creates a model class
     */
    protected function createStructureModel()
    {
        $folder = $this->directory . '/' . self::FOLDER_MODEL;

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/{$this->data['module']['class_name']}.php", 'model');
        }
    }

    /**
     * Creates a helper class
     */
    protected function createStructureHelper()
    {
        $folder = $this->directory . '/' . self::FOLDER_HELPER;

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/{$this->data['module']['class_name']}.php", 'helper');
        }
    }

    /**
     * Creates a handler class
     */
    protected function createStructureHandler()
    {
        $folder = $this->directory . '/' . self::FOLDER_HANDLER;

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/{$this->data['module']['class_name']}.php", 'handler');
        }
    }

    /**
     * Creates module overrides
     */
    protected function createStructureOverride()
    {
        $folder = $this->directory . '/' . self::FOLDER_OVERRIDE . "/classes/modules/{$this->data['module']['id']}";

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/{$this->data['module']['class_name']}Override.php", 'override');
        }
    }

    /**
     * Creates a template sample
     */
    protected function createStructureTemplate()
    {
        $folder = $this->directory . '/' . self::FOLDER_TEMPLATE;

        if ($this->prepareFolder($folder)) {
            $this->write("$folder/settings.php", 'template');
        }
    }

    /**
     * Pack module folder into zip file
     * @return bool
     */
    protected function createZip()
    {
        $this->file = "{$this->directory}.zip";

        if (is_file($this->file)) {
            unlink($this->file);
        }

        $result = $this->zip->folder($this->directory, $this->file, $this->data['module']['id']);
        gplcart_file_delete_recursive($this->directory);
        return $result;
    }

    /**
     * Returns a path to zip file
     * @return string
     */
    public function getZip()
    {
        return $this->file;
    }

    /**
     * Recursively creates folders
     * @param string $folder
     * @return bool
     */
    protected function prepareFolder($folder)
    {
        return !file_exists($folder) && mkdir($folder, 0775, true);
    }

    /**
     * Prepares an array of data before rendering
     * @param array $data
     * @return array
     */
    protected function setData(array &$data)
    {
        $licenses = $this->getLicenses();

        $data['module']['class_name'] = $this->config->getModuleClassName($data['module']['id']);
        $data['module']['namespace'] = $this->config->getModuleClassNamespace($data['module']['id']);
        $data['module']['license_url'] = $licenses[$data['module']['license']] . ' ' . $data['module']['license'];

        $this->directory = gplcart_file_unique(GC_PRIVATE_DOWNLOAD_DIR . "/skeleton/{$data['module']['id']}");
        return $this->data = $data;
    }

    /**
     * Renders a template
     * @param string $template
     * @return string|null
     */
    protected function render($template)
    {
        $file = GC_MODULE_DIR . "/skeleton/templates/code/$template.php";

        if (!is_file($file)) {
            return null;
        }

        extract($this->data, EXTR_SKIP);
        ob_start();
        include $file;
        return ob_get_clean();
    }

    /**
     * Writes to a file using a template as an source
     * @param string $file
     * @param string $template
     * @return null|bool
     */
    protected function write($file, $template)
    {
        $content = $this->render($template);

        if (!isset($content)) {
            return null;
        }

        if (pathinfo($file, PATHINFO_EXTENSION) === 'php') {
            $content = "<?php\n\n$content";
        }

        return file_put_contents($file, $content) !== false;
    }

}


1			<?php
2
3			/**
4			* @package Skeleton module
5			* @author Iurii Makukh <[email protected]>
6			* @copyright Copyright (c) 2015, Iurii Makukh
7			* @license https://www.gnu.org/licenses/gpl.html GNU/GPLv3
8			*/
9
10			namespace gplcart\modules\skeleton\models;
11
12			use gplcart\core\Model;
13			use gplcart\core\helpers\Zip as ZipHelper;
14
15			/**
16			* Methods to generate module skeletons
17			*/
18			class Generator extends Model
19			{
20
21			/**
22			* Name of folder that contains module controllers
23			*/
24			const FOLDER_CONTROLLER = 'controllers';
25
26			/**
27			* Name of folder that contains module helpers
28			*/
29			const FOLDER_HELPER = 'helpers';
30
31			/**
32			* Name of folder that contains module models
33			*/
34			const FOLDER_MODEL = 'models';
35
36			/**
37			* Name of folder that contains module handlers
38			*/
39			const FOLDER_HANDLER = 'handlers';
40
41			/**
42			* Name of folder that contains module templates
43			*/
44			const FOLDER_TEMPLATE = 'templates';
45
46			/**
47			* Name of folder that contains module overrides
48			*/
49			const FOLDER_OVERRIDE = 'override';
50
51			/**
52			* Name of folder that contains module translations
53			*/
54			const FOLDER_LOCALE = 'locale';
55
56			/**
57			* Name of folder that contains JS assets
58			*/
59			const FOLDER_JS = 'js';
60
61			/**
62			* Name of folder that contains CSS assets
63			*/
64			const FOLDER_CSS = 'css';
65
66			/**
67			* Name of folder that contains images
68			*/
69			const FOLDER_IMAGE = 'image';
70
71			/**
72			* Zip class instance
73			* @var \gplcart\core\helpers\Zip $zip
74			*/
75			protected $zip;
76
77			/**
78			* Full path to a ZIP file containing generated module
79			* @var string
80			*/
81			protected $file;
82
83			/**
84			* The current module directory
85			* @var string
86			*/
87			protected $directory;
88
89			/**
90			* An array of module data
91			* @var array
92			*/
93			protected $data = array();
94
95			/**
96			* @param ZipHelper $zip
97			*/
98			public function __construct(ZipHelper $zip)
99			{
100			parent::__construct();
101
102			$this->zip = $zip;
103			}
104
105			/**
106			* Returns an array of licenses and their URLs
107			* @return array
108			*/
109			public function getLicenses()
110			{
111			return array(
112			'GPL-3.0+' => 'https://www.gnu.org/licenses/gpl-3.0.en.html',
113			'MIT' => 'https://opensource.org/licenses/MIT',
114			'Apache-2.0' => 'https://www.apache.org/licenses/LICENSE-2.0',
115			'BSD-3-Clause' => 'https://opensource.org/licenses/BSD-3-Clause'
116			);
117			}
118
119			/**
120			* Generates module files and folders
121			* @param array $data
122			* @return bool
123			*/
124			public function generate(array $data)
125			{
126			$this->setData($data);
127
128			$this->createMainClass();
129			$this->createManifest();
130			$this->createStructure();
131
132			return $this->createZip();
133			}
134
135			/**
136			* Create module manifest file
137			*/
138			protected function createManifest()
139			{
140			$data = array(
141			'name' => $this->data['module']['name'],
142			'version' => $this->data['module']['version'],
143			'description' => $this->data['module']['description'],
144			'author' => $this->data['module']['author'],
145			'core' => $this->data['module']['core'],
146			'license' => $this->data['module']['license']
147			);
148
149			if (!empty($this->data['structure']) && in_array('configurable', $this->data['structure'])) {
150			$data['configure'] = 'admin/module/settings/' . $this->data['module']['id'];
151			$data['settings'] = array();
152			}
153
154			$json = json_encode($data, JSON_UNESCAPED_SLASHES \| JSON_PRETTY_PRINT);
155			file_put_contents("{$this->directory}/module.json", $json);
156			}
157
158			/**
159			* Creates various structure elements
160			*/
161			protected function createStructure()
162			{
163			$this->write("{$this->directory}/README.md", 'readme');
164			$this->write("{$this->directory}/.gitignore", 'gitignore');
165			$this->write("{$this->directory}/composer.json", 'composer');
166			$this->write("{$this->directory}/.scrutinizer.yml", 'scrutinizer');
167
168			if (empty($this->data['structure'])) {
169			return null;
170			}
171
172			foreach ($this->data['structure'] as $element) {
173			switch ($element) {
174			case 'controller':
175			$this->createStructureController();
176			break;
177			case 'model':
178			$this->createStructureModel();
179			break;
180			case 'helper':
181			$this->createStructureHelper();
182			break;
183			case 'handler':
184			$this->createStructureHandler();
185			break;
186			case 'override':
187			$this->createStructureOverride();
188			break;
189			case 'template':
190			$this->createStructureTemplate();
191			break;
192			case 'asset':
193			$this->createStructureAsset();
194			break;
195			case 'locale':
196			$this->createStructureLocale();
197			break;
198			}
199			}
200			}
201
202			/**
203			* Creates asset structure
204			*/
205			protected function createStructureAsset()
206			{
207			foreach (array(self::FOLDER_CSS, self::FOLDER_JS) as $folder) {
208			if ($this->prepareFolder("{$this->directory}/$folder")) {
209			$this->write("{$this->directory}/$folder/common.$folder", $folder);
210			}
211			}
212
213			$this->generateImage();
214			}
215
216			/**
217			* Generate an image sample
218			* @return bool
219			*/
220			protected function generateImage()
221			{
222			$directory = $this->directory . '/' . self::FOLDER_IMAGE;
223
224			if (!mkdir($directory, 0775, true)) {
225			return false;
226			}
227
228			$im = imagecreate(100, 100);
229			$bg = imagecolorallocate($im, 255, 255, 255);
			0 ignored issues – show Unused Code introduced 2017-09-04 13:17 UTC by Report Bug Copy Issue Report `$bg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
230			$text = imagecolorallocate($im, 0, 0, 255);
231			imagestring($im, 5, 0, 0, $this->data['module']['name'], $text);
232			$result = imagepng($im, "$directory/image.png");
233			imagedestroy($im);
234			return $result;
235			}
236
237			/**
238			* Creates locale structure
239			*/
240			protected function createStructureLocale()
241			{
242			$folder = $this->directory . '/' . self::FOLDER_LOCALE;
243
244			if ($this->prepareFolder($folder)) {
245			$name = $this->data['module']['name'];
246			gplcart_file_csv("$folder/en.csv", array($name, $name));
247			}
248			}
249
250			/**
251			* Creates a controller class
252			*/
253			protected function createStructureController()
254			{
255			$folder = $this->directory . '/' . self::FOLDER_CONTROLLER;
256
257			if ($this->prepareFolder($folder)) {
258			$this->write("$folder/Settings.php", 'controller');
259			}
260			}
261
262			/**
263			* Creates module main class
264			*/
265			protected function createMainClass()
266			{
267			if ($this->prepareFolder($this->directory)) {
268			$this->write("{$this->directory}/{$this->data['module']['class_name']}.php", 'main');
269			}
270			}
271
272			/**
273			* Creates a model class
274			*/
275			protected function createStructureModel()
276			{
277			$folder = $this->directory . '/' . self::FOLDER_MODEL;
278
279			if ($this->prepareFolder($folder)) {
280			$this->write("$folder/{$this->data['module']['class_name']}.php", 'model');
281			}
282			}
283
284			/**
285			* Creates a helper class
286			*/
287			protected function createStructureHelper()
288			{
289			$folder = $this->directory . '/' . self::FOLDER_HELPER;
290
291			if ($this->prepareFolder($folder)) {
292			$this->write("$folder/{$this->data['module']['class_name']}.php", 'helper');
293			}
294			}
295
296			/**
297			* Creates a handler class
298			*/
299			protected function createStructureHandler()
300			{
301			$folder = $this->directory . '/' . self::FOLDER_HANDLER;
302
303			if ($this->prepareFolder($folder)) {
304			$this->write("$folder/{$this->data['module']['class_name']}.php", 'handler');
305			}
306			}
307
308			/**
309			* Creates module overrides
310			*/
311			protected function createStructureOverride()
312			{
313			$folder = $this->directory . '/' . self::FOLDER_OVERRIDE . "/classes/modules/{$this->data['module']['id']}";
314
315			if ($this->prepareFolder($folder)) {
316			$this->write("$folder/{$this->data['module']['class_name']}Override.php", 'override');
317			}
318			}
319
320			/**
321			* Creates a template sample
322			*/
323			protected function createStructureTemplate()
324			{
325			$folder = $this->directory . '/' . self::FOLDER_TEMPLATE;
326
327			if ($this->prepareFolder($folder)) {
328			$this->write("$folder/settings.php", 'template');
329			}
330			}
331
332			/**
333			* Pack module folder into zip file
334			* @return bool
335			*/
336			protected function createZip()
337			{
338			$this->file = "{$this->directory}.zip";
339
340			if (is_file($this->file)) {
341			unlink($this->file);
342			}
343
344			$result = $this->zip->folder($this->directory, $this->file, $this->data['module']['id']);
345			gplcart_file_delete_recursive($this->directory);
346			return $result;
347			}
348
349			/**
350			* Returns a path to zip file
351			* @return string
352			*/
353			public function getZip()
354			{
355			return $this->file;
356			}
357
358			/**
359			* Recursively creates folders
360			* @param string $folder
361			* @return bool
362			*/
363			protected function prepareFolder($folder)
364			{
365			return !file_exists($folder) && mkdir($folder, 0775, true);
366			}
367
368			/**
369			* Prepares an array of data before rendering
370			* @param array $data
371			* @return array
372			*/
373			protected function setData(array &$data)
374			{
375			$licenses = $this->getLicenses();
376
377			$data['module']['class_name'] = $this->config->getModuleClassName($data['module']['id']);
378			$data['module']['namespace'] = $this->config->getModuleClassNamespace($data['module']['id']);
379			$data['module']['license_url'] = $licenses[$data['module']['license']] . ' ' . $data['module']['license'];
380
381			$this->directory = gplcart_file_unique(GC_PRIVATE_DOWNLOAD_DIR . "/skeleton/{$data['module']['id']}");
382			return $this->data = $data;
383			}
384
385			/**
386			* Renders a template
387			* @param string $template
388			* @return string\|null
389			*/
390			protected function render($template)
391			{
392			$file = GC_MODULE_DIR . "/skeleton/templates/code/$template.php";
393
394			if (!is_file($file)) {
395			return null;
396			}
397
398			extract($this->data, EXTR_SKIP);
399			ob_start();
400			include $file;
401			return ob_get_clean();
402			}
403
404			/**
405			* Writes to a file using a template as an source
406			* @param string $file
407			* @param string $template
408			* @return null\|bool
409			*/
410			protected function write($file, $template)
411			{
412			$content = $this->render($template);
413
414			if (!isset($content)) {
415			return null;
416			}
417
418			if (pathinfo($file, PATHINFO_EXTENSION) === 'php') {
419			$content = "<?php\n\n$content";
420			}
421
422			return file_put_contents($file, $content) !== false;
423			}
424
425			}
426

gplcart / skeleton

Push — master ( f62bbe...8c83be )

Generator B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like