Issues in Scanner.php (master) - Issues in master - gplcart/file_manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

models/Scanner.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package File manager
 * @author Iurii Makukh <[email protected]>
 * @copyright Copyright (c) 2017, Iurii Makukh <[email protected]>
 * @license https://www.gnu.org/licenses/gpl-3.0.en.html GPL-3.0+
 */

namespace gplcart\modules\file_manager\models;

use FilesystemIterator;
use gplcart\core\Hook;
use gplcart\core\Module;
use gplcart\modules\file_manager\helpers\Filter;
use LimitIterator;

/**
 * Manages basic behaviors and data related to File manager module
 */
class Scanner
{

    /**
     * Hook class instance
     * @var \gplcart\core\Hook $hook
     */
    protected $hook;

    /**
     * Module class instance
     * @var \gplcart\core\Module $module
     */
    protected $module;

    /**
     * @param Hook $hook
     * @param Module $module
     */
    public function __construct(Hook $hook, Module $module)
    {
        $this->hook = $hook;
        $this->module = $module;
    }

    /**
     * Returns an array of scanned files or counts them
     * @param string $directory
     * @param array $options
     * @return array|integer
     */
    public function scan($directory, array $options = array())
    {
        set_time_limit(0);

        $options += array(
            'sort' => null,
            'order' => null,
            'filter_key' => null,
            'filter_value' => null
        );

        $result = null;
        $this->hook->attach('module.file_manager.scan.before', $directory, $options, $result, $this);

        if (isset($result)) {
            return $result;
        }

        $filters = $this->getFilters();
        $iterator = new Filter(new FilesystemIterator($directory), $options, $filters);

        if (!empty($options['count'])) {
            return iterator_count($iterator);
        }

        if (!empty($options['limit'])) {
            list($page, $limit) = $options['limit'];
            $iterator = new LimitIterator($iterator, $page, $limit);
        }

        $result = iterator_to_array($iterator);
        $this->sort($result, $options['sort'], $options['order']);

        $this->hook->attach('module.file_manager.scan.after', $directory, $options, $result, $this);
        return $result;
    }

    /**
     * Sorts an array of files
     * @param array $files
     * @param string $sort
     * @param string $order
     */
    protected function sort(array &$files, $sort, $order)
    {
        $sorters = $this->getSorters();

        if (isset($sorters[$sort]['handlers']['sort'])) {
            $function = $sorters[$sort]['handlers']['sort'];
            // Suppress errors, see https://bugs.php.net/bug.php?id=50688
            @uasort($files, function ($a, $b) use ($function, $order) {
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                return $function($a, $b, $order);
            });
        }
    }

    /**
     * Returns an array of supported filters
     * @return array
     */
    public function getFilters()
    {
        $filters = &gplcart_static('module.file_manager.filter.list');

        if (isset($filters)) {
            return $filters;
        }

        $filters = (array) gplcart_config_get(__DIR__ . '/../config/filters.php');
        $this->hook->attach('module.file_manager.filter.list', $filters, $this);
        return $filters;
    }

    /**
     * Returns an array of file sorters
     * @return array
     */
    public function getSorters()
    {
        $sorters = &gplcart_static('module.file_manager.sorter.list');

        if (isset($sorters)) {
            return $sorters;
        }

        $sorters = (array) gplcart_config_get(__DIR__ . '/../config/sorters.php');
        $this->hook->attach('module.file_manager.sorter.list', $sorters, $this);
        return $sorters;
    }

    /**
     * Returns a string with initial path to scan files
     * @param bool|null|string $absolute
     * @return string
     */
    public function getInitialPath($absolute = false)
    {
        $path = $this->module->getSettings('file_manager', 'initial_path');
        return $absolute ? gplcart_file_absolute($path) : $path;
    }

}


1			<?php
2
3			/**
4			* @package File manager
5			* @author Iurii Makukh <[email protected]>
6			* @copyright Copyright (c) 2017, Iurii Makukh <[email protected]>
7			* @license https://www.gnu.org/licenses/gpl-3.0.en.html GPL-3.0+
8			*/
9
10			namespace gplcart\modules\file_manager\models;
11
12			use FilesystemIterator;
13			use gplcart\core\Hook;
14			use gplcart\core\Module;
15			use gplcart\modules\file_manager\helpers\Filter;
16			use LimitIterator;
17
18			/**
19			* Manages basic behaviors and data related to File manager module
20			*/
21			class Scanner
22			{
23
24			/**
25			* Hook class instance
26			* @var \gplcart\core\Hook $hook
27			*/
28			protected $hook;
29
30			/**
31			* Module class instance
32			* @var \gplcart\core\Module $module
33			*/
34			protected $module;
35
36			/**
37			* @param Hook $hook
38			* @param Module $module
39			*/
40			public function __construct(Hook $hook, Module $module)
41			{
42			$this->hook = $hook;
43			$this->module = $module;
44			}
45
46			/**
47			* Returns an array of scanned files or counts them
48			* @param string $directory
49			* @param array $options
50			* @return array\|integer
51			*/
52			public function scan($directory, array $options = array())
53			{
54			set_time_limit(0);
55
56			$options += array(
57			'sort' => null,
58			'order' => null,
59			'filter_key' => null,
60			'filter_value' => null
61			);
62
63			$result = null;
64			$this->hook->attach('module.file_manager.scan.before', $directory, $options, $result, $this);
65
66			if (isset($result)) {
67			return $result;
68			}
69
70			$filters = $this->getFilters();
71			$iterator = new Filter(new FilesystemIterator($directory), $options, $filters);
72
73			if (!empty($options['count'])) {
74			return iterator_count($iterator);
75			}
76
77			if (!empty($options['limit'])) {
78			list($page, $limit) = $options['limit'];
79			$iterator = new LimitIterator($iterator, $page, $limit);
80			}
81
82			$result = iterator_to_array($iterator);
83			$this->sort($result, $options['sort'], $options['order']);
84
85			$this->hook->attach('module.file_manager.scan.after', $directory, $options, $result, $this);
86			return $result;
87			}
88
89			/**
90			* Sorts an array of files
91			* @param array $files
92			* @param string $sort
93			* @param string $order
94			*/
95			protected function sort(array &$files, $sort, $order)
96			{
97			$sorters = $this->getSorters();
98
99			if (isset($sorters[$sort]['handlers']['sort'])) {
100			$function = $sorters[$sort]['handlers']['sort'];
101			// Suppress errors, see https://bugs.php.net/bug.php?id=50688
102			@uasort($files, function ($a, $b) use ($function, $order) {
			0 ignored issues – show Security Best Practice introduced 2017-10-20 18:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
103			return $function($a, $b, $order);
104			});
105			}
106			}
107
108			/**
109			* Returns an array of supported filters
110			* @return array
111			*/
112			public function getFilters()
113			{
114			$filters = &gplcart_static('module.file_manager.filter.list');
115
116			if (isset($filters)) {
117			return $filters;
118			}
119
120			$filters = (array) gplcart_config_get(__DIR__ . '/../config/filters.php');
121			$this->hook->attach('module.file_manager.filter.list', $filters, $this);
122			return $filters;
123			}
124
125			/**
126			* Returns an array of file sorters
127			* @return array
128			*/
129			public function getSorters()
130			{
131			$sorters = &gplcart_static('module.file_manager.sorter.list');
132
133			if (isset($sorters)) {
134			return $sorters;
135			}
136
137			$sorters = (array) gplcart_config_get(__DIR__ . '/../config/sorters.php');
138			$this->hook->attach('module.file_manager.sorter.list', $sorters, $this);
139			return $sorters;
140			}
141
142			/**
143			* Returns a string with initial path to scan files
144			* @param bool\|null\|string $absolute
145			* @return string
146			*/
147			public function getInitialPath($absolute = false)
148			{
149			$path = $this->module->getSettings('file_manager', 'initial_path');
150			return $absolute ? gplcart_file_absolute($path) : $path;
151			}
152
153			}
154

gplcart / file_manager

Issues (2)

Security Analysis no request data

models/Scanner.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like