App\Service\ImageService

Complexity

Total Complexity

9

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Importance

Changes	8
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	25	2
A	setCalculatedImageUris()	0	7	1
A	setPropertiesFromEXIF()	0	36	6

<?php

namespace App\Service;

use App\Entity\Image;
use App\Repository\WanderRepository;
use App\Utils\ExifHelper;
use Deployer\Logger\Logger;
use Exception;
use Liip\ImagineBundle\Imagine\Cache\CacheManager;
use PHPExif\Adapter\Exiftool;
use PHPExif\Reader\Reader;
use Psr\Log\LoggerInterface;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Security;
use Vich\UploaderBundle\Templating\Helper\UploaderHelper;
use App\Utils\ExifHelperInterface;

class ImageService {

    /** @var UploaderHelper */
    private $uploaderHelper;

    /** @var CacheManager */
    private $imagineCacheManager;

    /** @var UrlGeneratorInterface */
    private $router;

    /** @var LoggerInterface */
    private $logger;

    /** @var WanderRepository */
    private $wanderRepository;

    /** @var Reader */
    private $reader;

    /** @var string */
    private $imagesDirectory;

    /** @var string */
    private $exiftoolPath;

    public function __construct(
        UploaderHelper $uploaderHelper,
        CacheManager $imagineCacheManager,
        UrlGeneratorInterface $router,
        LoggerInterface $logger,
        WanderRepository $wanderRepository,
        string $imagesDirectory,
        ?string $exiftoolPath)
    {
        $this->uploaderHelper = $uploaderHelper;
        $this->imagineCacheManager = $imagineCacheManager;
        $this->router = $router;
        $this->logger = $logger;
        $this->wanderRepository = $wanderRepository;
        $this->imagesDirectory = $imagesDirectory;
        $this->exiftoolPath = $exiftoolPath;

        if ($exiftoolPath !== null) {
            // Will throw if path is wrong
            $adapter = new Exiftool([
                'toolpath' => $exiftoolPath
            ]);
            $this->reader = new Reader($adapter);
        } else {
            $this->reader = Reader::factory(Reader::TYPE_EXIFTOOL);
        }
    }

    public function setCalculatedImageUris(Image $image): void
    {
        $image_asset_path = $this->uploaderHelper->asset($image);
        $image->setImageUri($image_asset_path);
        $image->setMarkerImageUri($this->imagineCacheManager->getBrowserPath($image_asset_path, 'marker_thumb'));
        $image->setMediumImageUri($this->imagineCacheManager->getBrowserPath($image_asset_path, 'map_popup_image'));
        $image->setImageShowUri($this->router->generate('image_show', ['id' => $image->getId()]));
    }

    public function setPropertiesFromEXIF(
            Image $image,
            bool $updateRelatedWanders = true
        ): void
    {
        if ($image->getMimeType() == 'image/jpeg') {
            try {
                $exif = $this->reader->read($this->imagesDirectory . '/' . $image->getName());
                /** @var ExifHelperInterface */
                $exifHelper = new ExifHelper($exif);

                $image->setTitle($exifHelper->getTitle());
                $image->setDescription($exifHelper->getDescription());
                $image->setLatlng($exifHelper->getGPS());

Are you sure the usage of $exifHelper->getGPS() targeting App\Utils\ExifHelper::getGPS() seems to always return null.

                $image->setKeywords($exifHelper->getKeywords());
                $image->setRating($exifHelper->getRating());

                $capturedAt = $exifHelper->getCreationDate();
                $image->setCapturedAt($capturedAt);

It seems like $capturedAt can also be of type null; however, parameter $capturedAt of App\Entity\Image::setCapturedAt() does only seem to accept DateTimeInterface, maybe add an additional type check?

                if ($capturedAt instanceof \DateTime && $updateRelatedWanders) {
                    // Try and find associated wander(s) by looking for
                    // wanders whose timespan includes this image.
                    $wanders = $this->wanderRepository->findWhereIncludesDate($capturedAt);
                    foreach ($wanders as $wander) {
                        $image->addWander($wander);
                    }
                }
            }
            catch(Exception $e) {
                // We've started to rely on the information gathered here, so I think
                // this should be a proper error now.
                throw new Exception('Error getting image Exif information: ' . $e->getMessage(), $e->getCode(), $e);
            }
        } else {
            $this->logger->info('Ignoring non-JPEG file when trying to set properties from EXIT.');
        }
    }
}