App\Service\SettingsService

Complexity

Total Complexity

15

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	displayTwitterCards()	0	3	1
A	getTwitterHandle()	0	3	1
A	getSiteAbout()	0	3	1
A	__construct()	0	13	2
A	getSiteTitle()	0	3	1
A	getSettings()	0	3	1
A	getSiteSubtitle()	0	3	1
A	getGravatarEmail()	0	3	1
A	getGravatarImageUrl()	0	15	5
A	getHasGravatar()	0	3	1

<?php

namespace App\Service;

use App\Repository\SettingsRepository;
use App\Entity\Settings;
use Doctrine\ORM\EntityManagerInterface;

class SettingsService
{
    /** @var Settings */
    private $settings;

    public function __construct(SettingsRepository $settingsRepository, EntityManagerInterface $entityManager)
    {
        $settings = $settingsRepository->getTheSingleRow();
        if ($settings === null) {
            // Minuscule chance of a race condition but in that worst-case scenario
            // we'll always bring back the first row from the database when we
            // getTheSingleRow() so all that will happen is that an extra row
            // will languish in the database forever.
            $settings = new Settings();
            $entityManager->persist($settings);
            $entityManager->flush();
        }
        $this->settings = $settings;
    }

    public function getSettings(): Settings
    {
        return $this->settings;
    }

    // Helpers for Twig
    public function getSiteTitle() : string
    {
        return $this->settings->getSiteTitle() ?? "";
    }

    public function getSiteSubtitle() : string
    {
        return $this->settings->getSiteSubtitle() ?? "";
    }

    public function getSiteAbout() : string
    {
        return $this->settings->getSiteAbout() ?? "";
    }

    public function displayTwitterCards(): bool
    {
        return !empty($this->settings->getTwitterHandle());
    }

    public function getTwitterHandle(): string
    {
        return $this->settings->getTwitterHandle() ?? "";
    }

    public function getGravatarEmail(): string
    {
        return $this->settings->getGravatarEmail() ?? "";
    }

    public function getGravatarImageUrl(int $size = 200): ?string
    {
        if (!is_int($size)) {

The condition is_int($size) is always true.

            return null;
        }
        if ($size < 0 || $size > 2000) {
            $size = 200;
        }
        $email = $this->settings->getGravatarEmail();
        if (!$email) {
            return null;
        }
        $hash = md5(trim(strtolower($email)));
        // TODO: This is hardcoded to 200px. Make it configurable.
        return "https://www.gravatar.com/avatar/$hash?s=$size";
    }

    public function getHasGravatar(): bool
    {
        return $this->settings->getGravatarEmail() != null;

It seems like you are loosely comparing $this->settings->getGravatarEmail() of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    }
}