SettingsService::__construct() - Code Metrics - Inspection of "Add Twitter Card support. Closes #49." - gothick/omm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by Matt

created 2021-05-19 23:04 UTC

SettingsService::__construct() A

↳ Parent: SettingsService

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	2
b	0
f	0
nc	2
nop	2
dl	0
loc	13
rs	10

<?php

namespace App\Service;

use App\Repository\SettingsRepository;
use App\Entity\Settings;
use Doctrine\ORM\EntityManagerInterface;

class SettingsService
{
    /** @var Settings */
    private $settings;

    public function __construct(SettingsRepository $settingsRepository, EntityManagerInterface $entityManager)
    {
        $settings = $settingsRepository->getTheSingleRow();
        if ($settings === null) {
            // Minuscule chance of a race condition but in that worst-case scenario
            // we'll always bring back the first row from the database when we
            // getTheSingleRow() so all that will happen is that an extra row
            // will languish in the database forever.
            $settings = new Settings();
            $entityManager->persist($settings);
            $entityManager->flush();
        }
        $this->settings = $settings;
    }

    public function getSettings(): Settings
    {
        return $this->settings;
    }

    // Helpers for Twig
    public function getSiteTitle() : string
    {
        return $this->settings->getSiteTitle() ?? "";
    }

    public function getSiteSubtitle() : string
    {
        return $this->settings->getSiteSubtitle() ?? "";
    }

    public function getSiteAbout() : string
    {
        return $this->settings->getSiteAbout() ?? "";
    }

    public function displayTwitterCards(): bool
    {
        return !empty($this->settings->getTwitterHandle());
    }

    public function getTwitterHandle(): string
    {
        return $this->settings->getTwitterHandle() ?? "";
    }
}

1			<?php
2
3			namespace App\Service;
4
5			use App\Repository\SettingsRepository;
6			use App\Entity\Settings;
7			use Doctrine\ORM\EntityManagerInterface;
8
9			class SettingsService
10			{
11			/** @var Settings */
12			private $settings;
13
14			public function __construct(SettingsRepository $settingsRepository, EntityManagerInterface $entityManager)
15			{
16			$settings = $settingsRepository->getTheSingleRow();
17			if ($settings === null) {
18			// Minuscule chance of a race condition but in that worst-case scenario
19			// we'll always bring back the first row from the database when we
20			// getTheSingleRow() so all that will happen is that an extra row
21			// will languish in the database forever.
22			$settings = new Settings();
23			$entityManager->persist($settings);
24			$entityManager->flush();
25			}
26			$this->settings = $settings;
27			}
28
29			public function getSettings(): Settings
30			{
31			return $this->settings;
32			}
33
34			// Helpers for Twig
35			public function getSiteTitle() : string
36			{
37			return $this->settings->getSiteTitle() ?? "";
38			}
39
40			public function getSiteSubtitle() : string
41			{
42			return $this->settings->getSiteSubtitle() ?? "";
43			}
44
45			public function getSiteAbout() : string
46			{
47			return $this->settings->getSiteAbout() ?? "";
48			}
49
50			public function displayTwitterCards(): bool
51			{
52			return !empty($this->settings->getTwitterHandle());
53			}
54
55			public function getTwitterHandle(): string
56			{
57			return $this->settings->getTwitterHandle() ?? "";
58			}
59			}

gothick / omm

Pull Request — master (#75)

SettingsService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like