App\Service\LocationService::setImageLocation()

Complexity

Conditions	5
Paths	4

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function setImageLocation(
        Image $image,
        bool $overwriteExisting = false
        ): bool
    {
        if ($overwriteExisting === false && $image->hasLocation()) {
            $this->logger->info('Deliberately not overwriting existing image location');
            return false;
        }

        if (!$image->hasLatlng()) {
            $this->logger->info('Ignoring image that has no latlng.');
            return false;
        }

        $neighbourhood = $this->neighbourhoodRepository
            ->findByLatlng($image->getLatitude(), $image->getLongitude());

It seems like $image->getLatitude() can also be of type null; however, parameter $lat of App\Repository\NeighbourhoodRepository::findByLatlng() does only seem to accept double, maybe add an additional type check?

It seems like $image->getLongitude() can also be of type null; however, parameter $lng of App\Repository\NeighbourhoodRepository::findByLatlng() does only seem to accept double, maybe add an additional type check?

        if ($neighbourhood === null) {
            return false;
        }

        $image->setLocation($neighbourhood->getLsoa11ln());
        return true;
    }
}