StatsController::index() - Code Metrics - Inspection of "Merge pull request #148 from gothick/TidyUp" - gothick/omm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 044bfa...4aef6e )

by Matt

created 2021-12-19 21:48 UTC

StatsController::index() A

↳ Parent: StatsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	54
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
eloc	33
c	4
b	0
f	0
nc	1
nop	2
dl	0
loc	54
rs	9.392

How to fix Long Method

<?php

namespace App\Controller;

use App\Service\StatsService;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\UX\Chartjs\Builder\ChartBuilderInterface;
use Symfony\UX\Chartjs\Model\Chart;

class StatsController extends AbstractController
{
    const WANDER_NUMBER_COLOUR = '#2491B3';
    const WANDER_DISTANCE_COLOUR = '#ffb266';
    const IMAGES_NUMBER_COLOUR = '#BF5439';
    /**
     * @Route("/stats", name="stats_index")
     */
    public function index(
        StatsService $statsService,
        ChartBuilderInterface $chartBuilder
    ): Response {
        $wanderStats = $statsService->getWanderStats();
        $imageStats = $statsService->getImageStats();

        $wanderDataSeries =
            [
                [
                    'label' => 'Number of Wanders',
                    'colour' => self::WANDER_NUMBER_COLOUR,
                    'extractFunction' => fn($dp): int => $dp['numberOfWanders'],
                ],
                [
                    'label' => 'Distance Walked (km)',
                    'colour' => self::WANDER_DISTANCE_COLOUR,
                    'extractFunction' => fn($dp): string => number_format($dp['totalDistance'] / 1000.0, 2)
                ]
            ];

        $monthlyWanderChart = $chartBuilder
            ->createChart(Chart::TYPE_BAR)
            ->setData($this->generatePeriodicChartData($wanderStats['monthlyStats'], $wanderDataSeries));

        $yearlyWanderChart = $chartBuilder
            ->createChart(Chart::TYPE_BAR)
            ->setData($this->generatePeriodicChartData($wanderStats['yearlyStats'], $wanderDataSeries));

        $imageDataSeries =
            [
                [
                    'label' => 'Photos Taken',
                    'colour' => self::IMAGES_NUMBER_COLOUR,
                    'extractFunction' => fn($dp): int => $dp['numberOfImages'],
                ]
            ];

        $monthlyImagesChart = $chartBuilder
            ->createChart(Chart::TYPE_BAR)
            ->setData($this->generatePeriodicChartData($wanderStats['monthlyStats'], $imageDataSeries));

        $yearlyImagesChart = $chartBuilder
            ->createChart(Chart::TYPE_BAR)
            ->setData($this->generatePeriodicChartData($wanderStats['yearlyStats'], $imageDataSeries));

        return $this->render('stats/index.html.twig', [
            'controller_name' => 'StatsController', // TODO: Remove this boilerplate
            'imageStats' => $imageStats,
            'wanderStats' => $wanderStats,
            'monthlyWanderChart' => $monthlyWanderChart,
            'yearlyWanderChart' => $yearlyWanderChart,
            'monthlyImagesChart' => $monthlyImagesChart,
            'yearlyImagesChart' => $yearlyImagesChart
        ]);
    }

    /**
     * @param array<string, mixed> $sourceStats
     * @param array<int, array<string, mixed>> $seriesDefinitions
     * @return array<string, mixed>
     */
    private function generatePeriodicChartData(
        array $sourceStats,
        array $seriesDefinitions
    ): array {
        $data = [
            'labels' => array_map(fn($dp): string => $dp['periodLabel'], $sourceStats)
        ];
        foreach ($seriesDefinitions as $series) {
            $data['datasets'][] = [
                'label' => $series['label'],
                'backgroundColor' => $series['colour'],
                'borderColor' => 'black',
                'borderWidth' => 1,
                'borderRadius' => 5,
                'data' => array_map($series['extractFunction'], $sourceStats)
            ];
        }
        return $data;
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use App\Service\StatsService;
6			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
7			use Symfony\Component\HttpFoundation\Response;
8			use Symfony\Component\Routing\Annotation\Route;
9			use Symfony\UX\Chartjs\Builder\ChartBuilderInterface;
10			use Symfony\UX\Chartjs\Model\Chart;
11
12			class StatsController extends AbstractController
13			{
14			const WANDER_NUMBER_COLOUR = '#2491B3';
15			const WANDER_DISTANCE_COLOUR = '#ffb266';
16			const IMAGES_NUMBER_COLOUR = '#BF5439';
17			/**
18			* @Route("/stats", name="stats_index")
19			*/
20			public function index(
21			StatsService $statsService,
22			ChartBuilderInterface $chartBuilder
23			): Response {
24			$wanderStats = $statsService->getWanderStats();
25			$imageStats = $statsService->getImageStats();
26
27			$wanderDataSeries =
28			[
29			[
30			'label' => 'Number of Wanders',
31			'colour' => self::WANDER_NUMBER_COLOUR,
32			'extractFunction' => fn($dp): int => $dp['numberOfWanders'],
33			],
34			[
35			'label' => 'Distance Walked (km)',
36			'colour' => self::WANDER_DISTANCE_COLOUR,
37			'extractFunction' => fn($dp): string => number_format($dp['totalDistance'] / 1000.0, 2)
38			]
39			];
40
41			$monthlyWanderChart = $chartBuilder
42			->createChart(Chart::TYPE_BAR)
43			->setData($this->generatePeriodicChartData($wanderStats['monthlyStats'], $wanderDataSeries));
44
45			$yearlyWanderChart = $chartBuilder
46			->createChart(Chart::TYPE_BAR)
47			->setData($this->generatePeriodicChartData($wanderStats['yearlyStats'], $wanderDataSeries));
48
49			$imageDataSeries =
50			[
51			[
52			'label' => 'Photos Taken',
53			'colour' => self::IMAGES_NUMBER_COLOUR,
54			'extractFunction' => fn($dp): int => $dp['numberOfImages'],
55			]
56			];
57
58			$monthlyImagesChart = $chartBuilder
59			->createChart(Chart::TYPE_BAR)
60			->setData($this->generatePeriodicChartData($wanderStats['monthlyStats'], $imageDataSeries));
61
62			$yearlyImagesChart = $chartBuilder
63			->createChart(Chart::TYPE_BAR)
64			->setData($this->generatePeriodicChartData($wanderStats['yearlyStats'], $imageDataSeries));
65
66			return $this->render('stats/index.html.twig', [
67			'controller_name' => 'StatsController', // TODO: Remove this boilerplate
68			'imageStats' => $imageStats,
69			'wanderStats' => $wanderStats,
70			'monthlyWanderChart' => $monthlyWanderChart,
71			'yearlyWanderChart' => $yearlyWanderChart,
72			'monthlyImagesChart' => $monthlyImagesChart,
73			'yearlyImagesChart' => $yearlyImagesChart
74			]);
75			}
76
77			/**
78			* @param array<string, mixed> $sourceStats
79			* @param array<int, array<string, mixed>> $seriesDefinitions
80			* @return array<string, mixed>
81			*/
82			private function generatePeriodicChartData(
83			array $sourceStats,
84			array $seriesDefinitions
85			): array {
86			$data = [
87			'labels' => array_map(fn($dp): string => $dp['periodLabel'], $sourceStats)
88			];
89			foreach ($seriesDefinitions as $series) {
90			$data['datasets'][] = [
91			'label' => $series['label'],
92			'backgroundColor' => $series['colour'],
93			'borderColor' => 'black',
94			'borderWidth' => 1,
95			'borderRadius' => 5,
96			'data' => array_map($series['extractFunction'], $sourceStats)
97			];
98			}
99			return $data;
100			}
101			}
102

gothick / omm

Push — master ( 044bfa...4aef6e )

StatsController::index() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like