ProblemController::index() - Code Metrics - Inspection of "Remove manual error generator from Problem control..." - gothick/omm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 80501b...32cadd )

by Matt

created 2021-05-23 16:45 UTC

ProblemController::index() A

↳ Parent: ProblemController

Complexity

Conditions	1
Paths	1

Size

Total Lines	62
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	39
c	2
b	0
f	0
nc	1
nop	3
dl	0
loc	62
rs	9.296

How to fix Long Method

<?php

namespace App\Controller\Admin;

use App\Entity\Wander;
use App\Repository\ImageRepository;
use App\Repository\ProblemRepository;
use App\Repository\WanderRepository;
use App\Service\ProblemService;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * @Route("/admin/problems", name="admin_problems_")
 */
class ProblemController extends AbstractController
{
    /**
     * @Route("/", name="index", methods={"GET"})
     */
    public function index(
        WanderRepository $wanderRepository,
        ImageRepository $imageRepository,
        ProblemRepository $problemRepository
        ): Response
    {
        // Problems that might take time/resources to find, that are
        // popped into a table on specific demand rather than every
        // time we load this page:
        $builtProblems = $problemRepository->findAll();

        // TODO: Might be sensible to do everything here into the problems
        // table, depending on how much we add to this.
        // Other issues, found on the fly:
        $qb = $wanderRepository->createQueryBuilder('w');

        // TODO: This doesn't work, as e.g. keywords being an empty array
        //
        $problems = $qb
            ->join('w.images', 'i')
            ->select('w AS wander')
            ->addSelect('COUNT(i) AS image_count')
            ->addSelect('SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END) AS no_title')
            ->addSelect('SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END) AS no_latlng')
            ->addSelect('SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END) AS no_location')
            ->addSelect('SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END) AS no_rating')
            // TODO: This is a hideous bodge and will break when we finally give in and move
            // keywords and auto-tags to being related entities rather than a dirty PHP
            // array, but it's good enough for a problem admin page for now.
            //->addSelect("SUM(CASE WHEN i.keywords IS NULL OR i.keywords = 'a:0:{}' THEN 1 ELSE 0 END) AS no_keywords")
            ->addSelect("SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END) AS no_tags")
            ->addSelect("SUM(CASE WHEN i.auto_tags IS NULL OR i.auto_tags = 'a:0:{}' THEN 1 ELSE 0 END) AS no_auto_tags")

            ->addSelect(
                "(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) AS total_problems_excl_auto")
            ->addSelect(
                "(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
                "(10 * SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
                "(2 * SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
                "(5 * SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
                "(0.01 * SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) + " .
                "(0.001 * SUM(CASE WHEN i.auto_tags IS NULL OR i.auto_tags = 'a:0:{}' THEN 1 ELSE 0 END)) AS weighted_problem_score")
            ->addGroupBy('w')
            ->having('no_title > 0')
            ->orHaving('no_latlng > 0')
            ->orHaving('no_location > 0')
            ->orHaving('no_tags > 0')
            ->orHaving('no_auto_tags > 0')
            ->orderBy('weighted_problem_score', 'desc')
            ->getQuery()
            ->getResult();

        $orphans = $imageRepository->findWithNoWander();

        return $this->render('admin/problems/index.html.twig', [
            'problems' => $problems,
            'orphans' => $orphans,
            'built_problems' => $builtProblems
        ]);
    }

    /**
     * @Route("/regenerate", name="regenerate", methods={"POST"})
     */
    public function regenerateProblems(Request $request, ProblemService $problemService): Response
    {
        if ($this->isCsrfTokenValid('problems_regenerate', $request->request->get('_token'))) {
            $problemService->createProblemReport();
        }

        return $this->redirectToRoute('admin_problems_index');
    }


    // TODO: These all share a lot of things in common, but I'm not sure
    // how much this is going to get used, so I'm keeping it fairly brain-dead
    // for now. Revisit later.

    /**
     * @Route("/no_title/wander/{id}", name="no_title", methods={"GET"})
     */
    public function noTitle(Wander $wander): Response
    {
        return $this->render('admin/problems/no_title.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_latlng/wander/{id}", name="no_latlng", methods={"GET"})
     */
    public function noLatlng(Wander $wander): Response
    {
        return $this->render('admin/problems/no_latlng.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_location/wander/{id}", name="no_location", methods={"GET"})
     */
    public function noLocation(Wander $wander): Response
    {
        return $this->render('admin/problems/no_location.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_rating/wander/{id}", name="no_rating", methods={"GET"})
     */
    public function noRating(Wander $wander): Response
    {
        return $this->render('admin/problems/no_rating.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/no_tags/wander/{id}", name="no_tags", methods={"GET"})
     */
    public function noTags(Wander $wander): Response
    {
        return $this->render('admin/problems/no_tags.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/no_auto_tags/wander/{id}", name="no_auto_tags", methods={"GET"})
     */
    public function noAutoTags(Wander $wander): Response
    {
        return $this->render('admin/problems/no_auto_tags.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/broken_links", name="broken_links", methods={"GET"})
     */
    public function brokenLinks(ProblemRepository $problemRepository): Response
    {
        $problems = $problemRepository->findAll();
        return $this->render('admin/problems/broken_links.html.twig', [
            'problems' => $problems
        ]);
    }
}


1			<?php
2
3			namespace App\Controller\Admin;
4
5			use App\Entity\Wander;
6			use App\Repository\ImageRepository;
7			use App\Repository\ProblemRepository;
8			use App\Repository\WanderRepository;
9			use App\Service\ProblemService;
10			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
11			use Symfony\Component\HttpFoundation\Request;
12			use Symfony\Component\HttpFoundation\Response;
13			use Symfony\Component\Routing\Annotation\Route;
14
15			/**
16			* @Route("/admin/problems", name="admin_problems_")
17			*/
18			class ProblemController extends AbstractController
19			{
20			/**
21			* @Route("/", name="index", methods={"GET"})
22			*/
23			public function index(
24			WanderRepository $wanderRepository,
25			ImageRepository $imageRepository,
26			ProblemRepository $problemRepository
27			): Response
28			{
29			// Problems that might take time/resources to find, that are
30			// popped into a table on specific demand rather than every
31			// time we load this page:
32			$builtProblems = $problemRepository->findAll();
33
34			// TODO: Might be sensible to do everything here into the problems
35			// table, depending on how much we add to this.
36			// Other issues, found on the fly:
37			$qb = $wanderRepository->createQueryBuilder('w');
38
39			// TODO: This doesn't work, as e.g. keywords being an empty array
40			//
41			$problems = $qb
42			->join('w.images', 'i')
43			->select('w AS wander')
44			->addSelect('COUNT(i) AS image_count')
45			->addSelect('SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END) AS no_title')
46			->addSelect('SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END) AS no_latlng')
47			->addSelect('SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END) AS no_location')
48			->addSelect('SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END) AS no_rating')
49			// TODO: This is a hideous bodge and will break when we finally give in and move
50			// keywords and auto-tags to being related entities rather than a dirty PHP
51			// array, but it's good enough for a problem admin page for now.
52			//->addSelect("SUM(CASE WHEN i.keywords IS NULL OR i.keywords = 'a:0:{}' THEN 1 ELSE 0 END) AS no_keywords")
53			->addSelect("SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END) AS no_tags")
54			->addSelect("SUM(CASE WHEN i.auto_tags IS NULL OR i.auto_tags = 'a:0:{}' THEN 1 ELSE 0 END) AS no_auto_tags")
55
56			->addSelect(
57			"(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
58			"(SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
59			"(SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
60			"(SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
61			"(SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) AS total_problems_excl_auto")
62			->addSelect(
63			"(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
64			"(10 * SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
65			"(2 * SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
66			"(5 * SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
67			"(0.01 * SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) + " .
68			"(0.001 * SUM(CASE WHEN i.auto_tags IS NULL OR i.auto_tags = 'a:0:{}' THEN 1 ELSE 0 END)) AS weighted_problem_score")
69			->addGroupBy('w')
70			->having('no_title > 0')
71			->orHaving('no_latlng > 0')
72			->orHaving('no_location > 0')
73			->orHaving('no_tags > 0')
74			->orHaving('no_auto_tags > 0')
75			->orderBy('weighted_problem_score', 'desc')
76			->getQuery()
77			->getResult();
78
79			$orphans = $imageRepository->findWithNoWander();
80
81			return $this->render('admin/problems/index.html.twig', [
82			'problems' => $problems,
83			'orphans' => $orphans,
84			'built_problems' => $builtProblems
85			]);
86			}
87
88			/**
89			* @Route("/regenerate", name="regenerate", methods={"POST"})
90			*/
91			public function regenerateProblems(Request $request, ProblemService $problemService): Response
92			{
93			if ($this->isCsrfTokenValid('problems_regenerate', $request->request->get('_token'))) {
94			$problemService->createProblemReport();
95			}
96
97			return $this->redirectToRoute('admin_problems_index');
98			}
99
100
101			// TODO: These all share a lot of things in common, but I'm not sure
102			// how much this is going to get used, so I'm keeping it fairly brain-dead
103			// for now. Revisit later.
104
105			/**
106			* @Route("/no_title/wander/{id}", name="no_title", methods={"GET"})
107			*/
108			public function noTitle(Wander $wander): Response
109			{
110			return $this->render('admin/problems/no_title.html.twig', [
111			'wander' => $wander
112			]);
113			}
114			/**
115			* @Route("/no_latlng/wander/{id}", name="no_latlng", methods={"GET"})
116			*/
117			public function noLatlng(Wander $wander): Response
118			{
119			return $this->render('admin/problems/no_latlng.html.twig', [
120			'wander' => $wander
121			]);
122			}
123			/**
124			* @Route("/no_location/wander/{id}", name="no_location", methods={"GET"})
125			*/
126			public function noLocation(Wander $wander): Response
127			{
128			return $this->render('admin/problems/no_location.html.twig', [
129			'wander' => $wander
130			]);
131			}
132			/**
133			* @Route("/no_rating/wander/{id}", name="no_rating", methods={"GET"})
134			*/
135			public function noRating(Wander $wander): Response
136			{
137			return $this->render('admin/problems/no_rating.html.twig', [
138			'wander' => $wander
139			]);
140			}
141
142			/**
143			* @Route("/no_tags/wander/{id}", name="no_tags", methods={"GET"})
144			*/
145			public function noTags(Wander $wander): Response
146			{
147			return $this->render('admin/problems/no_tags.html.twig', [
148			'wander' => $wander
149			]);
150			}
151
152			/**
153			* @Route("/no_auto_tags/wander/{id}", name="no_auto_tags", methods={"GET"})
154			*/
155			public function noAutoTags(Wander $wander): Response
156			{
157			return $this->render('admin/problems/no_auto_tags.html.twig', [
158			'wander' => $wander
159			]);
160			}
161
162			/**
163			* @Route("/broken_links", name="broken_links", methods={"GET"})
164			*/
165			public function brokenLinks(ProblemRepository $problemRepository): Response
166			{
167			$problems = $problemRepository->findAll();
168			return $this->render('admin/problems/broken_links.html.twig', [
169			'problems' => $problems
170			]);
171			}
172			}
173

gothick / omm

Push — master ( 80501b...32cadd )

ProblemController::index() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like