ProblemController::index() - Code Metrics - gothick/omm - Measure and Improve Code Quality continuously with Scrutinizer

ProblemController::index() A
last analyzed 2022-11-23 21:14 UTC

↳ Parent: ProblemController

Complexity

Conditions	1
Paths	1

Size

Total Lines	70
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	1	Features	0

Metric	Value
cc	1
eloc	46
c	5
b	1
f	0
nc	1
nop	3
dl	0
loc	70
rs	9.1781

How to fix Long Method

<?php

namespace App\Controller\Admin;

use App\Entity\Wander;
use App\Repository\ImageRepository;
use App\Repository\ProblemRepository;
use App\Repository\WanderRepository;
use App\Service\ProblemService;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * @Route("/admin/problems", name="admin_problems_")
 */
class ProblemController extends AbstractController
{
    /**
     * @Route("/", name="index", methods={"GET"})
     */
    public function index(
        WanderRepository $wanderRepository,
        ImageRepository $imageRepository,
        ProblemRepository $problemRepository
        ): Response
    {
        // Problems that might take time/resources to find, that are
        // popped into a table on specific demand rather than every
        // time we load this page:
        $builtProblems = $problemRepository->findAll();

        // TODO: Might be sensible to do everything here into the problems
        // table, depending on how much we add to this.
        // Other issues, found on the fly:
        $qb = $wanderRepository->createQueryBuilder('w');

        // TODO: This doesn't work, as e.g. keywords being an empty array
        //
        $problems = $qb
            ->join('w.images', 'i')
            ->leftJoin('w.featuredImage', 'fi')
            ->select('w AS wander')
            ->addSelect('COUNT(i) AS image_count')
            ->addSelect('SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END) AS no_title')
            ->addSelect('SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END) AS no_latlng')
            ->addSelect('SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END) AS no_location')
            ->addSelect('SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END) AS no_rating')
            // TODO: This is a hideous bodge and will break when we finally give in and move
            // keywords and auto-tags to being related entities rather than a dirty PHP
            // array, but it's good enough for a problem admin page for now.
            //->addSelect("SUM(CASE WHEN i.keywords IS NULL OR i.keywords = 'a:0:{}' THEN 1 ELSE 0 END) AS no_keywords")
            ->addSelect("SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END) AS no_tags")
            ->addSelect("SUM(CASE WHEN i.autoTags IS NULL OR i.autoTags = 'a:0:{}' THEN 1 ELSE 0 END) AS no_auto_tags")
            ->addSelect("CASE WHEN fi.id IS NULL THEN 1 ELSE 0 END AS no_featured_image")
            ->addSelect(
                "(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
                "(SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) AS total_problems_excl_auto"
            )
            ->addSelect(
                "(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
                "(10 * SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
                "(2 * SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
                "(5 * SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
                "(1 * CASE WHEN fi.id IS NULL THEN 1 ELSE 0 END) + " .
                "(0.01 * SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) + " .
                "(0.001 * SUM(CASE WHEN i.autoTags IS NULL OR i.autoTags = 'a:0:{}' THEN 1 ELSE 0 END)) AS weighted_problem_score"
            )
            ->addGroupBy('w')
            ->addGroupBy('fi')
            ->having('no_title > 0')
            ->orHaving('no_latlng > 0')
            ->orHaving('no_location > 0')
            ->orHaving('no_rating > 0')
            ->orHaving('no_tags > 0')
            ->orHaving('no_auto_tags > 0')
            ->orHaving('no_featured_image > 0')
            ->orderBy('weighted_problem_score', 'desc')
            ->addOrderBy('w.startTime', 'desc')
            ->getQuery()
            ->getResult();

        $orphans = $imageRepository->findWithNoWander();

        return $this->render('admin/problems/index.html.twig', [
            'problems' => $problems,
            'orphans' => $orphans,
            'built_problems' => $builtProblems
        ]);
    }

    /**
     * @Route("/regenerate", name="regenerate", methods={"POST"})
     */
    public function regenerateProblems(Request $request, ProblemService $problemService): Response
    {
        if ($this->isCsrfTokenValid('problems_regenerate', $request->request->get('_token'))) {
            $problemService->createProblemReport();
        }

        return $this->redirectToRoute('admin_problems_index');
    }


    // TODO: These all share a lot of things in common, but I'm not sure
    // how much this is going to get used, so I'm keeping it fairly brain-dead
    // for now. Revisit later.

    /**
     * @Route("/no_title/wander/{id}", name="no_title", methods={"GET"})
     */
    public function noTitle(Wander $wander): Response
    {
        return $this->render('admin/problems/no_title.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_latlng/wander/{id}", name="no_latlng", methods={"GET"})
     */
    public function noLatlng(Wander $wander): Response
    {
        return $this->render('admin/problems/no_latlng.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_location/wander/{id}", name="no_location", methods={"GET"})
     */
    public function noLocation(Wander $wander): Response
    {
        return $this->render('admin/problems/no_location.html.twig', [
            'wander' => $wander
        ]);
    }
    /**
     * @Route("/no_rating/wander/{id}", name="no_rating", methods={"GET"})
     */
    public function noRating(Wander $wander): Response
    {
        return $this->render('admin/problems/no_rating.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/no_tags/wander/{id}", name="no_tags", methods={"GET"})
     */
    public function noTags(Wander $wander): Response
    {
        return $this->render('admin/problems/no_tags.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/no_auto_tags/wander/{id}", name="no_auto_tags", methods={"GET"})
     */
    public function noAutoTags(Wander $wander): Response
    {
        return $this->render('admin/problems/no_auto_tags.html.twig', [
            'wander' => $wander
        ]);
    }

    /**
     * @Route("/broken_links", name="broken_links", methods={"GET"})
     */
    public function brokenLinks(ProblemRepository $problemRepository): Response
    {
        $problems = $problemRepository->findAll();
        return $this->render('admin/problems/broken_links.html.twig', [
            'problems' => $problems
        ]);
    }
}


1			<?php
2
3			namespace App\Controller\Admin;
4
5			use App\Entity\Wander;
6			use App\Repository\ImageRepository;
7			use App\Repository\ProblemRepository;
8			use App\Repository\WanderRepository;
9			use App\Service\ProblemService;
10			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
11			use Symfony\Component\HttpFoundation\Request;
12			use Symfony\Component\HttpFoundation\Response;
13			use Symfony\Component\Routing\Annotation\Route;
14
15			/**
16			* @Route("/admin/problems", name="admin_problems_")
17			*/
18			class ProblemController extends AbstractController
19			{
20			/**
21			* @Route("/", name="index", methods={"GET"})
22			*/
23			public function index(
24			WanderRepository $wanderRepository,
25			ImageRepository $imageRepository,
26			ProblemRepository $problemRepository
27			): Response
28			{
29			// Problems that might take time/resources to find, that are
30			// popped into a table on specific demand rather than every
31			// time we load this page:
32			$builtProblems = $problemRepository->findAll();
33
34			// TODO: Might be sensible to do everything here into the problems
35			// table, depending on how much we add to this.
36			// Other issues, found on the fly:
37			$qb = $wanderRepository->createQueryBuilder('w');
38
39			// TODO: This doesn't work, as e.g. keywords being an empty array
40			//
41			$problems = $qb
42			->join('w.images', 'i')
43			->leftJoin('w.featuredImage', 'fi')
44			->select('w AS wander')
45			->addSelect('COUNT(i) AS image_count')
46			->addSelect('SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END) AS no_title')
47			->addSelect('SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END) AS no_latlng')
48			->addSelect('SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END) AS no_location')
49			->addSelect('SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END) AS no_rating')
50			// TODO: This is a hideous bodge and will break when we finally give in and move
51			// keywords and auto-tags to being related entities rather than a dirty PHP
52			// array, but it's good enough for a problem admin page for now.
53			//->addSelect("SUM(CASE WHEN i.keywords IS NULL OR i.keywords = 'a:0:{}' THEN 1 ELSE 0 END) AS no_keywords")
54			->addSelect("SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END) AS no_tags")
55			->addSelect("SUM(CASE WHEN i.autoTags IS NULL OR i.autoTags = 'a:0:{}' THEN 1 ELSE 0 END) AS no_auto_tags")
56			->addSelect("CASE WHEN fi.id IS NULL THEN 1 ELSE 0 END AS no_featured_image")
57			->addSelect(
58			"(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
59			"(SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
60			"(SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
61			"(SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
62			"(SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) AS total_problems_excl_auto"
63			)
64			->addSelect(
65			"(SUM(CASE WHEN i.title IS NULL THEN 1 ELSE 0 END)) + " .
66			"(10 * SUM(CASE WHEN i.latlng IS NULL THEN 1 ELSE 0 END)) + " .
67			"(2 * SUM(CASE WHEN i.location IS NULL THEN 1 ELSE 0 END)) + " .
68			"(5 * SUM(CASE WHEN i.rating IS NULL OR i.rating = 0 THEN 1 ELSE 0 END)) + " .
69			"(1 * CASE WHEN fi.id IS NULL THEN 1 ELSE 0 END) + " .
70			"(0.01 * SUM(CASE WHEN i.tags is empty THEN 1 ELSE 0 END)) + " .
71			"(0.001 * SUM(CASE WHEN i.autoTags IS NULL OR i.autoTags = 'a:0:{}' THEN 1 ELSE 0 END)) AS weighted_problem_score"
72			)
73			->addGroupBy('w')
74			->addGroupBy('fi')
75			->having('no_title > 0')
76			->orHaving('no_latlng > 0')
77			->orHaving('no_location > 0')
78			->orHaving('no_rating > 0')
79			->orHaving('no_tags > 0')
80			->orHaving('no_auto_tags > 0')
81			->orHaving('no_featured_image > 0')
82			->orderBy('weighted_problem_score', 'desc')
83			->addOrderBy('w.startTime', 'desc')
84			->getQuery()
85			->getResult();
86
87			$orphans = $imageRepository->findWithNoWander();
88
89			return $this->render('admin/problems/index.html.twig', [
90			'problems' => $problems,
91			'orphans' => $orphans,
92			'built_problems' => $builtProblems
93			]);
94			}
95
96			/**
97			* @Route("/regenerate", name="regenerate", methods={"POST"})
98			*/
99			public function regenerateProblems(Request $request, ProblemService $problemService): Response
100			{
101			if ($this->isCsrfTokenValid('problems_regenerate', $request->request->get('_token'))) {
102			$problemService->createProblemReport();
103			}
104
105			return $this->redirectToRoute('admin_problems_index');
106			}
107
108
109			// TODO: These all share a lot of things in common, but I'm not sure
110			// how much this is going to get used, so I'm keeping it fairly brain-dead
111			// for now. Revisit later.
112
113			/**
114			* @Route("/no_title/wander/{id}", name="no_title", methods={"GET"})
115			*/
116			public function noTitle(Wander $wander): Response
117			{
118			return $this->render('admin/problems/no_title.html.twig', [
119			'wander' => $wander
120			]);
121			}
122			/**
123			* @Route("/no_latlng/wander/{id}", name="no_latlng", methods={"GET"})
124			*/
125			public function noLatlng(Wander $wander): Response
126			{
127			return $this->render('admin/problems/no_latlng.html.twig', [
128			'wander' => $wander
129			]);
130			}
131			/**
132			* @Route("/no_location/wander/{id}", name="no_location", methods={"GET"})
133			*/
134			public function noLocation(Wander $wander): Response
135			{
136			return $this->render('admin/problems/no_location.html.twig', [
137			'wander' => $wander
138			]);
139			}
140			/**
141			* @Route("/no_rating/wander/{id}", name="no_rating", methods={"GET"})
142			*/
143			public function noRating(Wander $wander): Response
144			{
145			return $this->render('admin/problems/no_rating.html.twig', [
146			'wander' => $wander
147			]);
148			}
149
150			/**
151			* @Route("/no_tags/wander/{id}", name="no_tags", methods={"GET"})
152			*/
153			public function noTags(Wander $wander): Response
154			{
155			return $this->render('admin/problems/no_tags.html.twig', [
156			'wander' => $wander
157			]);
158			}
159
160			/**
161			* @Route("/no_auto_tags/wander/{id}", name="no_auto_tags", methods={"GET"})
162			*/
163			public function noAutoTags(Wander $wander): Response
164			{
165			return $this->render('admin/problems/no_auto_tags.html.twig', [
166			'wander' => $wander
167			]);
168			}
169
170			/**
171			* @Route("/broken_links", name="broken_links", methods={"GET"})
172			*/
173			public function brokenLinks(ProblemRepository $problemRepository): Response
174			{
175			$problems = $problemRepository->findAll();
176			return $this->render('admin/problems/broken_links.html.twig', [
177			'problems' => $problems
178			]);
179			}
180			}
181

gothick / omm

ProblemController::index() A last analyzed 2022-11-23 21:14 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ProblemController::index() A
last analyzed 2022-11-23 21:14 UTC