App\Command\ImagesUpdatelocationsCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	configure()	0	3	1
A	execute()	0	30	3

<?php

namespace App\Command;

use App\Repository\ImageRepository;
use App\Service\LocationService;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;

class ImagesUpdatelocationsCommand extends Command
{
    protected static $defaultName = 'images:updatelocations';
    protected static $defaultDescription = "Updates images whose locations aren't set using our location service.";

    /** @var ImageRepository */
    private $imageRepository;

    /** @var LocationService */
    private $locationService;

    /** @var EntityManagerInterface */
    private $entityManager;

    public function __construct(
        ImageRepository $imageRepository,
        LocationService $locationService,
        EntityManagerInterface $entityManager
    )
    {
        $this->imageRepository = $imageRepository;
        $this->locationService = $locationService;
        $this->entityManager = $entityManager;

        parent::__construct();
    }

    protected function configure(): void
    {
        $this->setDescription(self::$defaultDescription);
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $io = new SymfonyStyle($input, $output);

        $io->info("Attempting to add locations to images missing locations.");

        $images = $this->imageRepository->findWithNoLocationButHasLatLng();
        $total = count($images);

It seems like $images can also be of type integer; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

        $success = 0;
        $failure = 0;

        $progressBar = new ProgressBar($output, $total);
        $progressBar->start();
        foreach ($images as $image) {
            $neighbourhood = $this->locationService->getLocationName($image->getLatitude(), $image->getLongitude());
            if ($neighbourhood !== null) {
                $image->setLocation($neighbourhood);
                $this->entityManager->persist($image);
                $this->entityManager->flush(); // It actually seems faster to flush in the loop, rather than afterwards. Odd.
                $success++;
            } else {
                $failure++;
            }
            $progressBar->advance();
        }
        $progressBar->finish();

        $io->success("Tried to locate $total images. Success: $success. Failure: $failure.");

        return Command::SUCCESS;
    }
}