Issues in RefPart.php - All Issues - Inspection of "More tests" - gossi/swagger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8619b3...819e89 )

by Thomas

created 2015-12-09 16:16 UTC

src/parts/RefPart.php (3 issues)

Labels

Coding Style 2
Documentation 1

Severity

Minor 1
Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace gossi\swagger\parts;

use phootwork\collection\Map;

trait RefPart {
	
	/** @var string */
	private $ref;
	
	/** @var boolean */
	private $hasRef = false;
	
	private function parseRef(Map $data) {
		$this->ref = $data->get('$ref');
$a = "a";
$ab = "ab";
$abc = "abc";
		$this->hasRef = $data->has('$ref');
	}
	
	/**
	 *
	 * @return the string
	 */
	public function getRef() {
		return $this->ref;
	}
	
	/**
	 *
	 * @param
	 *        	$ref
	 */
	public function setRef($ref) {
		$this->ref = $ref;
$a = "a";
$ab = "ab";
$abc = "abc";
		$this->hasRef = $ref !== null;
		return $this;
	}
	
	public function hasRef() {

		return $this->hasRef;
	}
	

}

1		<?php
2		namespace gossi\swagger\parts;
3
4		use phootwork\collection\Map;
5
6		trait RefPart {
7
8		/** @var string */
9		private $ref;
10
11		/** @var boolean */
12		private $hasRef = false;
13
14	11	private function parseRef(Map $data) {
15	11	$this->ref = $data->get('$ref');
		0 ignored issues – show Coding Style introduced 2015-12-09 00:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
16	11	$this->hasRef = $data->has('$ref');
17	11	}
18
19		/**
20		*
21		* @return the string
22		*/
23	1	public function getRef() {
24	1	return $this->ref;
25		}
26
27		/**
28		*
29		* @param
30		* $ref
31		*/
32	1	public function setRef($ref) {
33	1	$this->ref = $ref;
		0 ignored issues – show Coding Style introduced 2015-12-09 00:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	1	$this->hasRef = $ref !== null;
35	1	return $this;
36		}
37
38	11	public function hasRef() {
		0 ignored issues – show Documentation introduced 2015-12-09 00:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
39	11	return $this->hasRef;
40		}
41
42
43		}

gossi / swagger

Push — master ( 8619b3...819e89 )

src/parts/RefPart.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like