MergeHelper - Code Metrics - Inspection of "Allow to merge models" - gossi/swagger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Guilh

created 2016-07-20 13:45 UTC

MergeHelper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
c	1
b	0
f	0
lcom	0
cbo	2
dl	0
loc	26
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	mergeFields()	0	19	10

<?php
namespace gossi\swagger\util;

use phootwork\collection\Map;
use phootwork\collection\Set;

/**
 * @internal
 */
class MergeHelper {
    /**
     * @param string|integer|null|Map|Set $original
     * @param string|integer|null|Map|Set $external
     * @param bool                $overwrite
     */
    public static function mergeFields(&$original, $external, $overwrite) {
        if ($original instanceof Map) {
            foreach ($external as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                if ($overwrite || !$original->has($key)) {
                    $original->set($key, $value);
                }
            }
        } elseif ($original instanceof Set) {
            foreach ($external as $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $original->add($value);
            }
        } else { // if scalar
            if ($overwrite) {
                $original = null !== $external ? $external : $original;
            } else {
                $original = null === $original ? $external : $original;
            }
        }
    }
}


1			<?php
2			namespace gossi\swagger\util;
3
4			use phootwork\collection\Map;
5			use phootwork\collection\Set;
6
7			/**
8			* @internal
9			*/
10			class MergeHelper {
11			/**
12			* @param string\|integer\|null\|Map\|Set $original
13			* @param string\|integer\|null\|Map\|Set $external
14			* @param bool $overwrite
15			*/
16			public static function mergeFields(&$original, $external, $overwrite) {
17			if ($original instanceof Map) {
18			foreach ($external as $key => $value) {
			0 ignored issues – show Bug introduced 2016-07-20 13:49 UTC by Report Bug Copy Issue Report The expression `$external` of type `string\|integer\|null\|obje...ootwork\collection\Set>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
19			if ($overwrite \|\| !$original->has($key)) {
20			$original->set($key, $value);
21			}
22			}
23			} elseif ($original instanceof Set) {
24			foreach ($external as $value) {
			0 ignored issues – show Bug introduced 2016-07-20 13:49 UTC by Report Bug Copy Issue Report The expression `$external` of type `string\|integer\|null\|obje...ootwork\collection\Set>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
25			$original->add($value);
26			}
27			} else { // if scalar
28			if ($overwrite) {
29			$original = null !== $external ? $external : $original;
30			} else {
31			$original = null === $original ? $external : $original;
32			}
33			}
34			}
35			}
36

gossi / swagger

Pull Request — master (#6)

MergeHelper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like