MemberParserPart::getVisibility() - Code Metrics - Inspection of "road to v0.4" - gossi/php-code-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 55b21a...aec22b )

by Thomas

created 2016-11-15 12:20 UTC

MemberParserPart::getVisibility() A

↳ Parent: MemberParserPart

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.4285
cc	3
eloc	6
nc	3
nop	1
crap	3

<?php
namespace gossi\codegen\parser\visitor\parts;

use PhpParser\Comment\Doc;
use gossi\codegen\model\AbstractPhpMember;
use PhpParser\Node;

trait MemberParserPart {
	
	private function parseMemberDocblock($member, Doc $doc = null) {
		if ($doc !== null) {
			$member->setDocblock($doc->getReformattedText());
			$docblock = $member->getDocblock();
			$member->setDescription($docblock->getShortDescription());
			$member->setLongDescription($docblock->getLongDescription());
	
			$vars = $docblock->getTags('var');
			if ($vars->size() > 0) {
				$var = $vars->get(0);
				$member->setType($var->getType(), $var->getDescription());
			}
		}
	}
	
	/**
	 * Returns the visibility from a node
	 *
	 * @param Node $node
	 * @return string
	 */
	private function getVisibility(Node $node) {
		if ($node->isPrivate()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			return AbstractPhpMember::VISIBILITY_PRIVATE;
		}
	
		if ($node->isProtected()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			return AbstractPhpMember::VISIBILITY_PROTECTED;
		}
	
		return AbstractPhpMember::VISIBILITY_PUBLIC;
	}
}

Push — master ( 55b21a...aec22b )

MemberParserPart::getVisibility() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2		namespace gossi\codegen\parser\visitor\parts;
3
4		use PhpParser\Comment\Doc;
5		use gossi\codegen\model\AbstractPhpMember;
6		use PhpParser\Node;
7
8		trait MemberParserPart {
9
10	9	private function parseMemberDocblock($member, Doc $doc = null) {
11	9	if ($doc !== null) {
12	3	$member->setDocblock($doc->getReformattedText());
13	3	$docblock = $member->getDocblock();
14	3	$member->setDescription($docblock->getShortDescription());
15	3	$member->setLongDescription($docblock->getLongDescription());
16
17	3	$vars = $docblock->getTags('var');
18	3	if ($vars->size() > 0) {
19	3	$var = $vars->get(0);
20	3	$member->setType($var->getType(), $var->getDescription());
21		}
22		}
23	9	}
24
25		/**
26		* Returns the visibility from a node
27		*
28		* @param Node $node
29		* @return string
30		*/
31	12	private function getVisibility(Node $node) {
32	12	if ($node->isPrivate()) {
		1 ignored issue – show Bug introduced 2016-11-15 12:27 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `PhpParser\Node` as the method `isPrivate()` does only exist in the following implementations of said interface: `PhpParser\Node\Stmt\ClassMethod`, `PhpParser\Node\Stmt\Property`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33	8	return AbstractPhpMember::VISIBILITY_PRIVATE;
34		}
35
36	12	if ($node->isProtected()) {
		1 ignored issue – show Bug introduced 2016-11-15 12:27 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `PhpParser\Node` as the method `isProtected()` does only exist in the following implementations of said interface: `PhpParser\Node\Stmt\ClassMethod`, `PhpParser\Node\Stmt\Property`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37	2	return AbstractPhpMember::VISIBILITY_PROTECTED;
38		}
39
40	12	return AbstractPhpMember::VISIBILITY_PUBLIC;
41		}
42		}

gossi / php-code-generator

Push — master ( 55b21a...aec22b )

MemberParserPart::getVisibility() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like