ValueParserPart::getExpression() - Code Metrics - Inspection of "fix code issues, some more phpdoc" - gossi/php-code-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d075bd...c77af7 )

by Thomas

created 2016-11-16 12:00 UTC

ValueParserPart::getExpression() B

↳ Parent: ValueParserPart

Complexity

Conditions	6
Paths	6

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	6.105

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	23
ccs	12
cts	14
cp	0.8571
rs	8.5906
cc	6
eloc	13
nc	6
nop	1
crap	6.105

<?php
namespace gossi\codegen\parser\visitor\parts;

use gossi\codegen\model\ValueInterface;
use gossi\codegen\parser\PrettyPrinter;
use PhpParser\Node;
use PhpParser\Node\Const_;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Scalar\DNumber;
use PhpParser\Node\Scalar\LNumber;
use PhpParser\Node\Scalar\MagicConst;
use PhpParser\Node\Scalar\String_;

trait ValueParserPart {
	
	private $constMap = [
		'false' => false,
		'true' => true
	];
	
	/**
	 * Parses the value of a node into the model
	 * 
	 * @param ValueInterface $obj
	 * @param Node $node
	 * @return void
	 */
	private function parseValue(ValueInterface $obj, Node $node) {
		$value = $node instanceof Const_ ? $node->value : $node->default;
		if ($value !== null) {
			if ($this->isPrimitive($value)) {
				$obj->setValue($this->getPrimitiveValue($value));
			} else {
				$obj->setExpression($this->getExpression($value));
			}
		}
	}
	
	/**
	 * Returns whether this node is a primitive value
	 * 
	 * @param Node $node
	 * @return boolean
	 */
	private function isPrimitive(Node $node) {
		return $node instanceof String_
			|| $node instanceof LNumber
			|| $node instanceof DNumber
			|| $this->isBool($node)
			|| $this->isNull($node);
	}
	
	/**
	 * Returns the primitive value
	 * 
	 * @param Node $node
	 * @return mixed
	 */
	private function getPrimitiveValue(Node $node) {
		if ($this->isBool($node)) {
			return (bool) $this->getExpression($node);
		}
	
		if ($this->isNull($node)) {
			return null;
		}
	
		return $node->value;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
	}
	
	/**
	 * Returns whether this node is a boolean value
	 * 
	 * @param Node $node
	 * @return boolean
	 */
	private function isBool(Node $node) {
		if ($node instanceof ConstFetch) {
			$const = $node->name->parts[0];
			if (isset($this->constMap[$const])) {
				return is_bool($this->constMap[$const]);
			}
	
			return is_bool($const);
		}
	}
	
	/**
	 * Returns whether this node is a null value
	 * 
	 * @param Node $node
	 * @return boolean
	 */
	private function isNull(Node $node) {
		if ($node instanceof ConstFetch) {
			$const = $node->name->parts[0];
			return $const === 'null';
		}
	}
	
	/**
	 * Returns the value from a node
	 *
	 * @param Node $node
	 * @return mixed
	 */
	private function getExpression(Node $node) {
		if ($node instanceof ConstFetch) {
			$const = $node->name->parts[0];
			if (isset($this->constMap[$const])) {
				return $this->constMap[$const];
			}
	
			return $const;
		}
		
		if ($node instanceof ClassConstFetch) {
			return $node->class->parts[0] . '::' . $node->name;
		}
	
		if ($node instanceof MagicConst) {
			return $node->getName();
		}
		
		if ($node instanceof Array_) {
			$prettyPrinter = new PrettyPrinter();
			return $prettyPrinter->prettyPrintExpr($node);
		}
	}
}

1		<?php
2		namespace gossi\codegen\parser\visitor\parts;
3
4		use gossi\codegen\model\ValueInterface;
5		use gossi\codegen\parser\PrettyPrinter;
6		use PhpParser\Node;
7		use PhpParser\Node\Const_;
8		use PhpParser\Node\Expr\Array_;
9		use PhpParser\Node\Expr\ClassConstFetch;
10		use PhpParser\Node\Expr\ConstFetch;
11		use PhpParser\Node\Scalar\DNumber;
12		use PhpParser\Node\Scalar\LNumber;
13		use PhpParser\Node\Scalar\MagicConst;
14		use PhpParser\Node\Scalar\String_;
15
16		trait ValueParserPart {
17
18		private $constMap = [
19		'false' => false,
20		'true' => true
21		];
22
23		/**
24		* Parses the value of a node into the model
25		*
26		* @param ValueInterface $obj
27		* @param Node $node
28		* @return void
29		*/
30	10	private function parseValue(ValueInterface $obj, Node $node) {
31	10	$value = $node instanceof Const_ ? $node->value : $node->default;
32	10	if ($value !== null) {
33	7	if ($this->isPrimitive($value)) {
34	7	$obj->setValue($this->getPrimitiveValue($value));
35	7	} else {
36	4	$obj->setExpression($this->getExpression($value));
37		}
38	7	}
39	10	}
40
41		/**
42		* Returns whether this node is a primitive value
43		*
44		* @param Node $node
45		* @return boolean
46		*/
47	7	private function isPrimitive(Node $node) {
48		return $node instanceof String_
49	7	\|\| $node instanceof LNumber
50	6	\|\| $node instanceof DNumber
51	6	\|\| $this->isBool($node)
52	7	\|\| $this->isNull($node);
53		}
54
55		/**
56		* Returns the primitive value
57		*
58		* @param Node $node
59		* @return mixed
60		*/
61	7	private function getPrimitiveValue(Node $node) {
62	7	if ($this->isBool($node)) {
63	5	return (bool) $this->getExpression($node);
64		}
65
66	7	if ($this->isNull($node)) {
67	3	return null;
68		}
69
70	7	return $node->value;
		1 ignored issue – show Bug introduced 2016-11-15 12:27 UTC by Report Bug Copy Issue Report Accessing `value` on the interface `PhpParser\Node` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
71		}
72
73		/**
74		* Returns whether this node is a boolean value
75		*
76		* @param Node $node
77		* @return boolean
78		*/
79	7	private function isBool(Node $node) {
80	7	if ($node instanceof ConstFetch) {
81	5	$const = $node->name->parts[0];
82	5	if (isset($this->constMap[$const])) {
83	5	return is_bool($this->constMap[$const]);
84		}
85
86	3	return is_bool($const);
87		}
88	7	}
89
90		/**
91		* Returns whether this node is a null value
92		*
93		* @param Node $node
94		* @return boolean
95		*/
96	7	private function isNull(Node $node) {
97	7	if ($node instanceof ConstFetch) {
98	3	$const = $node->name->parts[0];
99	3	return $const === 'null';
100		}
101	7	}
102
103		/**
104		* Returns the value from a node
105		*
106		* @param Node $node
107		* @return mixed
108		*/
109	6	private function getExpression(Node $node) {
110	6	if ($node instanceof ConstFetch) {
111	5	$const = $node->name->parts[0];
112	5	if (isset($this->constMap[$const])) {
113	5	return $this->constMap[$const];
114		}
115
116		return $const;
117		}
118
119	4	if ($node instanceof ClassConstFetch) {
120	3	return $node->class->parts[0] . '::' . $node->name;
121		}
122
123	3	if ($node instanceof MagicConst) {
124	1	return $node->getName();
125		}
126
127	3	if ($node instanceof Array_) {
128	3	$prettyPrinter = new PrettyPrinter();
129	3	return $prettyPrinter->prettyPrintExpr($node);
130		}
131		}
132		}

gossi / php-code-generator

Push — master ( d075bd...c77af7 )

ValueParserPart::getExpression() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like