Gorghoa\ScenarioStateBehatExtension\ScenarioStateHookDispatcher

Complexity

Total Complexity

9

Size/Duplication

Total Lines	96
Duplicated Lines	9.38 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
C	dispatchScopeHooks()	9	37	7
A	dispatchHook()	0	4	1

<?php

/*
 * This file is part of the ScenarioStateBehatExtension project.
 *
 * (c) Rodrigue Villetard <rodrigue.villetard@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gorghoa\ScenarioStateBehatExtension;

use Behat\Testwork\Call\CallCenter;
use Behat\Testwork\Call\CallResult;
use Behat\Testwork\Call\CallResults;
use Behat\Testwork\Hook\Call\HookCall;
use Behat\Testwork\Hook\Hook;
use Behat\Testwork\Hook\HookRepository;
use Behat\Testwork\Hook\Scope\HookScope;
use Doctrine\Common\Annotations\Reader;
use Gorghoa\ScenarioStateBehatExtension\Annotation\ScenarioStateArgument;
use Gorghoa\ScenarioStateBehatExtension\Context\Initializer\ScenarioStateInitializer;

/**
 * @author Vincent Chalamon <vincent@les-tilleuls.coop>
 */
final class ScenarioStateHookDispatcher
{
    /**
     * @var HookRepository
     */
    private $repository;

    /**
     * @var CallCenter
     */
    private $callCenter;

    /**
     * @var Reader
     */
    private $reader;

    /**
     * @var ScenarioStateInitializer
     */
    private $store;

    /**
     * Initializes scenario state hook dispatcher.
     *
     * @param HookRepository           $repository
     * @param CallCenter               $callCenter
     * @param ScenarioStateInitializer $store
     * @param Reader                   $reader
     */
    public function __construct(HookRepository $repository, CallCenter $callCenter, ScenarioStateInitializer $store, Reader $reader)
    {
        $this->repository = $repository;
        $this->callCenter = $callCenter;
        $this->reader = $reader;
        $this->store = $store;
    }

    /**
     * Dispatches hooks for a specified event.
     *
     * @param HookScope $scope
     *
     * @return CallResults
     */
    public function dispatchScopeHooks(HookScope $scope)
    {
        $results = array();
        foreach ($this->repository->getScopeHooks($scope) as $hook) {
            $function = $hook->getReflection();

            // No `@ScenarioStateArgument` annotation found
            if (null === $this->reader->getMethodAnnotation($function, ScenarioStateArgument::class)) {

$function of type object<ReflectionFunctionAbstract> is not a sub-type of object<ReflectionMethod>. It seems like you assume a child class of the class ReflectionFunctionAbstract to be always present.

                $results[] = $this->callCenter->makeCall(new HookCall($scope, $hook));
                continue;
            }

//            $match = [];

57% of this comment could be valid code. Did you maybe forget this after debugging?

//            $i = array_slice(array_keys($match), -1, 1)[0];
            $paramsKeys = array_map(function($element) {
                return $element->name;
            }, $function->getParameters());
            var_dump($function->getParameters());

var_dump($function->getParameters()); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

            $store = $this->store->getStore();

            /** @var ScenarioStateArgument[] $annotations */
            $annotations = $this->reader->getMethodAnnotations($function);

$function of type object<ReflectionFunctionAbstract> is not a sub-type of object<ReflectionMethod>. It seems like you assume a child class of the class ReflectionFunctionAbstract to be always present.

            foreach ($annotations as $annotation) {

This code seems to be duplicated across your project.

                if ($annotation instanceof ScenarioStateArgument &&
                    in_array($annotation->getArgument(), $paramsKeys) &&
                    $store->hasStateFragment($annotation->getName())
                ) {
                    $match[$annotation->getArgument()] = $store->getStateFragment($annotation->getName());

$match was never initialized. Although not strictly required by PHP, it is generally a good practice to add $match = array(); before regardless.

                    $match[strval(++$i)] = $store->getStateFragment($annotation->getName());

The variable $match does not seem to be defined for all execution paths leading up to this point.

The variable $i does not seem to be defined for all execution paths leading up to this point.

                }
            }

            $results[] = $this->callCenter->makeCall(new ScenarioStateCall($scope, $hook, ['foo', 'bar']));
        }

        return new CallResults($results);
    }

    /**
     * Dispatches single event hook.
     *
     * @param HookScope $scope
     * @param Hook      $hook
     *
     * @return CallResult
     */
    private function dispatchHook(HookScope $scope, Hook $hook)

This method is not used, and could be removed.

    {
        return $this->callCenter->makeCall(new HookCall($scope, $hook));
    }
}