Gorghoa\StepArgumentInjectorBehatExtension\Resolver\ArgumentsResolver

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	15.15 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

95.45%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
D	resolve()	10	35	9

<?php

/*
 * This file is part of the StepArgumentInjectorBehatExtension project.
 *
 * (c) Rodrigue Villetard <rodrigue.villetard@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gorghoa\StepArgumentInjectorBehatExtension\Resolver;

use Doctrine\Common\Annotations\Reader;
use Gorghoa\StepArgumentInjectorBehatExtension\Annotation\StepInjectorArgument;

/**
 * @author Vincent Chalamon <vincent@les-tilleuls.coop>
 */
class ArgumentsResolver
{
    /**
     * @var Reader
     */
    private $reader;

    /**
     * @var StepArgumentHolder[]
     */
    private $stepArgumentHolders;

    /**
     * ArgumentsResolver constructor.
     *
     * @param StepArgumentHolder[] $stepArgumentHolders
     * @param Reader               $reader
     */
    public function __construct($stepArgumentHolders, Reader $reader)
    {
        $this->stepArgumentHolders = $stepArgumentHolders;
        $this->reader = $reader;
    }

    /**
     * @param \ReflectionMethod $function
     * @param array             $arguments
     *
     * @return array
     */
    public function resolve(\ReflectionMethod $function, array $arguments)
    {
        // No `@StepInjectorArgument` annotation found
        if (null === $this->reader->getMethodAnnotation($function, StepInjectorArgument::class)) {
            return $arguments;
        }

        $paramsKeys = array_map(function (\ReflectionParameter $element) {
            return $element->getName();
        }, $function->getParameters());

        // Prepare arguments from annotations
        $annotations = $this->reader->getMethodAnnotations($function);
        foreach ($annotations as $annotation) {
            if ($annotation instanceof StepInjectorArgument &&

This code seems to be duplicated across your project.

                in_array($argument = $annotation->getArgument(), $paramsKeys)
            ) {
                /* @var StepArgumentInjectorArgument $annotation */
                foreach ($this->stepArgumentHolders as $hooker) {
                    if ($hooker->doesHandleStepArgument($annotation)) {
                        $arguments[$argument] = $hooker->getStepArgumentValueFor($annotation);
                    }
                }
            }
        }

        // Reorder arguments
        $params = [];
        foreach ($function->getParameters() as $parameter) {
            $name = $parameter->getName();

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

            $params[$name] = isset($arguments[$name]) ? $arguments[$name] : $arguments[$parameter->getPosition()];
        }

        return $params;
    }
}