Gorghoa\StepArgumentInjectorBehatExtension\Argument\ArgumentOrganiserTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	14	1
B	testOrganiseArguments()	0	44	1

<?php

/*
 * This file is part of the StepArgumentInjectorBehatExtension project.
 *
 * (c) Rodrigue Villetard <rodrigue.villetard@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gorghoa\StepArgumentInjectorBehatExtension\Argument;

use Doctrine\Common\Annotations\Reader;
use Gorghoa\StepArgumentInjectorBehatExtension\Annotation\StepArgumentInjectorArgument;
use Gorghoa\StepArgumentInjectorBehatExtension\Annotation\StepInjectorArgument;
use Prophecy\Prophecy\ObjectProphecy;
use Behat\Testwork\Argument\ArgumentOrganiser as BehatArgumentOrganiser;

/**
 * @author Vincent Chalamon <vincentchalamon@gmail.com>
 * @author Rodrigue Villetard <rodrigue.villetard@gmail.com>
 */
class ArgumentOrganiserTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ArgumentOrganiser
     */
    private $organiser;

    /**
     * @var ObjectProphecy|ArgumentOrganiser
     */
    private $organiserMock;

    /**
     * @var ObjectProphecy
     */
    private $initializerMock;

The property $initializerMock is not used and could be removed.

    /**
     * @var ObjectProphecy|\ReflectionMethod
     */
    private $functionMock;

    /**
     * @var ObjectProphecy|Reader
     */
    private $readerMock;

    /**
     * @var StepArgumentHolder
     */
    private $holderMock;

    /**
     * @var ObjectProphecy|StepArgumentInjectorArgument
     */
    private $annotationMock;

    protected function setUp()
    {
        $this->organiserMock = $this->prophesize(BehatArgumentOrganiser::class);
        $this->functionMock = $this->prophesize(\ReflectionMethod::class);
        $this->readerMock = $this->prophesize(Reader::class);
        $this->annotationMock = function () { return $this->prophesize(StepInjectorArgument::class); };

It seems like function () { return $this->prophesize(\Gorghoa\StepArgumentInjectorBehatExtension\Annotation\StepInjectorArgument::class); } of type object<Closure> is incompatible with the declared type object<Prophecy\Prophecy\ObjectProphecy>|object<Gorghoa\StepArgumentInjectorBehatExtension\Annotation\StepArgumentInjectorArgument> of property $annotationMock.

        $this->holderMock = $this->prophesize(StepArgumentHolder::class);

It seems like $this->prophesize(\Gorghoa\StepArgumentInjectorBehatExtension\Argument\StepArgumentHolder::class) of type object<Prophecy\Prophecy\ObjectProphecy> is incompatible with the declared type object<Gorghoa\StepArgumentInjectorBehatExtension\Argument\StepArgumentHolder> of property $holderMock.

        $this->organiser = new ArgumentOrganiser(
            $this->organiserMock->reveal(),
            [$this->holderMock->reveal()],
            $this->readerMock->reveal()
        );
    }

    public function testOrganiseArguments()
    {
        $this->functionMock->getParameters()->willReturn([
            (object) ['name' => 'scenarioBanana'], // argument with injector annotation and **a service hold** value
            (object) ['name' => 'gorilla'], // argument with injector annotation but **no service hold** value
            (object) ['name' => 'foo'], // argument not handled by this extension
        ])->shouldBeCalledTimes(1);

        /*

66% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->annotationMock->getArgument()
            ->willReturn('scenarioBanana', 'gorilla')
            ->shouldBeCalled();
        */

        $annot1 = ($this->annotationMock)();
        $annot1->getArgument()->willReturn('scenarioBanana')->shouldBeCalledTimes(1);
        $annot1->reveal();

        $annot2 = ($this->annotationMock)();
        $annot2->getArgument()->willReturn('gorilla')->shouldBeCalledTimes(1);
        $annot2->reveal();

        $this->readerMock->getMethodAnnotations($this->functionMock->reveal())->willReturn([
            $annot1,
            $annot2,
        ])->shouldBeCalledTimes(1);

        $this->holderMock->doesHandleStepArgument($annot1)->willReturn(true);

The method willReturn cannot be called on $this->holderMock->doesHandleStepArgument($annot1) (of type boolean).

        $this->holderMock->doesHandleStepArgument($annot2)->willReturn(false);

The method willReturn cannot be called on $this->holderMock->doesHandleStepArgument($annot2) (of type boolean).

        $this->holderMock->getStepArgumentValueFor($annot1)->willReturn('yammyBanana')->shouldBeCalledTimes(1);
        $this->holderMock->getStepArgumentValueFor($annot2)->shouldNotBeCalled();

        $this->holderMock->getStepArgumentValueFor($annot2);

        $this->organiserMock->organiseArguments($this->functionMock->reveal(), [

The method organiseArguments does only exist in Gorghoa\StepArgumentInjectorBehatExtension\Argument\ArgumentOrganiser, but not in Prophecy\Prophecy\ObjectProphecy.

            0 => 'scenarioBanana',
            1 => 'gorilla',
            'scenarioBanana' => 'yammyBanana',
            2 => 'yammyBanana',
        ])->shouldBeCalledTimes(1);

        $this->organiser->organiseArguments($this->functionMock->reveal(), ['scenarioBanana', 'gorilla']);
    }
}