ScenarioStateHookableScenarioTester::test() - Code Metrics - Inspection of "[WIP] Inject store arguments in Behat hooks non st..." - gorghoa/ScenarioStateBehatExtension - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#24)

by Vincent

created 2017-04-24 14:45 UTC

ScenarioStateHookableScenarioTester::test() A

↳ Parent: ScenarioStateHookableScenarioTester

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	4

<?php

/*
 * This file is part of the ScenarioStateBehatExtension project.
 *
 * (c) Rodrigue Villetard <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gorghoa\ScenarioStateBehatExtension\Hook\Tester;

use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use Behat\Behat\Hook\Tester\HookableScenarioTester;
use Behat\Behat\Tester\ScenarioTester;
use Behat\Gherkin\Node\FeatureNode;
use Behat\Gherkin\Node\ScenarioInterface as Scenario;
use Behat\Testwork\Environment\Environment;
use Behat\Testwork\Hook\Tester\Setup\HookedSetup;
use Behat\Testwork\Tester\Result\TestResult;
use Gorghoa\ScenarioStateBehatExtension\Hook\Dispatcher\ScenarioStateHookDispatcher;

/**
 * @author Vincent Chalamon <[email protected]>
 */
final class ScenarioStateHookableScenarioTester implements ScenarioTester
{
    /**
     * @var HookableScenarioTester
     */
    private $decoratedService;

    /**
     * @var ScenarioTester
     */
    private $baseTester;

    /**
     * @var ScenarioStateHookDispatcher
     */
    private $dispatcher;

    /**
     * @param HookableScenarioTester      $decoratedService
     * @param ScenarioTester              $baseTester
     * @param ScenarioStateHookDispatcher $dispatcher
     */
    public function __construct(HookableScenarioTester $decoratedService, ScenarioTester $baseTester, ScenarioStateHookDispatcher $dispatcher)
    {
        $this->decoratedService = $decoratedService;
        $this->baseTester = $baseTester;
        $this->dispatcher = $dispatcher;
    }

    /**
     * {@inheritdoc}
     */
    public function setUp(Environment $env, FeatureNode $feature, Scenario $scenario, $skip)
    {
        $setup = $this->decoratedService->setUp($env, $feature, $scenario, true);

        if ($skip) {
            return $setup;
        }

        $scope = new BeforeScenarioScope($env, $feature, $scenario);
        $hookCallResults = $this->dispatcher->dispatchScopeHooks($scope);

        return new HookedSetup($setup, $hookCallResults);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function test(Environment $env, FeatureNode $feature, Scenario $scenario, $skip)
    {
        return $this->decoratedService->test($env, $feature, $scenario, $skip);
    }

    /**
     * {@inheritdoc}
     */
    public function tearDown(Environment $env, FeatureNode $feature, Scenario $scenario, $skip, TestResult $result)
    {
        return $this->decoratedService->tearDown($env, $feature, $scenario, $skip, $result);
    }
}


1			<?php
2
3			/*
4			* This file is part of the ScenarioStateBehatExtension project.
5			*
6			* (c) Rodrigue Villetard <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Gorghoa\ScenarioStateBehatExtension\Hook\Tester;
13
14			use Behat\Behat\Hook\Scope\BeforeScenarioScope;
15			use Behat\Behat\Hook\Tester\HookableScenarioTester;
16			use Behat\Behat\Tester\ScenarioTester;
17			use Behat\Gherkin\Node\FeatureNode;
18			use Behat\Gherkin\Node\ScenarioInterface as Scenario;
19			use Behat\Testwork\Environment\Environment;
20			use Behat\Testwork\Hook\Tester\Setup\HookedSetup;
21			use Behat\Testwork\Tester\Result\TestResult;
22			use Gorghoa\ScenarioStateBehatExtension\Hook\Dispatcher\ScenarioStateHookDispatcher;
23
24			/**
25			* @author Vincent Chalamon <[email protected]>
26			*/
27			final class ScenarioStateHookableScenarioTester implements ScenarioTester
28			{
29			/**
30			* @var HookableScenarioTester
31			*/
32			private $decoratedService;
33
34			/**
35			* @var ScenarioTester
36			*/
37			private $baseTester;
38
39			/**
40			* @var ScenarioStateHookDispatcher
41			*/
42			private $dispatcher;
43
44			/**
45			* @param HookableScenarioTester $decoratedService
46			* @param ScenarioTester $baseTester
47			* @param ScenarioStateHookDispatcher $dispatcher
48			*/
49			public function __construct(HookableScenarioTester $decoratedService, ScenarioTester $baseTester, ScenarioStateHookDispatcher $dispatcher)
50			{
51			$this->decoratedService = $decoratedService;
52			$this->baseTester = $baseTester;
53			$this->dispatcher = $dispatcher;
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function setUp(Environment $env, FeatureNode $feature, Scenario $scenario, $skip)
60			{
61			$setup = $this->decoratedService->setUp($env, $feature, $scenario, true);
62
63			if ($skip) {
64			return $setup;
65			}
66
67			$scope = new BeforeScenarioScope($env, $feature, $scenario);
68			$hookCallResults = $this->dispatcher->dispatchScopeHooks($scope);
69
70			return new HookedSetup($setup, $hookCallResults);
			0 ignored issues – show Bug introduced 2017-04-24 14:50 UTC by Report Bug Copy Issue Report It seems like `$hookCallResults` defined by `$this->dispatcher->dispatchScopeHooks($scope)` on line `68` can be `null`; however, `Behat\Testwork\Hook\Test...kedSetup::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
71			}
72
73			/**
74			* {@inheritdoc}
75			*/
76			public function test(Environment $env, FeatureNode $feature, Scenario $scenario, $skip)
77			{
78			return $this->decoratedService->test($env, $feature, $scenario, $skip);
79			}
80
81			/**
82			* {@inheritdoc}
83			*/
84			public function tearDown(Environment $env, FeatureNode $feature, Scenario $scenario, $skip, TestResult $result)
85			{
86			return $this->decoratedService->tearDown($env, $feature, $scenario, $skip, $result);
87			}
88			}
89

gorghoa / ScenarioStateBehatExtension

GitHub Access Token became invalid

Pull Request — master (#24)

ScenarioStateHookableScenarioTester::test() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like