StaffTest::testGetCMSFields() - Code Metrics - Inspection of "MINOR: Added Staff cms fields test. Converted to..." - gordonbanderson/weboftalent-staff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c40f5...e91382 )

by Gordon

created 2016-01-20 08:17 UTC

StaffTest::testGetCMSFields() A

↳ Parent: StaffTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	12
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

class StaffTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    public function testGetCMSFields()
    {
        $staff = new Staff();
        $fields = $staff->getCMSFields();
        $imageFields = $this->getFieldNamesForTab($fields, 'Root.Image');
        $this->assertEquals(array('Photo'), $imageFields);


        $jobFields = $this->getFieldNamesForTab($fields, 'Root.JobDetail');
        $expected = array('JobTitle', 'Email', 'TelephoneNumberDesk',
                                'TelephoneNumberMobile');
        $this->assertEquals($expected, $jobFields);

    }


    private function getFieldnamesForTab($fields, $tabName) {
        $tab = $fields->findOrMakeTab($tabName);
        $fields = $tab->fieldList();
        $names = array();
        foreach ($fields as $field) {
            array_push($names, $field->getName());
        }
        return $names;
    }

}


1			<?php
2
3			class StaffTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 08:23 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public function testGetCMSFields()
6			{
7			$staff = new Staff();
8			$fields = $staff->getCMSFields();
9			$imageFields = $this->getFieldNamesForTab($fields, 'Root.Image');
10			$this->assertEquals(array('Photo'), $imageFields);
			0 ignored issues – show Bug introduced 2016-01-20 08:23 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StaffTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
11
12			$jobFields = $this->getFieldNamesForTab($fields, 'Root.JobDetail');
13			$expected = array('JobTitle', 'Email', 'TelephoneNumberDesk',
14			'TelephoneNumberMobile');
15			$this->assertEquals($expected, $jobFields);
			0 ignored issues – show Bug introduced 2016-01-20 08:23 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StaffTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
16			}
17
18
19			private function getFieldnamesForTab($fields, $tabName) {
20			$tab = $fields->findOrMakeTab($tabName);
21			$fields = $tab->fieldList();
22			$names = array();
23			foreach ($fields as $field) {
24			array_push($names, $field->getName());
25			}
26			return $names;
27			}
28
29			}
30

gordonbanderson / weboftalent-staff

Push — master ( 7c40f5...e91382 )

StaffTest::testGetCMSFields() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like