Staff::getCMSFields() - Code Metrics - gordonbanderson/weboftalent-staff - Measure and Improve Code Quality continuously with Scrutinizer

Staff::getCMSFields() A
last analyzed 2016-01-20 08:35 UTC

↳ Parent: Staff

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Metric	Value
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.4285
cc	1
eloc	10
nc	1
nop	0
crap	1

<?php
/**
* Defines the StaffPage page type.
*/
class Staff extends Page
namespace YourVendor;

class YourClass { }
{
    public static $db = array(
        'TelephoneNumberDesk' => 'Varchar',
        'TelephoneNumberMobile' => 'Varchar',
        'Email' => 'Varchar',
        'ShowOnHomePage' => 'Boolean',
        'JobTitle' => 'Text',
    );

    public static $has_one = array(
        'Photo' => 'Image',
    );

    private static $icon = 'weboftalent-staff/icons/employee.png';



    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab('Root.Image', new UploadField('Photo'));

        $fields->addFieldToTab('Root.JobDetail', new TextField('JobTitle', _t('Staff.JOB_TITLE', 'Job Title')));

        $fields->addFieldToTab('Root.JobDetail', new EmailField('Email'));
        $fields->addFieldToTab('Root.JobDetail', new TextField('TelephoneNumberDesk'));
        $fields->addFieldToTab('Root.JobDetail', new TextField('TelephoneNumberMobile'));

        $fields->renameField('TelephoneNumberDesk', 'Telephone Number (Landline)');
        $fields->renameField('TelephoneNumberMobile', 'Telephone Number (Mobile)');

        return $fields;
    }
}

class Staff_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
}


1		<?php
2		/**
3		* Defines the StaffPage page type.
4		*/
5		class Staff extends Page
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 08:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6		{
7		public static $db = array(
8		'TelephoneNumberDesk' => 'Varchar',
9		'TelephoneNumberMobile' => 'Varchar',
10		'Email' => 'Varchar',
11		'ShowOnHomePage' => 'Boolean',
12		'JobTitle' => 'Text',
13		);
14
15		public static $has_one = array(
16		'Photo' => 'Image',
17		);
18
19		private static $icon = 'weboftalent-staff/icons/employee.png';
		0 ignored issues – show Unused Code introduced 2016-01-20 08:03 UTC by Report Bug Copy Issue Report The property `$icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20
21
22	1	public function getCMSFields()
23		{
24	1	$fields = parent::getCMSFields();
25	1	$fields->addFieldToTab('Root.Image', new UploadField('Photo'));
26
27	1	$fields->addFieldToTab('Root.JobDetail', new TextField('JobTitle', _t('Staff.JOB_TITLE', 'Job Title')));
28
29	1	$fields->addFieldToTab('Root.JobDetail', new EmailField('Email'));
30	1	$fields->addFieldToTab('Root.JobDetail', new TextField('TelephoneNumberDesk'));
31	1	$fields->addFieldToTab('Root.JobDetail', new TextField('TelephoneNumberMobile'));
32
33	1	$fields->renameField('TelephoneNumberDesk', 'Telephone Number (Landline)');
34	1	$fields->renameField('TelephoneNumberMobile', 'Telephone Number (Mobile)');
35
36	1	return $fields;
37		}
38		}
39
40		class Staff_Controller extends Page_Controller
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 08:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2016-01-20 08:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2016-01-20 08:23 UTC by Report Bug Copy Issue Report This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider becomes `DatabaseProvider`. Loading history...
41		{
42		}
43

gordonbanderson / weboftalent-staff

Staff::getCMSFields() A last analyzed 2016-01-20 08:35 UTC

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like

Staff::getCMSFields() A
last analyzed 2016-01-20 08:35 UTC