StaffFolder

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

0%

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	8	1
A	getPortletTitle()	0	4	1
A	getPortletImage()	0	4	1
A	getPortletCaption()	0	4	1

<?php
/**
* Defines the StaffFolder page type.
*/
class StaffFolder extends Page implements RenderableAsPortlet

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    {
    public static $db = array(
        'LinkToIndividualStaffPages' => 'Boolean',
    );
    public static $has_one = array(
        'MainImage' => 'Image',
    );

    private static $icon = 'weboftalent-staff/icons/employees.png';

The property $icon is not used and could be removed.

    public static $allowed_children = array('Staff');

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab('Root.Image', new UploadField('MainImage'));
        $fields->addFieldToTab('Root.Layout', new CheckboxField('LinkToIndividualStaffPages', 'If biographies are short, leave this as false to only show a single page of staff'));

        return $fields;
    }

    public function getPortletTitle()
    {
        return $this->Title;
    }

    // FIXME - make this more efficient
    public function getPortletImage()
    {
        return $this->MainImage();
    }

    public function getPortletCaption()
    {
        return '';
    }
}

class StaffFolder_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

{
    public function StaffFolderCacheKey()

StaffFolderCacheKey uses the super-global variable $_GET which is generally not recommended.

Method name "StaffFolder_Controller::StaffFolderCacheKey" is not in camel caps format

    {
        $start = isset($_GET['start']) ? (int) (Convert::raw2sql($_GET['start'])) : 0;

        return implode('_', array(
            'StaffFolders',
            $this->Locale,
            $this->AllChildren()->max('LastEdited'),
            '_',
            $this->ID,
            '_',
            $this->LastEdited,
            '_',
            $start,
            )
        );
    }
}