SiteMap_Controller

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

2 Methods

Rating	Name	Duplication	Size	Complexity
A	SiteMap()	0	8	1
B	makeList()	0	23	6

<?php

class SiteMap extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
  // hide from menus and search
  public static $defaults = array(

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

    'ShowInMenus' => 0,
    'ShowInSearch' => 0,
  );
}

class SiteMap_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

{
	/**
	* This function will return a unordered list of all pages on the site.
	* Watch for the switch between $page and $child in the second line of the
	* foreach().
	*
	* Note that this will only skip ErrorPage's at the top/root level of the site.
	* If you have an ErrorPage class somewhere else in the hierarchy, it will be
	* displayed.
	*/
	public function SiteMap()

Method name "SiteMap_Controller::SiteMap" is not in camel caps format

	{
		// Pages at the root level only
		$rootLevel = DataObject::get('Page', 'ParentID = 0');
		$output = '';

$output is not used, you could remove the assignment.

		$output = $this->makeList($rootLevel);
		return $output;
	}

	private function makeList($pages)
	{
		$output = '';
		if (count($pages)) {
			$output = '
			<ul class="sitemap-list">';
			foreach ($pages as $page) {
				if (!($page instanceof ErrorPage) && $page->ShowInMenus && $page->Title != $this->Title) {
					$output .= '
					<li><a href="'.$page->URLSegment.'" title="Go to the '.Convert::raw2xml($page->Title).' page">'.Convert::raw2xml($page->MenuTitle).'</a>';
					$whereStatement = 'ParentID = '.$page->ID;
					//$childPages = new DataObjectSet();
					$childPages = DataObject::get('Page', $whereStatement);
					$output .= $this->makeList($childPages);
					$output .= '
					</li>';
				}
			}
			$output .= '
			</ul>';
		}
		return $output;
	}
}