WebOfTalent\PageSiteMap\SiteMapController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	SiteMap()	0	8	1
B	makeList()	0	21	6

<?php
namespace WebOfTalent\PageSiteMap;

use SilverStripe\ErrorPage\ErrorPage;
use SilverStripe\Core\Convert;
use SilverStripe\ORM\DataObject;


class SiteMapController extends \PageController
{
    /**
    * This function will return a unordered list of all pages on the site.
    * Watch for the switch between $page and $child in the second line of the
    * foreach().
    *
    * Note that this will only skip ErrorPage's at the top/root level of the site.
    * If you have an ErrorPage class somewhere else in the hierarchy, it will be
    * displayed.
    */
    public function SiteMap()

Method name "SiteMapController::SiteMap" is not in camel caps format

    {
        // Pages at the root level only
        $rootLevel = \Page::get()->filter('ParentID', 0);
        $output = '';

$output is not used, you could remove the assignment.

        $output = $this->makeList($rootLevel);
        return $output;
    }

    private function makeList($pages)
    {
        $output = '';
        if (count($pages)) {
            $output = '
			<ul>';
            foreach ($pages as $page) {
                if (!($page instanceof ErrorPage) && $page->ShowInMenus && $page->Title != $this->Title) {

The class SilverStripe\ErrorPage\ErrorPage does not exist. Did you forget a USE statement, or did you not list all dependencies?

                    $output .= '
					<li><a href="'.$page->URLSegment.'" title="Go to the '.Convert::raw2xml($page->Title).' page">'.Convert::raw2xml($page->MenuTitle).'</a>';
                    $whereStatement = 'ParentID = '.$page->ID;
                    $childPages = DataObject::get('Page', $whereStatement);
                    $output .= $this->makeList($childPages);
                    $output .= '</li>';
                }
            }
            $output .= '
			</ul>';
        }
        return $output;
    }
}