ChildPaginatorControllerExtension

Complexity

Total Complexity

9

Size/Duplication

Total Lines	87
Duplicated Lines	29.89 %

Coupling/Cohesion

Components	2
Dependencies	4

7 Methods

Rating	Name	Duplication	Size	Complexity
A	PagedChildren()	13	15	2
A	AllPagedChildren()	13	15	2
A	PagedDataObjectsByClassName()	0	9	1
A	SetPagedOffset()	0	4	1
A	PagedChildrenAllButFirst()	0	3	1
A	PageNumber()	0	4	1
A	LastPagedResults()	0	4	1

<?php

class ChildPaginatorControllerExtension extends Extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /*
    Call this from a template to iterate through a number of items (default 10) for the
    currently selected page.  The result is saved as a variable called $this->lastPagedResults for
    caching purposes when it comes to rendering the pagination

    <code>
    <% control PagedChildren(NewsItem,8) %>
    <li>
    <a href="$Link">$Title</a>
    <br/>
    <a href="$Link">$NewsItemImage.SetWidth(200)</a>
    <br/>
    <a href="$Link">$NewsItemDate.Nice</a>

    </li>
    <% end_control %>
    </code>
    */
    public function PagedChildren($klazz, $pageLength = 10, $prime = false, $relationship_key = 'ParentID')

The parameter $relationship_key is not used and could be removed.

This method seems to be duplicated in your project.

Method name "ChildPaginatorControllerExtension::PagedChildren" is not in camel caps format

    {
        $parentID = $this->owner->ID;
        $req = Controller::curr()->getRequest();
        $list = DataList::create($klazz)->where('"ParentID" = '.$parentID);
        $this->lastPagedResults = new PaginatedList($list, $req);

The property lastPagedResults does not exist. Did you maybe forget to declare it?

        $this->lastPagedResults->setPageLength($pageLength);
        $this->lastPagedResults->setLimitItems($pageLength);

$pageLength is of type integer, but the function expects a boolean.

        $result = $this->lastPagedResults;
        if ($prime == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        $result = ''; // render nothing to the template, we are only updating variables

It seems like the identation of this line is off (expected at least 12 spaces, but found 8).

        }

        return $result;
    }

    public function AllPagedChildren($pageLength = 10, $sort = 'Sort', $prime = false, $relationship_key = 'ParentID')

The parameter $sort is not used and could be removed.

The parameter $relationship_key is not used and could be removed.

This method seems to be duplicated in your project.

Method name "ChildPaginatorControllerExtension::AllPagedChildren" is not in camel caps format

    {
        $parentID = $this->owner->ID;
        $req = Controller::curr()->getRequest();
        $list = SiteTree::get()->where('"ParentID" = '.$parentID);
        $this->lastPagedResults = new PaginatedList($list, $req);
        $this->lastPagedResults->setPageLength($pageLength);
        $this->lastPagedResults->setLimitItems($pageLength);

$pageLength is of type integer, but the function expects a boolean.

        $result = $this->lastPagedResults;
        if ($prime == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $result = ''; // render nothing to the template, we are only updating variables
        }

        return $result;
    }

    public function PagedDataObjectsByClassName($klazz, $pageLength = 10, $sort = 'ASC')

Method name "ChildPaginatorControllerExtension::PagedDataObjectsByClassName" is not in camel caps format

    {
        $req = Controller::curr()->getRequest();
        $this->lastPagedResults = new PaginatedList(DataList::create($klazz)->sort('LastEdited '.$sort), $req);
        $this->lastPagedResults->setPageLength($pageLength);
        $this->lastPagedResults->setLimitItems($pageLength);

$pageLength is of type integer, but the function expects a boolean.

        return $this->lastPagedResults;
    }

    public function SetPagedOffset($newoffset)

Method name "ChildPaginatorControllerExtension::SetPagedOffset" is not in camel caps format

    {
        $this->PagedOffset = $newoffset;

The property PagedOffset does not exist. Did you maybe forget to declare it?

    }

    public function PagedChildrenAllButFirst()

Method name "ChildPaginatorControllerExtension::PagedChildrenAllButFirst" is not in camel caps format

    {
    }

    /*
    The current page number.  This is only populated after the call to PagedChildren
    */
    public function PageNumber()

Method name "ChildPaginatorControllerExtension::PageNumber" is not in camel caps format

    {
        return $this->PageNumber; // variable, not the method, populated when loading the pages items

The property PageNumber does not exist. Did you maybe forget to declare it?

    }

    /*
    A cached copy of the pagination results
    */
    public function LastPagedResults()

Method name "ChildPaginatorControllerExtension::LastPagedResults" is not in camel caps format

    {
        return $this->lastPagedResults;
    }
}