GridRowsExtensionTest

Complexity

Total Complexity

15

Size/Duplication

Total Lines	120
Duplicated Lines	24.17 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	testSplitDataListMethodDoesNotExist()	0	19	2
A	testSplitDataListFromModelIntoGridRows()	15	15	2
A	testSplitDataListFromControllerIntoGridRows()	14	14	2
A	testSplitClassNameDataListIntoGridRows()	0	19	4

<?php

namespace WebOfTalent\GridRows\Tests;

use PageController;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\TestOnly;

class GridRowsExtensionTest extends FunctionalTest
{
    protected static $fixture_file = 'GridRowsExtensionTest.yml';

    protected $extraDataObjects = array(
        'GridRowItemTO'
    );

    public function setUp()
    {
        $this->requiredExtensions = array(
            'GridRowItemTO' => array('GridRowsExtension')
        );

        parent::setUp();
    }


    public function testSplitDataListMethodDoesNotExist()
    {
        $message = 'Method not found.  A grid cannot be formed from the method'
                 . ' GridRowItemsTHISMETHODDOESNOTEXIST';
        $this->setExpectedException('InvalidArgumentException', $message);

        $page = $this->objFromFixture('GridRowItemPageTO', 'page001');
        $page->doPublish();
        $controller = new GridRowItemPageTO_Controller();
        $controller->setDataModel($page);

        for ($columns=1; $columns < 15; $columns++) {
            $grid = $controller->SplitDataListIntoGridRows(
                'GridRowItemsTHISMETHODDOESNOTEXIST', // method from model
                $columns
            );
            $this->checkGrid($grid, $columns, 10);
        }
    }

    public function testSplitDataListFromModelIntoGridRows()

This method seems to be duplicated in your project.

    {
        $page = $this->objFromFixture('GridRowItemPageTO', 'page001');
        $page->doPublish();
        $controller = new GridRowItemPageTO_Controller();
        $controller->setDataModel($page);

        for ($columns=1; $columns < 15; $columns++) {
            $grid = $controller->SplitDataListIntoGridRows(
                'GridRowItems', // method from model
                $columns
            );
            $this->checkGrid($grid, $columns, 10);
        }
    }

    public function testSplitDataListFromControllerIntoGridRows()

This method seems to be duplicated in your project.

    {
        $page = $this->objFromFixture('GridRowItemPageTO', 'page001');
        $page->doPublish();
        $controller = new GridRowItemPageTO_Controller();
        $controller->setDataModel($page);
        for ($columns=1; $columns < 15; $columns++) {
            $grid = $controller->SplitDataListIntoGridRows(
                'GridItems', // method from controller
                $columns
            );
            $this->checkGrid($grid, $columns, 10);
        }
    }

    /*
    Check multiple number of columns with amounts from 1 to just over the
    total number of grid items, namely 12
     */
    public function testSplitClassNameDataListIntoGridRows()
    {
        $page = $this->objFromFixture('GridRowItemPageTO', 'page001');
        $page->doPublish();
        $controller = new PageController();
        $controller->setDataModel($page);
        for ($columns=1; $columns < 15; $columns++) {
            for ($i=1; $i < 15; $i++) {
                $grid = $controller->SplitClassNameDataListIntoGridRows(
                    'GridRowItemTO',
                    $columns,
                    $i,
                    $sort = 'LastEdited DESC'
                );
                $amount = $i > 12 ? 12: $i;
                $this->checkGrid($grid, $columns, $amount);
            }
        }
    }


    private function checkGrid($grid, $maxWidth, $amount)
    {
        $items = 0;
        $rows = 0;
        $widths = array();
        foreach ($grid->getIterator() as $row) {
            $rows++;
            $width = 0;
            foreach ($row->Columns->getIterator() as $column) {
                $items++;
                $width++;
            }
            array_push($widths, $width);
        }

        // last value will be <= max width
        $lastVal = array_pop($widths);
        $this->assertLessThanOrEqual($maxWidth, $lastVal);

        // All but the last row should equal the expected width, $maxWidth
        foreach ($widths as $width) {
            $this->assertEquals($maxWidth, $width);
        }
        $this->assertEquals($amount, $items);
    }
}


class GridRowItemTO extends DataObject implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    private static $db = array('Name' => 'Varchar');

The property $db is not used and could be removed.

    private static $has_one = array('GridRowItemPage' => 'GridRowItemPageTO');

The property $has_one is not used and could be removed.

}

class GridRowItemPageTO extends Page implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    private static $has_many = array('GridRowItems' => 'GridRowItemTO');

The property $has_many is not used and could be removed.

}

class GridRowItemPageTO_Controller extends PageController implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

This class is not in CamelCase format.

{

    /*
    This is a test method on the *controller*
     */
    public function GridItems()

Method name "GridRowItemPageTO_Controller::GridItems" is not in camel caps format

    {
        return $this->model->GridRowItems();
    }
}