Issues in API.php (master) - Issues in master - gordonbanderson/ukpostcodes - Measure and Improve Code Quality continuously with Scrutinizer

Issues (34)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/API.php (34 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Suilven\UKPostCodes;

//Based on code by Ryan Hart 2016 https://github.com/ryryan/Postcodes-IO-PHP/blob/master/Postcodes-IO-PHP.php

use Suilven\UKPostCodes\Models\PostCode;

class API
{
    /**
     * @param string $postcode
     * @return false|PostCode
     */
    public function lookup($postcode)

    {
        $jsonurl = "https://api.postcodes.io/postcodes/".$postcode;
        $json = $this->request($jsonurl);
        $decoded = json_decode($json, true);
        if ($decoded['status'] == 200) {
            return new PostCode($decoded['result']);
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function bulkLookup($postcodes)

    {
        $data_string = json_encode(array('postcodes' => $postcodes));
        $ch = curl_init('https://api.postcodes.io/postcodes');
        curl_setopt($ch, CURLOPT_CUSTOMREQUEST, "POST");
        curl_setopt($ch, CURLOPT_POSTFIELDS, $data_string);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($ch, CURLOPT_HTTPHEADER, array(
                'Content-Type: application/json',
                'Content-Length: ' . strlen($data_string)));

        $result = curl_exec($ch);
        curl_close($ch);
        $decoded = json_decode($result);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
    public function nearestPostcodesFromLongLat($longitude, $latitude)

    {
        $jsonurl = "https://api.postcodes.io/postcodes?lon=".$longitude."&lat=".$latitude;
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
    public function bulkReverseGeocoding($geolocations)

    {
        $data_string = json_encode(array('geolocations' => $geolocations));

        $ch = curl_init('https://api.postcodes.io/postcodes');
        curl_setopt($ch, CURLOPT_CUSTOMREQUEST, "POST");
        curl_setopt($ch, CURLOPT_POSTFIELDS, $data_string);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($ch, CURLOPT_HTTPHEADER, array(
                'Content-Type: application/json',
                'Content-Length: ' . strlen($data_string)));

        $result = curl_exec($ch);
        curl_close($ch);
        $decoded = json_decode($result);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    /**
     * @return bool|PostCode a random PostCode
     */
    public function random()

    {
        $jsonurl = "https://api.postcodes.io/random/postcodes/";
        $json = $this->request($jsonurl);

        $decoded = json_decode($json, true);
        if ($decoded['status'] == 200) {
            return new PostCode($decoded['result']);
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function validate($postcode)

    {
        $jsonurl = "https://api.postcodes.io/postcodes/".$postcode."/validate";
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            if ($decoded->result == 1) {

                return true;
            } else {
                return false;
            }
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function nearest($postcode)

    {
        $jsonurl = "https://api.postcodes.io/postcodes/".$postcode."/nearest";
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function partial($postcode)

    {
        $jsonurl = "https://api.postcodes.io/postcodes/".$postcode."/autocomplete";
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function query($postcode)

    {
        $jsonurl = "https://api.postcodes.io/postcodes?q=".$postcode;
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function lookupTerminated($postcode)

    {
        $jsonurl = "https://api.postcodes.io/terminated_postcodes/".$postcode;
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function lookupOutwardCode($code)

    {
        $jsonurl = "https://api.postcodes.io/outcodes/".$code;
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function nearestOutwardCode($code)

    {
        $jsonurl = "https://api.postcodes.io/outcodes/".$code."/nearest";
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function nearestOutwardCodeFromLongLat($longitude, $latitude)

    {
        $jsonurl = "https://api.postcodes.io/outcodes?lon=".$longitude."&lat=".$latitude;
        $json = $this->request($jsonurl);

        $decoded = json_decode($json);
        if ($decoded->status == 200) {
            return $decoded->result;
        } else {
            return false;
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }


    public function distance($postcode1, $postcode2, $unit)
    {
        //adapted from http://www.geodatasource.com/developers/php
        /*
            Units:
            M = Miles
            N = Nautical Miles
            K = Kilometers
        */
        $postcode1 = $this->lookup($postcode1);
        $postcode2 = $this->lookup($postcode2);

        if ($postcode1 == null || $postcode2 == null) {
            return false;
        }

        $theta = $postcode1->longitude - $postcode2->longitude;
        $dist = sin(deg2rad($postcode1->latitude)) * sin(deg2rad($postcode2->latitude)) +
            cos(deg2rad($postcode1->latitude)) * cos(deg2rad($postcode2->latitude)) * cos(deg2rad($theta));
        $dist = acos($dist);
        $dist = rad2deg($dist);
        $miles = $dist * 60 * 1.1515;
        $unit = strtoupper($unit);

        if ($unit == "K") {
            return ($miles * 1.609344);
        } elseif ($unit == "N") {
            return ($miles * 0.8684);
        } else {
            return $miles;
        }
    }

    /**
     * Execute a request
     *
     * @param string $jsonurl
     * @return bool|string
     */
    public function request($jsonurl)
    {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, str_replace(' ', '%20', $jsonurl));
        curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'GET');
        curl_setopt($ch, CURLOPT_HTTPHEADER, [
          'Content-Type: application/json',
        ]);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        $response = curl_exec($ch);
        curl_close($ch);
        return $response;
    }
}


1		<?php
2
3		namespace Suilven\UKPostCodes;
4
5		//Based on code by Ryan Hart 2016 https://github.com/ryryan/Postcodes-IO-PHP/blob/master/Postcodes-IO-PHP.php
6
7		use Suilven\UKPostCodes\Models\PostCode;
8
9		class API
10		{
11		/**
12		* @param string $postcode
13		* @return false\|PostCode
14		*/
15	View Code Duplication	public function lookup($postcode)
		0 ignored issues – show Duplication introduced 2020-05-07 22:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$jsonurl = "https://api.postcodes.io/postcodes/".$postcode;
18		$json = $this->request($jsonurl);
19		$decoded = json_decode($json, true);
20		if ($decoded['status'] == 200) {
21		return new PostCode($decoded['result']);
22		} else {
23		return false;
24		}
25		return false;
		0 ignored issues – show Unused Code introduced 2020-05-07 22:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return false;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
26		}
27
28
29	View Code Duplication	public function bulkLookup($postcodes)
		0 ignored issues – show Documentation introduced 2020-05-07 22:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2020-05-07 22:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$data_string = json_encode(array('postcodes' => $postcodes));
32		$ch = curl_init('https://api.postcodes.io/postcodes');
33		curl_setopt($ch, CURLOPT_CUSTOMREQUEST, "POST");
34		curl_setopt($ch, CURLOPT_POSTFIELDS, $data_string);
35		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
36		curl_setopt($ch, CURLOPT_HTTPHEADER, array(
37		'Content-Type: application/json',

gordonbanderson / ukpostcodes

Issues (34)

Security Analysis no request data

src/API.php (34 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like