TemplateOverrideExtensionTest - Code Metrics - Inspection of "FIX: Change dependency to cms as opposed to framew..." - gordonbanderson/template-override - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — AUTOMATED_TESTING ( 349e9a...3a587f )

by Gordon

created 2016-01-04 05:02 UTC

TemplateOverrideExtensionTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	26
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUpOnce()	0	8	1
A	testUpdateCMSFields()	0	11	2

<?php

class TemplateOverrideExtensionTest extends SapphireTest {
namespace YourVendor;

class YourClass { }

	protected static $fixture_file = 'template-override/tests/pages.yml';

	public function setUpOnce() {
		/*

		$this->requiredExtensions = array(
			'Member' => array('MapExtension', 'MapLayerExtension')
		);
		*/
		parent::setupOnce();
	}


	public function testUpdateCMSFields() {
		$page = $this->objFromFixture('Page', 'page1');
		$fields = $page->getCMSFields();
		$tab = $fields->findOrMakeTab('Root.Template');
		$fields = $tab->FieldList();
		$names = array();
		foreach ($fields as $field) {
			$names[] = $field->getName();
		}
		$expected = array('AlternativeTemplate', 'infofield');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	}
}


1			<?php
2
3			class TemplateOverrideExtensionTest extends SapphireTest {
			1 ignored issue – show Coding Style Compatibility introduced 2016-01-04 05:05 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5			protected static $fixture_file = 'template-override/tests/pages.yml';
6
7			public function setUpOnce() {
8			/*
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-04 05:05 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
9			$this->requiredExtensions = array(
10			'Member' => array('MapExtension', 'MapLayerExtension')
11			);
12			*/
13			parent::setupOnce();
14			}
15
16
17			public function testUpdateCMSFields() {
18			$page = $this->objFromFixture('Page', 'page1');
19			$fields = $page->getCMSFields();
20			$tab = $fields->findOrMakeTab('Root.Template');
21			$fields = $tab->FieldList();
22			$names = array();
23			foreach ($fields as $field) {
24			$names[] = $field->getName();
25			}
26			$expected = array('AlternativeTemplate', 'infofield');
			0 ignored issues – show Unused Code introduced 2016-01-04 05:05 UTC by Report Bug Copy Issue Report `$expected` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27			}
28			}
29

gordonbanderson / template-override

Push — AUTOMATED_TESTING ( 349e9a...3a587f )

TemplateOverrideExtensionTest A

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Duplication Side-by-Side

Filter issues like