gordonbanderson / ss3gallery

code/GalleryPage.php

<?php

class GalleryPage extends PageWithImage

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $has_many = array(
        'GalleryImages' => 'GalleryImage',
    );

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'GalleryDate' => 'Date',
    );

    private static $icon = 'ss3gallery/icons/photo.png';

The property $icon is not used and could be removed.

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $gridFieldConfig = GridFieldConfig_RecordEditor::create();
        //$gridFieldConfig->addComponent(new GridFieldBulkEditingTools());
        $gridFieldConfig->addComponent($gbu = new GridFieldBulkUpload());
        $editableFields = array('Title', 'Caption', 'Aperture', 'ShutterSpeed', 'Image');
        $gridFieldConfig->addComponent($gbm = new GridFieldBulkManager($editableFields));
        $gridFieldConfig->addComponent(new GridFieldSortableRows('SortOrder'));
        $galleryimagesi18n = _t('GalleryImage.PLURALNAME', 'Gallery Images');
        //$gbu->setConfig('fileRelationName','Image');

        $gbu->setUfConfig('folderName', 'galleries/'.$this->ID);
        $gbm->setConfig('editableFields', $editableFields);
        // This is no longer available... $gbm->setConfig('fieldsNameBlacklist', array('Lat', 'Lon', 'ZoomLevel'));
        $gridfield = new GridField('GalleryImages', $galleryimagesi18n, $this->GalleryImages()->sort('"SortOrder"'), $gridFieldConfig);
        $fields->addFieldToTab('Root.'.$galleryimagesi18n, $gridfield);

        $fields->addFieldToTab('Root.Date', new DateField('GalleryDate'));

        return $fields;
    }

    public function Map()

Method name "GalleryPage::Map" is not in camel caps format

    {
        $photosWithLocation = $this->GalleryImages()->where('"Lat" != 0 AND "Lon" !=0');
        if ($photosWithLocation->count() == 0) {
            return '<!-- no image locations found -->'; // don't render a map
        }
        $map = $photosWithLocation->getRenderableMap();
        $map->setZoom(10);
        $map->setAdditionalCSSClasses('fullWidthMap');
        $map->setShowInlineMapDivStyle(true);
        $map->setClusterer(true);

        $map->setSize('100%', '400px');
        return $map;
    }

     public function getGalleryImages()

Line indented incorrectly; expected 4 spaces, found 5

    {

Opening brace indented incorrectly; expected 5 spaces, found 4

        return $this->GalleryImages()->sort('SortOrder');
    }

Line indented incorrectly; expected 8 spaces, found 4

Closing brace indented incorrectly; expected 5 spaces, found 4

}



class GalleryPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

{
    public static $allowed_actions = array();

    public function GetGalleryImages()

Method name "GalleryPage_Controller::GetGalleryImages" is not in camel caps format

    {
        return $this->GalleryImages()->sort('SortOrder');
    }
}