ImageMetaDataExtension::processExifData() - Code Metrics - Inspection of "ENHANCEMEENT: Images for Pretty Photo" - gordonbanderson/ss3gallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( faff87...db1cae )

by Gordon

created 2016-02-06 07:24 UTC

ImageMetaDataExtension::processExifData() C

↳ Parent: ImageMetaDataExtension

Complexity

Conditions	7
Paths	250

Size

Total Lines	76
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	52
CRAP Score	7.0817

Metric	Value
dl	0
loc	76
ccs	52
cts	59
cp	0.8814
rs	5.506
cc	7
eloc	57
nc	250
nop	0
crap	7.0817

How to fix Long Method

<?php

class ImageMetaDataExtension extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'ExifRead' => 'Boolean',
        'Aperture' => 'Varchar',
        'ShutterSpeed' => 'Varchar',
        'TakenAt' => 'Datetime',
        'ISO' => 'Int',
        'Orientation' => 'Int'
    );


    public static $defaults = array('ExifRead' => false);

    public function processExifData()
    {
        $image    = $this->owner->Image();
        $filename = BASE_PATH . '/' . $image->Filename;

        // when the image is first saved, the file will still be a temp file
        if ($image->exists()) {
            try {
                $exif = exif_read_data($filename, null, true);
                $aperture = $exif['COMPUTED']['ApertureFNumber'];
                $aperture = str_replace('f/', '', $aperture);
                $this->owner->Aperture = $aperture;

                $shutterspeed = '';
                if (isset($exif['ExposureTime'])) {
                    $shutterspeed = $exif['ExposureTime'];
                } else {
                    $shutterspeed = $exif['EXIF']['ExposureTime'];
                }

                $this->owner->ShutterSpeed = $shutterspeed;
                if (isset($exif['DateTimeOriginal'])) {
                    $this->owner->TakenAt = $exif['DateTimeOriginal'];
                } else {
                    $this->owner->TakenAt = $exif['EXIF']['DateTimeOriginal'];
                }

                $iso = '';
                if (isset($exif['ISOSpeedRatings'])) {
                    $iso = $exif['ISOSpeedRatings'];
                } else {
                    $iso = $exif['EXIF']['ISOSpeedRatings'];
                }

                $this->owner->ISO = $iso;

                if (isset($exif['GPS'])) {
                    $gps      = $exif['GPS'];
                    $latarray = $gps['GPSLatitude'];
                    $degrees  = $latarray[0];
                    $parts    = explode('/', $degrees);
                    $degrees  = $parts[0] / $parts[1];
                    $minutes  = $latarray[1];
                    $parts    = explode('/', $minutes);
                    $minutes  = $parts[0] / $parts[1];
                    $seconds  = $latarray[2];
                    $parts    = explode('/', $seconds);
                    $seconds  = $parts[0] / $parts[1];
                    $latitude = $degrees + $minutes / 60 + $seconds / 3600;
                    $lonarray = $gps['GPSLongitude'];
                    $degrees  = $lonarray[0];
                    $parts    = explode('/', $degrees);
                    $degrees  = $parts[0] / $parts[1];
                    $minutes  = $lonarray[1];
                    $parts    = explode('/', $minutes);
                    $minutes  = $parts[0] / $parts[1];
                    $seconds  = $lonarray[2];
                    $parts    = explode('/', $seconds);
                    $seconds  = $parts[0] / $parts[1];

                    $longitude        = $degrees + $minutes / 60 + $seconds / 3600;
                    $this->owner->Lat = $latitude;
                    $this->owner->Lon = $longitude;
                }

                $image = $this->owner->Image();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                $this->owner->ExifRead = true;
                $this->owner->Orientation = $this->owner->Image()->getOrientation();
                $this->owner->write();
            }
            catch (Exception $e) {
                error_log($e->getMessage());
            }
        }
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();

        if (!($this->owner->ExifRead)) {
            $this->processExifData();
        }
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $imagesToProcess = GalleryImage::get()->filter('ExifRead', 0);
        foreach ($imagesToProcess as $image) {
            $image->processExifData();
        }

        DB::alteration_message('Updated image metadata where EXIF has not been ' . 'processed', 'changed');
    }

}


1		<?php
2
3		class ImageMetaDataExtension extends DataExtension
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 09:21 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		private static $db = array(
		0 ignored issues – show Unused Code introduced 2016-02-06 07:29 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6		'ExifRead' => 'Boolean',
7		'Aperture' => 'Varchar',
8		'ShutterSpeed' => 'Varchar',
9		'TakenAt' => 'Datetime',
10		'ISO' => 'Int',
11		'Orientation' => 'Int'
12		);
13
14
15		public static $defaults = array('ExifRead' => false);
16
17	1	public function processExifData()
18		{
19	1	$image = $this->owner->Image();
20	1	$filename = BASE_PATH . '/' . $image->Filename;
21
22		// when the image is first saved, the file will still be a temp file
23	1	if ($image->exists()) {
24		try {
25	1	$exif = exif_read_data($filename, null, true);
26	1	$aperture = $exif['COMPUTED']['ApertureFNumber'];
27	1	$aperture = str_replace('f/', '', $aperture);
28	1	$this->owner->Aperture = $aperture;
29
30	1	$shutterspeed = '';
31	1	if (isset($exif['ExposureTime'])) {
32		$shutterspeed = $exif['ExposureTime'];
33		} else {
34	1	$shutterspeed = $exif['EXIF']['ExposureTime'];
35		}
36
37	1	$this->owner->ShutterSpeed = $shutterspeed;
38	1	if (isset($exif['DateTimeOriginal'])) {
39		$this->owner->TakenAt = $exif['DateTimeOriginal'];
40		} else {
41	1	$this->owner->TakenAt = $exif['EXIF']['DateTimeOriginal'];
42		}
43
44	1	$iso = '';
45	1	if (isset($exif['ISOSpeedRatings'])) {
46		$iso = $exif['ISOSpeedRatings'];
47		} else {
48	1	$iso = $exif['EXIF']['ISOSpeedRatings'];
49		}
50
51	1	$this->owner->ISO = $iso;
52
53	1	if (isset($exif['GPS'])) {
54	1	$gps = $exif['GPS'];
55	1	$latarray = $gps['GPSLatitude'];
56	1	$degrees = $latarray[0];
57	1	$parts = explode('/', $degrees);
58	1	$degrees = $parts[0] / $parts[1];
59	1	$minutes = $latarray[1];
60	1	$parts = explode('/', $minutes);
61	1	$minutes = $parts[0] / $parts[1];
62	1	$seconds = $latarray[2];
63	1	$parts = explode('/', $seconds);
64	1	$seconds = $parts[0] / $parts[1];
65	1	$latitude = $degrees + $minutes / 60 + $seconds / 3600;
66	1	$lonarray = $gps['GPSLongitude'];
67	1	$degrees = $lonarray[0];
68	1	$parts = explode('/', $degrees);
69	1	$degrees = $parts[0] / $parts[1];
70	1	$minutes = $lonarray[1];
71	1	$parts = explode('/', $minutes);
72	1	$minutes = $parts[0] / $parts[1];
73	1	$seconds = $lonarray[2];
74	1	$parts = explode('/', $seconds);
75	1	$seconds = $parts[0] / $parts[1];
76
77	1	$longitude = $degrees + $minutes / 60 + $seconds / 3600;
78	1	$this->owner->Lat = $latitude;
79	1	$this->owner->Lon = $longitude;
80	1	}
81
82	1	$image = $this->owner->Image();
		0 ignored issues – show Unused Code introduced 2016-02-06 07:29 UTC by Report Bug Copy Issue Report `$image` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
83
84	1	$this->owner->ExifRead = true;
85	1	$this->owner->Orientation = $this->owner->Image()->getOrientation();
86	1	$this->owner->write();
87		}
88	1	catch (Exception $e) {
89		error_log($e->getMessage());
90		}
91	1	}
92	1	}
93
94	1	public function onAfterWrite()
95		{
96	1	parent::onAfterWrite();
97
98	1	if (!($this->owner->ExifRead)) {
99	1	$this->processExifData();
100	1	}
101	1	}
102
103		public function requireDefaultRecords()
104		{
105		parent::requireDefaultRecords();
106		$imagesToProcess = GalleryImage::get()->filter('ExifRead', 0);
107		foreach ($imagesToProcess as $image) {
108		$image->processExifData();
109		}
110
111		DB::alteration_message('Updated image metadata where EXIF has not been ' . 'processed', 'changed');
112		}
113
114		}
115

gordonbanderson / ss3gallery

Push — master ( faff87...db1cae )

ImageMetaDataExtension::processExifData() C

Complexity

Size

Duplication

Code Coverage

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like