GalleryImageShortCodeHandlerTest::testNonExistentImage() - Code Metrics - Inspection of "Merge branch 'tests'" - gordonbanderson/ss3gallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 18f749...9fc766 )

by Gordon

created 2016-02-07 16:08 UTC

testNonExistentImage() A

↳ Parent: GalleryImageShortCodeHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	14
Ratio	100 %

Metric	Value
dl	14
loc	14
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

class GalleryImageShortCodeHandlerTest extends SapphireTest {
namespace YourVendor;

class YourClass { }
	protected static $fixture_file = 'ss3gallery/tests/ss3gallery.yml';

    public function testValidImage()

    {
        $page = $this->objFromFixture('Page', 'page02');

        $galleryImage = $this->objFromFixture('GalleryImage' , 'gi01');

        $content = "[GalleryImage id='{$galleryImage->ID}']";
        $page->Content = $content;
        $page->write();
        $html = ShortcodeParser::get_active()->parse($page->Content);

        $this->assertEquals('<div class="imageWithCaption centercontents ">

<img src=""><div class="meta">
    <p class="exif">f s </p>
    <p class="caption">Test Image 1</p>
</div>
</div>

', $html);
	}


    public function testNonExistentImage()

    {
        $page = $this->objFromFixture('Page', 'page02');

        $galleryImage = $this->objFromFixture('GalleryImage' , 'gi01');

        $nonExistentID = 1000 + $galleryImage->ID;
        // his will not exist
        $content = "[GalleryImage id='{$nonExistentID}']";
        $page->Content = $content;
        $page->write();
        $html = ShortcodeParser::get_active()->parse($page->Content);

        $this->assertEquals('image not found', $html);

    }
}


1		<?php
2
3		class GalleryImageShortCodeHandlerTest extends SapphireTest {
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 09:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		protected static $fixture_file = 'ss3gallery/tests/ss3gallery.yml';
5
6	View Code Duplication	public function testValidImage()
		0 ignored issues – show Duplication introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
7		{
8		$page = $this->objFromFixture('Page', 'page02');
9
10		$galleryImage = $this->objFromFixture('GalleryImage' , 'gi01');
		0 ignored issues – show Coding Style introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report Space found before comma in function call Loading history...
11		$content = "[GalleryImage id='{$galleryImage->ID}']";
12		$page->Content = $content;
13		$page->write();
14		$html = ShortcodeParser::get_active()->parse($page->Content);
15
16		$this->assertEquals('<div class="imageWithCaption centercontents ">
		1 ignored issue – show Bug introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<GalleryImageShortCodeHandlerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
17		<img src=""><div class="meta">
18		<p class="exif">f s </p>
19		<p class="caption">Test Image 1</p>
20		</div>
21		</div>
22
23		', $html);
24		}
25
26
27	View Code Duplication	public function testNonExistentImage()
		0 ignored issues – show Duplication introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$page = $this->objFromFixture('Page', 'page02');
30
31		$galleryImage = $this->objFromFixture('GalleryImage' , 'gi01');
		0 ignored issues – show Coding Style introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report Space found before comma in function call Loading history...
32		$nonExistentID = 1000 + $galleryImage->ID;
33		// his will not exist
34		$content = "[GalleryImage id='{$nonExistentID}']";
35		$page->Content = $content;
36		$page->write();
37		$html = ShortcodeParser::get_active()->parse($page->Content);
38
39		$this->assertEquals('image not found', $html);
		1 ignored issue – show Bug introduced 2016-02-07 16:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<GalleryImageShortCodeHandlerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
40		}
41		}
42

gordonbanderson / ss3gallery

Push — master ( 18f749...9fc766 )

testNonExistentImage() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like