AttachedGalleryExtension::updateCMSFields() - Code Metrics - Inspection of "Merge branch 'tests'" - gordonbanderson/ss3gallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 18f749...9fc766 )

by Gordon

created 2016-02-07 16:08 UTC

AttachedGalleryExtension::updateCMSFields() A

↳ Parent: AttachedGalleryExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
cc	1
eloc	6
nc	1
nop	1
crap	1

<?php

class AttachedGalleryExtension extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $has_one = array(

        'AttachedGallery' => 'GalleryPage',
    );

    public function updateCMSFields(FieldList $fields)
    {
        $galleryField = new TreeDropdownField(
            'AttachedGalleryID',
            _t('AttachedGalleryExtension.CHOOSE_A_GALLERY', 'Choose another gallery to show on this page'),
            'GalleryPage'
        );

        $fields->addFieldToTab('Root.'._t('AttachedGalleryExtension.ATTACHED_GALLERY', 'Attached Gallery'), $galleryField);
    }

    /*
    Return a list of the attached gallery and any child galleries
    */
    public function InlineGalleries()

    {
        $result = new ArrayList();

        // find child galleries
        foreach ($this->owner->AllChildren() as $child) {
            if ($child->ClassName == 'GalleryPage') {
                $result->push($child);
            }
        }

        if ($this->owner->AttachedGalleryID != 0) {
            $result->push($this->owner->AttachedGallery());
        }

        return $result;
    }
}


1		<?php
2
3		class AttachedGalleryExtension extends DataExtension
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-20 09:21 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		private static $has_one = array(
		0 ignored issues – show Unused Code introduced 2016-01-20 09:21 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6		'AttachedGallery' => 'GalleryPage',
7		);
8
9	1	public function updateCMSFields(FieldList $fields)
10		{
11	1	$galleryField = new TreeDropdownField(
12	1	'AttachedGalleryID',
13	1	_t('AttachedGalleryExtension.CHOOSE_A_GALLERY', 'Choose another gallery to show on this page'),
14		'GalleryPage'
15	1	);
16
17	1	$fields->addFieldToTab('Root.'._t('AttachedGalleryExtension.ATTACHED_GALLERY', 'Attached Gallery'), $galleryField);
18	1	}
19
20		/*
21		Return a list of the attached gallery and any child galleries
22		*/
23	1	public function InlineGalleries()
		0 ignored issues – show Coding Style introduced 2016-01-20 09:47 UTC by Report Bug Copy Issue Report Method name "AttachedGalleryExtension::InlineGalleries" is not in camel caps format Loading history...
24		{
25	1	$result = new ArrayList();
26
27		// find child galleries
28	1	foreach ($this->owner->AllChildren() as $child) {
29	1	if ($child->ClassName == 'GalleryPage') {
30	1	$result->push($child);
31	1	}
32	1	}
33
34	1	if ($this->owner->AttachedGalleryID != 0) {
35	1	$result->push($this->owner->AttachedGallery());
36	1	}
37
38	1	return $result;
39		}
40		}
41

gordonbanderson / ss3gallery

Push — master ( 18f749...9fc766 )

AttachedGalleryExtension::updateCMSFields() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like