GalleryImageShortCodeHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

92.86%

1 Method

Rating	Name	Duplication	Size	Complexity
B	parse_gallery_image()	0	31	3

<?php

class GalleryImageShortCodeHandler

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static function parse_gallery_image($arguments, $caption = null, $parser = null)

The parameter $caption is not used and could be removed.

The parameter $parser is not used and could be removed.

Method name "GalleryImageShortCodeHandler::parse_gallery_image" is not in camel caps format

    {

        // first things first, if we dont have an ID, then we don't need to
        // go any further
        if (empty($arguments['id'])) {
            return;
        }

        $customise = array();
        $galleryImage = DataObject::get_by_id('GalleryImage', $arguments['id']);
        if (!$galleryImage) {
            return 'image not found';
        }

        $customise['Image'] = $galleryImage->Image();
        $customise['Aperture'] = $galleryImage->Aperture;
        $customise['ShutterSpeed'] = $galleryImage->ShutterSpeed;

         //set the caption
        $customise['Title'] = $galleryImage->Title;

        //overide the defaults with the arguments supplied
        $customise = array_merge($customise, $arguments);

        //get our YouTube template
        $template = new SSViewer('ShortCodeGalleryImage');

        //return the customised template
        return $template->process(new ArrayData($customise));
    }
}