GalleryImageShortCodeHandlerTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	84.62 %

Coupling/Cohesion

Components	0
Dependencies	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testValidImage()	19	19	1
A	testNonExistentImage()	14	14	1

<?php

class GalleryImageShortCodeHandlerTest extends SapphireTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

  protected static $fixture_file = 'ss3gallery/tests/ss3gallery.yml';

Line indented incorrectly; expected 4 spaces, found 2

    public function testValidImage()

This method seems to be duplicated in your project.

    {
        $page = $this->objFromFixture('Page', 'page02');

        $galleryImage = $this->objFromFixture('GalleryImage', 'gi01');
        $content = "[GalleryImage id='{$galleryImage->ID}']";
        $page->Content = $content;
        $page->write();
        $html = ShortcodeParser::get_active()->parse($page->Content);

        $this->assertEquals('<div class="imageWithCaption centercontents ">
<img src=""><div class="meta">
    <p class="exif">f s </p>
    <p class="caption">Test Image 1</p>
</div>
</div>

', $html);
  }

Line indented incorrectly; expected 4 spaces, found 2

Closing brace indented incorrectly; expected 4 spaces, found 2

    public function testNonExistentImage()

This method seems to be duplicated in your project.

    {
        $page = $this->objFromFixture('Page', 'page02');

        $galleryImage = $this->objFromFixture('GalleryImage', 'gi01');
        $nonExistentID = 1000+$galleryImage->ID;
        // his will not exist
        $content = "[GalleryImage id='{$nonExistentID}']";
        $page->Content = $content;
        $page->write();
        $html = ShortcodeParser::get_active()->parse($page->Content);

        $this->assertEquals('image not found', $html);
    }
}