GalleryFolderTest   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 23
Duplicated Lines 56.52 %

Coupling/Cohesion

Components 0
Dependencies 2
Metric Value
wmc 3
lcom 0
cbo 2
dl 13
loc 23
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A testGetCMSFields() 13 13 2
A testSummary() 0 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
class GalleryFolderTest extends SapphireTest
0 ignored issues
show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
4
{
5 View Code Duplication
    public function testGetCMSFields()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
6
    {
7
        $gf = new GalleryFolder();
8
        $tab = $gf->getCMSFields()->fieldByName('Root.Main');
9
        $fields = $tab->FieldList();
10
        $names = array();
11
        foreach ($fields as $field) {
12
            array_push($names, $field->getName());
13
        }
14
        $expected = array('InstallWarningHeader', 'Title', 'URLSegment',
15
                        'MenuTitle', 'BriefIntroduction', 'Content');
16
        $this->assertEquals($expected, $names);
17
    }
18
19
    public function testSummary()
20
    {
21
        $gf = new GalleryFolder();
22
        $gf->Content = 'This is actually used for the summary';
23
        $this->assertEquals($gf->Content, $gf->Summary());
24
    }
25
}
26