AttachedGalleryExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	10	1
A	InlineGalleries()	0	17	4

<?php

class AttachedGalleryExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $has_one = array(

The property $has_one is not used and could be removed.

        'AttachedGallery' => 'GalleryPage',
    );

    public function updateCMSFields(FieldList $fields)
    {
        $galleryField = new TreeDropdownField(
            'AttachedGalleryID',
            _t('AttachedGalleryExtension.CHOOSE_A_GALLERY', 'Choose another gallery to show on this page'),
            'GalleryPage'
        );

        $fields->addFieldToTab('Root.'._t('AttachedGalleryExtension.ATTACHED_GALLERY', 'Attached Gallery'), $galleryField);
    }

    /*
    Return a list of the attached gallery and any child galleries
    */
    public function InlineGalleries()

Method name "AttachedGalleryExtension::InlineGalleries" is not in camel caps format

    {
        $result = new ArrayList();

        // find child galleries
        foreach ($this->owner->AllChildren() as $child) {
            if ($child->ClassName == 'GalleryPage') {
                $result->push($child);
            }
        }

        if ($this->owner->AttachedGalleryID != 0) {
            $result->push($this->owner->AttachedGallery());
        }

        return $result;
    }
}