Completed
Push — dev2 ( 983df6...5a7fe0 )
by Gordon
14:04
created
src/SilverStripe/Elastica/ElasticaSearchHelperInterface.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 	/**
5 5
 	 * Alter the query or add to it, perhaps for example adding aggregation
6 6
 	 * @param  Elastic\Query &$query query object from Elastica
7
-	 * @return [type]         [description]
7
+	 * @return void         [description]
8 8
 	 */
9 9
 	public function augmentQuery(&$query);
10 10
 
@@ -12,6 +12,7 @@  discard block
 block discarded – undo
12 12
 	 * Update filters, perhaps remaps them, prior to performing a search.
13 13
 	 * This allows for aggregation values to be updated prior to rendering.
14 14
 	 * @param  array &$filters array of key/value pairs for query filtering
15
+	 * @return void
15 16
 	 */
16 17
 	public function updateFilters(&$filters);
17 18
 
@@ -19,7 +20,7 @@  discard block
 block discarded – undo
19 20
 	 * Manipulate the array of aggregations post search butprior to rendering
20 21
 	 * them in a template.
21 22
 	 * @param  [type] &$aggs [description]
22
-	 * @return [type]        [description]
23
+	 * @return void        [description]
23 24
 	 */
24 25
 	public function updateAggregation(&$aggs);
25 26
 
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/ResultList.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -250,6 +250,9 @@
 block discarded – undo
250 250
 	}
251 251
 
252 252
 
253
+	/**
254
+	 * @return integer
255
+	 */
253 256
 	public function getTotalItems() {
254 257
 		$this->getResults();
255 258
 		return $this->TotalItems;
Please login to merge, or discard this patch.
tests/AggregationUnitTest.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -1036,6 +1036,7 @@
 block discarded – undo
1036 1036
 	/**
1037 1037
 	 * Test searching
1038 1038
 	 * http://stackoverflow.com/questions/28305250/elasticsearch-customize-score-for-synonyms-stemming
1039
+	 * @param string $queryText
1039 1040
 	 */
1040 1041
 	private function search($queryText,$fields = array('Title' => 1, 'Description' => 1),
1041 1042
 		$filters = array()) {
Please login to merge, or discard this patch.
tests/ElasticaUtilTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -153,6 +153,9 @@
 block discarded – undo
153 153
 
154 154
 	/**
155 155
 	 * Simulate a call to Elastica to get suggestions for a given phrase
156
+	 * @param string $phrase
157
+	 * @param string $suggestion
158
+	 * @param string $highlightedSuggestion
156 159
 	 * @return [type] [description]
157 160
 	 */
158 161
 	private function getSuggestionArray($phrase, $suggestion, $highlightedSuggestion) {
Please login to merge, or discard this patch.
tests/ElasticSearchPage_Validator_Test.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -106,6 +106,10 @@
 block discarded – undo
106 106
 	}
107 107
 
108 108
 
109
+	/**
110
+	 * @param string $fieldName
111
+	 * @param string $message
112
+	 */
109 113
 	private function checkForError($fieldName, $badValue, $message) {
110 114
 		$this->ElasticSearchPage->$fieldName = $badValue;
111 115
 
Please login to merge, or discard this patch.
tests/ElasticsearchTestBase.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -132,6 +132,10 @@  discard block
 block discarded – undo
132 132
 	}
133 133
 
134 134
 
135
+	/**
136
+	 * @param integer $depth
137
+	 * @param string $parentKey
138
+	 */
135 139
 	private function recurseArrayAssertion($toAssert, $depth, $parentKey) {
136 140
 		$prefix = str_repeat("\t",$depth);
137 141
 		echo "\t{$prefix}'$parentKey' => array(\n";
@@ -160,6 +164,10 @@  discard block
 block discarded – undo
160 164
 	/*
161 165
 	Helper methods for testing CMS fields
162 166
 	 */
167
+
168
+	/**
169
+	 * @param string $tabName
170
+	 */
163 171
 	public function checkTabExists($fields, $tabName) {
164 172
 		echo "Searching for tab $tabName\n";
165 173
 		$tab = $fields->findOrMakeTab("Root.{$tabName}");
@@ -184,6 +192,9 @@  discard block
 block discarded – undo
184 192
 	}
185 193
 
186 194
 
195
+	/**
196
+	 * @param string $fieldName
197
+	 */
187 198
 	public function checkFieldExists($tab,$fieldName) {
188 199
 		$fields = $tab->Fields();
189 200
 		echo "TAB:{$tab->Name}\n";
Please login to merge, or discard this patch.
tests/SearchAndIndexingTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -479,6 +479,9 @@
 block discarded – undo
479 479
 	}
480 480
 
481 481
 
482
+	/**
483
+	 * @param string $query
484
+	 */
482 485
 	private function getResultsFor($query, $pageLength = 10, $fields = array('Title' => 1, 'Description' => 1)) {
483 486
 		$es = new ElasticSearcher();
484 487
 		$es->setStart(0);
Please login to merge, or discard this patch.
tests/SearchableTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -479,6 +479,9 @@
 block discarded – undo
479 479
 	}
480 480
 
481 481
 
482
+	/**
483
+	 * @param string $query
484
+	 */
482 485
 	private function getResultsFor($query, $pageLength = 10, $fields = array('Title' => 1, 'Description' => 1)) {
483 486
 		$es = new ElasticSearcher();
484 487
 		$es->setStart(0);
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/QueryGenerator.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
 	private $classes = '';
48 48
 
49 49
 
50
+	/**
51
+	 * @param string $newQueryText
52
+	 */
50 53
 	public function setQueryText($newQueryText) {
51 54
 		$this->queryText = $newQueryText;
52 55
 	}
@@ -62,6 +65,9 @@  discard block
 block discarded – undo
62 65
 	}
63 66
 
64 67
 
68
+	/**
69
+	 * @param boolean $newShowResultsForEmptyQuery
70
+	 */
65 71
 	public function setShowResultsForEmptyQuery($newShowResultsForEmptyQuery) {
66 72
 		$this->showResultsForEmptyQuery = $newShowResultsForEmptyQuery;
67 73
 	}
@@ -72,11 +78,17 @@  discard block
 block discarded – undo
72 78
 	}
73 79
 
74 80
 
81
+	/**
82
+	 * @param integer $newPageLength
83
+	 */
75 84
 	public function setPageLength($newPageLength) {
76 85
 		$this->pageLength = $newPageLength;
77 86
 	}
78 87
 
79 88
 
89
+	/**
90
+	 * @param integer $newStart
91
+	 */
80 92
 	public function setStart($newStart) {
81 93
 		$this->start = $newStart;
82 94
 	}
@@ -287,6 +299,9 @@  discard block
 block discarded – undo
287 299
 	}
288 300
 
289 301
 
302
+	/**
303
+	 * @param Query $query
304
+	 */
290 305
 	private function addAggregation(&$query) {
291 306
 		// aggregation (optional)
292 307
 		if ($this->manipulatorInstance) {
Please login to merge, or discard this patch.