Completed
Branch dev2 (85bfa2)
by Gordon
06:36 queued 02:41
created
tests/AutocompleteControllerTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 		// Delete and assert that it does not exist
23 23
 		echo "Displaying searchable fields\n";
24
-		$sql =  "SELECT ID,Name,ClazzName from SearchableField";
24
+		$sql = "SELECT ID,Name,ClazzName from SearchableField";
25 25
 		$records = DB::query($sql);
26 26
 		foreach ($records as $record) {
27 27
 			print_r($record);
@@ -30,8 +30,8 @@  discard block
 block discarded – undo
30 30
 		$filter = array('Name' => 'Title', 'ClazzName' => 'FlickrPhotoTO');
31 31
 		$sf = SearchableField::get()->filter($filter)->first();
32 32
 		print_r($sf);
33
-		$sql = "UPDATE ElasticSearchPage_ElasticaSearchableFields SET Searchable=1,".
34
-				"EnableAutocomplete=1 where SearchableFieldID=".$sf->ID;
33
+		$sql = "UPDATE ElasticSearchPage_ElasticaSearchableFields SET Searchable=1," .
34
+				"EnableAutocomplete=1 where SearchableFieldID=" . $sf->ID;
35 35
 		echo $sql;
36 36
 
37 37
 		DB::query($sql);
Please login to merge, or discard this patch.
tests/TermVectorTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,8 +17,8 @@
 block discarded – undo
17 17
 		sort($terms);
18 18
 		$expected = array('Description', 'Description.shingles', 'Description.standard',
19 19
 			'ShutterSpeed',
20
-			'TestMethod','TestMethod.shingles','TestMethod.standard',
21
-			'TestMethodHTML','TestMethodHTML.shingles','TestMethodHTML.standard',
20
+			'TestMethod', 'TestMethod.shingles', 'TestMethod.standard',
21
+			'TestMethodHTML', 'TestMethodHTML.shingles', 'TestMethodHTML.standard',
22 22
 			'Title', 'Title.autocomplete', 'Title.shingles', 'Title.standard');
23 23
 		$this->assertEquals($expected, $terms);
24 24
 
Please login to merge, or discard this patch.
tests/ElasticaServiceTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 			$this->invokeMethod($this->service, 'createIndex', array());
28 28
 			$this->assertFalse(true, "Creation of index with unknown locale should have failed");
29 29
 		} catch (Exception $e) {
30
-			$this->assertTrue(true,"Creation of index with unknown locale failed as expected");
30
+			$this->assertTrue(true, "Creation of index with unknown locale failed as expected");
31 31
 		}
32 32
 
33 33
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 		$fp->write();
117 117
 		$this->service->getIndex()->refresh();
118 118
 
119
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart-1);
119
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart - 1);
120 120
 
121 121
 		$fp->ShowInSearch = true;
122 122
 		$fp->write();
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 		$fp->doUnpublish();
135 135
 
136 136
 		$this->service->getIndex()->refresh();
137
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart-1);
137
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart - 1);
138 138
 	}
139 139
 
140 140
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 		$fp->delete();
147 147
 
148 148
 		$this->service->getIndex()->refresh();
149
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart-1);
149
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart - 1);
150 150
 	}
151 151
 
152 152
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 		$fp->delete();
159 159
 
160 160
 		$this->service->getIndex()->refresh();
161
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart-1);
161
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart - 1);
162 162
 	}
163 163
 
164 164
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 		//Check that the number of indexing requests has increased by 2
178 178
 		$deltaReqs = $this->service->getIndexingRequestCtr() - $reqs;
179 179
 		//One call is made for each of Page and FlickrPhotoTO
180
-		$this->assertEquals(2,$deltaReqs);
180
+		$this->assertEquals(2, $deltaReqs);
181 181
 
182 182
 		// default installed pages plus 100 FlickrPhotoTOs
183 183
 		$this->checkNumberOfIndexedDocuments(103);
@@ -195,21 +195,21 @@  discard block
 block discarded – undo
195 195
 		$fp = new FlickrPhotoTO();
196 196
 		$fp->Title = 'The cat sits on the mat';
197 197
 		$fp->write();
198
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart+1);
198
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart + 1);
199 199
 
200 200
 		$fp2 = new FlickrPhotoTO();
201 201
 		$fp2->Title = 'The cat sat on the hat';
202 202
 		$fp2->write();
203
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart+2);
203
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart + 2);
204 204
 
205 205
 		$fp3 = new FlickrPhotoTO();
206 206
 		$fp3->Title = 'The bat flew around the cat';
207 207
 		$fp3->write();
208
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart+3);
208
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart + 3);
209 209
 
210 210
 		//Check that the number of indexing requests has increased by 3
211 211
 		$deltaReqs = $this->service->getIndexingRequestCtr() - $reqs;
212
-		$this->assertEquals(3,$deltaReqs);
212
+		$this->assertEquals(3, $deltaReqs);
213 213
 	}
214 214
 
215 215
 
@@ -283,6 +283,6 @@  discard block
 block discarded – undo
283 283
 	public function testListIndexes() {
284 284
 		$message = 'This is a test trace';
285 285
 		$trace = $this->service->listIndexes($message);
286
-		$this->assertContains('elastica_ss_module_test_en_us', print_r($trace,1));
286
+		$this->assertContains('elastica_ss_module_test_en_us', print_r($trace, 1));
287 287
 	}
288 288
 }
Please login to merge, or discard this patch.
tests/InheritanceTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 		$expected = array('first');
27 27
 		$this->assertEquals($expected, array_keys($terms['Title.standard']['terms']));
28 28
 
29
-		$expected = array('fi','fir','firs','first','ir','irs','irst','rs','rst','st');
29
+		$expected = array('fi', 'fir', 'firs', 'first', 'ir', 'irs', 'irst', 'rs', 'rst', 'st');
30 30
 		$this->assertEquals($expected, array_keys($terms['Title.autocomplete']['terms']));
31 31
 
32 32
 		// ---- now a parental class page ----
@@ -60,20 +60,20 @@  discard block
 block discarded – undo
60 60
 		$terms = $page->getTermVectors();
61 61
 
62 62
 		//Check the expected fields are indexed
63
-		$expected = array('Content','Content.shingles','Content.standard','FatherText','FatherText.shingles','FatherText.standard',
64
-			'GrandFatherText','GrandFatherText.shingles','GrandFatherText.standard','Link','Title','Title.autocomplete',
65
-			'Title.shingles','Title.standard');
63
+		$expected = array('Content', 'Content.shingles', 'Content.standard', 'FatherText', 'FatherText.shingles', 'FatherText.standard',
64
+			'GrandFatherText', 'GrandFatherText.shingles', 'GrandFatherText.standard', 'Link', 'Title', 'Title.autocomplete',
65
+			'Title.shingles', 'Title.standard');
66 66
 		$indexedFields = array_keys($terms);
67 67
 		sort($indexedFields);
68 68
 		foreach ($indexedFields as $field) {
69
-			echo "'".$field."',";
69
+			echo "'" . $field . "',";
70 70
 		}
71 71
 		$this->assertEquals($expected, $indexedFields);
72 72
 
73 73
 		$fatherTerms = $terms['FatherText.standard']['terms'];
74 74
 		$grandFatherTerms = $terms['GrandFatherText.standard']['terms'];
75 75
 
76
-		$expected = array('father', 'field', 'grandfather', 'page', 'trace3');;
76
+		$expected = array('father', 'field', 'grandfather', 'page', 'trace3'); ;
77 77
 		$this->assertEquals($expected, array_keys($fatherTerms));
78 78
 
79 79
 		$expected = array('grandfather', 'page', 'trace4');
Please login to merge, or discard this patch.
tests/FindElasticaSearchPageExtensionTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,11 +25,11 @@  discard block
 block discarded – undo
25 25
 		// don't check the server name as this will differ, just check the path is /search/
26 26
 		$uri = $searchPage->SearchPageURI('testsearchpage');
27 27
 		$splits = explode('/', $uri);
28
-		$this->assertEquals($splits[3],'search');
28
+		$this->assertEquals($splits[3], 'search');
29 29
 
30 30
 		// check the form
31 31
 		$form = $searchPage->SearchPageForm('testsearchpage');
32
-		$this->assertInstanceOf('ElasticSearchForm',$form);
32
+		$this->assertInstanceOf('ElasticSearchForm', $form);
33 33
 
34 34
 		$fields = $form->Fields();
35 35
 		$actions = $form->Actions();
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	public function testButtonOverride() {
46 46
 		$searchPage = $this->objFromFixture('ElasticSearchPage', 'search');
47 47
 		$buttonText = 'Search Me!';
48
-		$form = $searchPage->SearchPageForm('testsearchpage',$buttonText);
48
+		$form = $searchPage->SearchPageForm('testsearchpage', $buttonText);
49 49
 		$actions = $form->Actions();
50 50
 		$this->assertEquals($buttonText, $actions->FieldByName('action_submit')->Title());
51 51
 	}
@@ -86,12 +86,12 @@  discard block
 block discarded – undo
86 86
 		$esp = new ElasticSearchPage();
87 87
 		// ensure default identifier
88 88
 		$esp->Identifier = $searchPage->Identifier;
89
-		$esp->Title='This should not be saved';
89
+		$esp->Title = 'This should not be saved';
90 90
 		try {
91 91
 			$esp->write();
92 92
 			$this->assertFalse(true, 'Duplicate identifier was incorrectly saved');
93 93
 		} catch (Exception $e) {
94
-			$this->assertTrue(true,'The page could not be saved as expected, due to duplicate '.
94
+			$this->assertTrue(true, 'The page could not be saved as expected, due to duplicate ' .
95 95
 								'identifier');
96 96
 		}
97 97
 	}
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/indexing/GermanIndexSettings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 		$germanWithURLs = array(
29 29
 			'tokenizer' => 'uax_url_email',
30 30
 			//'filter' => array('english_possessive_stemmer', 'lowercase', 'english_stop', /*'english_keywords',*/ 'english_stemmer' ),
31
-			'filter' => array('no_single_chars', 'german_snowball', 'lowercase', 'german_stop' ),
31
+			'filter' => array('no_single_chars', 'german_snowball', 'lowercase', 'german_stop'),
32 32
 			'type' => 'custom'
33 33
 		);
34 34
 
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/indexing/BaseIndexSettings.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -214,7 +214,7 @@
 block discarded – undo
214 214
 			$analyzers['folded'] = $analyzerFolded;
215 215
 		}
216 216
 
217
-        //Store bigrams in the index, namely pairs of words
217
+		//Store bigrams in the index, namely pairs of words
218 218
 		$this->addFilter('filter_shingle', array(
219 219
 			'type' => 'shingle',
220 220
 			'min_shingle_size' => 2,
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -177,10 +177,10 @@  discard block
 block discarded – undo
177 177
 			'type' => 'nGram',
178 178
 			'min_gram' => 2,
179 179
 			'max_gram' => 20,
180
-			'token_chars' => array('letter', 'digit','punctuation', 'symbol')
180
+			'token_chars' => array('letter', 'digit', 'punctuation', 'symbol')
181 181
 		));
182 182
 
183
-		$this->addAnalyzer('autocomplete_index_analyzer',array(
183
+		$this->addAnalyzer('autocomplete_index_analyzer', array(
184 184
 			'type' => 'custom',
185 185
 			'tokenizer' => 'whitespace',
186 186
 			'filter' => array(
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 			)
191 191
 		));
192 192
 
193
-		$this->addAnalyzer('autocomplete_search_analyzer',array(
193
+		$this->addAnalyzer('autocomplete_search_analyzer', array(
194 194
 			'type' => 'custom',
195 195
 			'tokenizer' => 'whitespace',
196 196
 			'filter' => array(
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/indexing/EnglishIndexSettings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 		$englishWithURLs = array(
48 48
 			'tokenizer' => 'uax_url_email',
49 49
 			//'filter' => array('english_possessive_stemmer', 'lowercase', 'english_stop', /*'english_keywords',*/ 'english_stemmer' ),
50
-			'filter' => array('no_single_chars', 'english_snowball', 'lowercase', $this->stopWordFilter ),
50
+			'filter' => array('no_single_chars', 'english_snowball', 'lowercase', $this->stopWordFilter),
51 51
 			'type' => 'custom'
52 52
 		);
53 53
 
Please login to merge, or discard this patch.
src/SilverStripe/Elastica/DeleteIndexTask.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	 * Execute the task to delete the currently configured index
25 25
 	 */
26 26
 	public function run($request) {
27
-		$message = function ($content) {
27
+		$message = function($content) {
28 28
 			print(\Director::is_cli() ? "$content\n" : "<p>$content</p>");
29 29
 		};
30 30
 
Please login to merge, or discard this patch.