ResultList::__construct() - Code Metrics - Inspection of "FIX: (hopefully) Change tactic with testing testSi..." - gordonbanderson/silverstripe-elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev2 ( 764ed3...9e10b9 )

by Gordon

created 2015-12-30 12:30 UTC

ResultList::__construct() A

↳ Parent: ResultList

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	6
ccs	6
cts	6
cp	1
rs	9.4286
c	1
b	1
f	0
cc	1
eloc	5
nc	1
nop	4
crap	1

<?php

namespace SilverStripe\Elastica;

use Elastica\Index;
use Elastica\Query;
use Elastica\Filter\GeoDistance;


/**
 * A list wrapper around the results from a query. Note that not all operations are implemented.
 */
class ResultList extends \ViewableData implements \SS_Limitable, \SS_List {

	/**
	 * @var \Elastica\Index
	 */
	private $service;

	/**
	 * @var \Elastica\Query
	 */
	private $query;

	/**
	 * List of types to search for, default (blank) returns all
	 * @var string
	 */

	private $types = '';

	/**
	 * Filters, i.e. selected aggregations, to apply to the search
	 */
	private $filters = array();

	/**
	 * An array list of aggregations from this search
	 * @var ArrayList
	 */
	private $aggregations;


	/**
	 * Create a search and then optionally tweak it.  Actual search is only performed against
	 * Elasticsearch when the getResults() method is called.
	 *
	 * @param ElasticaService $service object used to communicate with Elasticsearch
	 * @param Query           $query   Elastica query object, created via QueryGenerator
	 * @param string          $queryText       the text from the query
	 * @param array           $filters Selected filters, used for aggregation purposes only
	 *                                 (i.e. query already filtered prior to this)
	 */
	public function __construct(ElasticaService $service, Query $query, $queryText, $filters = array()) {
		$this->service = $service;

		$this->query = $query;
		$this->originalQueryText = $queryText;
		$this->filters = $filters;
	}

	public function __clone() {
		$this->query = clone $this->query;
	}

	/**
	 * @return \Elastica\Index
	 */
	public function getService() {
		return $this->service;
	}

	/**
	 * Set a new list of types (SilverStripe classes) to search for
	 * @param string $newTypes comma separated list of types to search for
	 */
	public function setTypes($newTypes) {
		$this->types = $newTypes;
	}


	/**
	 * @return \Elastica\Query
	 */
	public function getQuery() {
		return $this->query;
	}


	/**
	 * Get the aggregation results for this query.  Should only be called
	 * after $this->getResults() has been executed.
	 * Note this will be an empty array list if there is no aggregation
	 *
	 * @return ArrayList ArrayList of the aggregated results for this query
	 */
	public function getAggregations() {
		return $this->aggregations;
	}

	/**
	 * @return array
	 */
	public function getResults() {
		if(!isset($this->_cachedResults)) {
			$ers = $this->service->search($this->query, $this->types);

			if(isset($ers->MoreLikeThisTerms)) {
				$this->MoreLikeThisTerms = $ers->MoreLikeThisTerms;
			}

			if(isset($ers->getSuggests()['query-phrase-suggestions'])) {
				$suggest = $ers->getSuggests()['query-phrase-suggestions'];
				$suggestedPhraseAndHL = ElasticaUtil::getPhraseSuggestion($suggest);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
				if($suggestedPhraseAndHL) {
					$this->SuggestedQuery = $suggestedPhraseAndHL['suggestedQuery'];
					$this->SuggestedQueryHighlighted = $suggestedPhraseAndHL['suggestedQueryHighlighted'];
				}
			}

			$this->TotalItems = $ers->getTotalHits();
			$this->TotalTime = $ers->getTotalTime();
			$this->_cachedResults = $ers->getResults();
			// make the aggregations available to the templating, title casing
			// to be consistent with normal templating conventions
			$aggs = $ers->getAggregations();

			// array of index field name to human readable title
			$indexedFieldTitleMapping = array();

			// optionally remap keys and store chosen aggregations from get params
			if(isset($this->SearchHelper)) {
				$manipulator = \Injector::inst()->create($this->SearchHelper);
				$manipulator->query = $this->query;
				$manipulator->updateAggregation($aggs);

				$indexedFieldTitleMapping = $manipulator->getIndexFieldTitleMapping();
			}
			$aggsTemplate = new \ArrayList();

			// Convert the buckets into a form suitable for SilverStripe templates
			$queryText = $this->originalQueryText;

			// if not search term remove it and aggregate with a blank query
			if($queryText == '' && sizeof($aggs) > 0) {
				$params = $this->query->getParams();
				unset($params['query']);
				$this->query->setParams($params);
				$queryText = '';
			}

			// get the base URL for the current facets selected
			$baseURL = \Controller::curr()->Link() . '?';
			$prefixAmp = false;
			if($queryText !== '') {
				$baseURL .= 'q=' . urlencode($queryText);
				$prefixAmp = true;
			}

			// now add the selected facets
			foreach($this->filters as $key => $value) {
				if($prefixAmp) {
					$baseURL .= '&';
				} else {
					$prefixAmp = true;
				}
				$baseURL .= $key . '=' . urlencode($value);
			}

			foreach(array_keys($aggs) as $key) {
				$aggDO = new \DataObject();
				//FIXME - Camel case separate here
				if(isset($indexedFieldTitleMapping[$key])) {
					$aggDO->Name = $indexedFieldTitleMapping[$key];
				} else {
					$aggDO->Name = $key;
				}

				// now the buckets
				if(isset($aggs[$key]['buckets'])) {
					$bucketsAL = new \ArrayList();
					foreach($aggs[$key]['buckets'] as $value) {
						$ct = new \DataObject();
						$ct->Key = $value['key'];
						$ct->DocumentCount = $value['doc_count'];
						$query[$key] = $value;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
						if($prefixAmp) {
							$url = $baseURL . '&';
						} else {
							$url = $baseURL;
							$prefixAmp = true;
						}

						// check if currently selected
						if(isset($this->filters[$key])) {

							if($this->filters[$key] === (string)$value['key']) {
								$ct->IsSelected = true;
								// mark this facet as having been selected, so optional toggling
								// of the display of the facet can be done via the template.
								$aggDO->IsSelected = true;

								$urlParam = $key . '=' . urlencode($this->filters[$key]);

								// possible ampersand combos to remove
								$v2 = '&' . $urlParam;
								$v3 = $urlParam . '&';
								$url = str_replace($v2, '', $url);
								$url = str_replace($v3, '', $url);
								$url = str_replace($urlParam, '', $url);
								$ct->URL = $url;
							}
						} else {
							$url .= $key . '=' . urlencode($value['key']);
							$prefixAmp = true;
						}

						$url = rtrim($url, '&');

						$ct->URL = $url;
						$bucketsAL->push($ct);
					}

					// in the case of range queries we wish to remove the non selected ones
					if($aggDO->IsSelected) {
						$newList = new \ArrayList();
						foreach($bucketsAL->getIterator() as $bucket) {
							if($bucket->IsSelected) {
								$newList->push($bucket);
								break;
							}
						}

						$bucketsAL = $newList;
					}
					$aggDO->Buckets = $bucketsAL;


				}
				$aggsTemplate->push($aggDO);
			}
			$this->aggregations = $aggsTemplate;

		}
		return $this->_cachedResults;
	}


	public function getTotalItems() {
		$this->getResults();
		return $this->TotalItems;
	}


	public function getTotalTime() {
		return $this->TotalTime;
	}

	public function getIterator() {
		return $this->toArrayList()->getIterator();
	}

	public function limit($limit, $offset = 0) {
		$list = clone $this;

		$list->getQuery()->setSize($limit);
		$list->getQuery()->setFrom($offset);

		return $list;
	}

	/**
	 * Converts results of type {@link \Elastica\Result}
	 * into their respective {@link DataObject} counterparts.
	 *
	 * @return array DataObject[]
	 */
	public function toArray() {
		$result = array();

		/** @var $found \Elastica\Result[] */
		$found = $this->getResults();
		$needed = array();
		$retrieved = array();

		foreach($found as $item) {
			$type = $item->getType();

			if(!array_key_exists($type, $needed)) {
				$needed[$type] = array($item->getId());
				$retrieved[$type] = array();
			} else {
				$needed[$type][] = $item->getId();
			}
		}

		foreach($needed as $class => $ids) {
			foreach($class::get()->byIDs($ids) as $record) {
				$retrieved[$class][$record->ID] = $record;
			}
		}

		// Title and Link are special cases
		$ignore = array('Title', 'Link', 'Title.standard', 'Link.standard');

		foreach($found as $item) {
			// Safeguards against indexed items which might no longer be in the DB
			if(array_key_exists($item->getId(), $retrieved[$item->getType()])) {

				$data_object = $retrieved[$item->getType()][$item->getId()];
				$data_object->setElasticaResult($item);
				$highlights = $item->getHighlights();

				//$snippets will contain the highlights shown in the body of the search result
				//$namedSnippets will be used to add highlights to the Link and Title
				$snippets = new \ArrayList();
				$namedSnippets = new \ArrayList();

				foreach(array_keys($highlights) as $fieldName) {
					$fieldSnippets = new \ArrayList();

					foreach($highlights[$fieldName] as $snippet) {
						$do = new \DataObject();
						$do->Snippet = $snippet;

						// skip title and link in the summary of highlights
						if(!in_array($fieldName, $ignore)) {
							$snippets->push($do);
						}

						$fieldSnippets->push($do);
					}

					if($fieldSnippets->count() > 0) {
						//Fields may have a dot in their name, e.g. Title.standard - take this into account
						//As dots are an issue with template syntax, store as Title_standard
						$splits = explode('.', $fieldName);
						if(sizeof($splits) == 1) {
							$namedSnippets->$fieldName = $fieldSnippets;
						} else {
							// The Title.standard case, for example
							$splits = explode('.', $fieldName);
							$compositeFielddName = $splits[0] . '_' . $splits[1];
							$namedSnippets->$compositeFielddName = $fieldSnippets;
						}

					}


				}


				$data_object->SearchHighlights = $snippets;
				$data_object->SearchHighlightsByField = $namedSnippets;

				$result[] = $data_object;

			}
		}


		return $result;
	}

	public function toArrayList() {
		return new \ArrayList($this->toArray());
	}

	public function toNestedArray() {
		$result = array();

		foreach($this as $record) {
			$result[] = $record->toMap();
		}

		return $result;
	}

	public function first() {
		// TODO
		throw new \Exception('Not implemented');
	}

	public function last() {
		// TODO: Implement last() method
		throw new \Exception('Not implemented');
	}

	public function map($key = 'ID', $title = 'Title') {
		return $this->toArrayList()->map($key, $title);
	}

	public function column($col = 'ID') {
		if($col == 'ID') {
			$ids = array();

			foreach($this->getResults() as $result) {
				$ids[] = $result->getId();
			}

			return $ids;
		} else {
			return $this->toArrayList()->column($col);
		}
	}

	public function each($callback) {
		return $this->toArrayList()->each($callback);
	}

	public function count() {
		return count($this->toArray());
	}

	/**
	 * @ignore
	 */
	public function offsetExists($offset) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function offsetGet($offset) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function offsetSet($offset, $value) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function offsetUnset($offset) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function add($item) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function remove($item) {
		throw new \Exception('Not implemented');
	}

	/**
	 * @ignore
	 */
	public function find($key, $value) {
		throw new \Exception('Not implemented');
	}

}


1		<?php
2
3		namespace SilverStripe\Elastica;
4
5		use Elastica\Index;
6		use Elastica\Query;
7		use Elastica\Filter\GeoDistance;
8
9
10		/**
11		* A list wrapper around the results from a query. Note that not all operations are implemented.
12		*/
13		class ResultList extends \ViewableData implements \SS_Limitable, \SS_List {
14
15		/**
16		* @var \Elastica\Index
17		*/
18		private $service;
19
20		/**
21		* @var \Elastica\Query
22		*/
23		private $query;
24
25		/**
26		* List of types to search for, default (blank) returns all
27		* @var string
28		*/
29
30		private $types = '';
31
32		/**
33		* Filters, i.e. selected aggregations, to apply to the search
34		*/
35		private $filters = array();
36
37		/**
38		* An array list of aggregations from this search
39		* @var ArrayList
40		*/
41		private $aggregations;
42
43
44		/**
45		* Create a search and then optionally tweak it. Actual search is only performed against
46		* Elasticsearch when the getResults() method is called.
47		*
48		* @param ElasticaService $service object used to communicate with Elasticsearch
49		* @param Query $query Elastica query object, created via QueryGenerator
50		* @param string $queryText the text from the query
51		* @param array $filters Selected filters, used for aggregation purposes only
52		* (i.e. query already filtered prior to this)
53		*/
54	1	public function __construct(ElasticaService $service, Query $query, $queryText, $filters = array()) {
55	1	$this->service = $service;
		0 ignored issues – show Documentation Bug introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report It seems like `$service` of type `object<SilverStripe\Elastica\ElasticaService>` is incompatible with the declared type `object<Elastica\Index>` of property `$service`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
56	1	$this->query = $query;
57	1	$this->originalQueryText = $queryText;
58	1	$this->filters = $filters;
59	1	}
60
61		public function __clone() {
62		$this->query = clone $this->query;
63		}
64
65		/**
66		* @return \Elastica\Index
67		*/
68		public function getService() {
69		return $this->service;
70		}
71
72		/**
73		* Set a new list of types (SilverStripe classes) to search for
74		* @param string $newTypes comma separated list of types to search for
75		*/
76		public function setTypes($newTypes) {
77		$this->types = $newTypes;
78		}
79
80
81		/**
82		* @return \Elastica\Query
83		*/
84		public function getQuery() {
85		return $this->query;
86		}
87
88
89		/**
90		* Get the aggregation results for this query. Should only be called
91		* after $this->getResults() has been executed.
92		* Note this will be an empty array list if there is no aggregation
93		*
94		* @return ArrayList ArrayList of the aggregated results for this query
95		*/
96	1	public function getAggregations() {
97	1	return $this->aggregations;
98		}
99
100		/**
101		* @return array
102		*/
103	1	public function getResults() {
104	1	if(!isset($this->_cachedResults)) {
105	1	$ers = $this->service->search($this->query, $this->types);
106
107	1	if(isset($ers->MoreLikeThisTerms)) {
108	1	$this->MoreLikeThisTerms = $ers->MoreLikeThisTerms;
109	1	}
110
111	1	if(isset($ers->getSuggests()['query-phrase-suggestions'])) {
112		$suggest = $ers->getSuggests()['query-phrase-suggestions'];
113		$suggestedPhraseAndHL = ElasticaUtil::getPhraseSuggestion($suggest);
		0 ignored issues – show Bug introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$suggestedPhraseAndHL` is correct as `\SilverStripe\Elastica\E...aseSuggestion($suggest)` (which targets `SilverStripe\Elastica\El...::getPhraseSuggestion()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
114		if($suggestedPhraseAndHL) {
115		$this->SuggestedQuery = $suggestedPhraseAndHL['suggestedQuery'];
116		$this->SuggestedQueryHighlighted = $suggestedPhraseAndHL['suggestedQueryHighlighted'];
117		}
118		}
119
120	1	$this->TotalItems = $ers->getTotalHits();
121	1	$this->TotalTime = $ers->getTotalTime();
122	1	$this->_cachedResults = $ers->getResults();
123		// make the aggregations available to the templating, title casing
124		// to be consistent with normal templating conventions
125	1	$aggs = $ers->getAggregations();
126
127		// array of index field name to human readable title
128	1	$indexedFieldTitleMapping = array();
129
130		// optionally remap keys and store chosen aggregations from get params
131	1	if(isset($this->SearchHelper)) {
132		$manipulator = \Injector::inst()->create($this->SearchHelper);
133		$manipulator->query = $this->query;
134		$manipulator->updateAggregation($aggs);
135
136		$indexedFieldTitleMapping = $manipulator->getIndexFieldTitleMapping();
137		}
138	1	$aggsTemplate = new \ArrayList();
139
140		// Convert the buckets into a form suitable for SilverStripe templates
141	1	$queryText = $this->originalQueryText;
142
143		// if not search term remove it and aggregate with a blank query
144	1	if($queryText == '' && sizeof($aggs) > 0) {
145		$params = $this->query->getParams();
146		unset($params['query']);
147		$this->query->setParams($params);
148		$queryText = '';
149		}
150
151		// get the base URL for the current facets selected
152	1	$baseURL = \Controller::curr()->Link() . '?';
153	1	$prefixAmp = false;
154	1	if($queryText !== '') {
155	1	$baseURL .= 'q=' . urlencode($queryText);
156	1	$prefixAmp = true;
157	1	}
158
159		// now add the selected facets
160	1	foreach($this->filters as $key => $value) {
161		if($prefixAmp) {
162		$baseURL .= '&';
163		} else {
164		$prefixAmp = true;
165		}
166		$baseURL .= $key . '=' . urlencode($value);
167	1	}
168
169	1	foreach(array_keys($aggs) as $key) {
170		$aggDO = new \DataObject();
171		//FIXME - Camel case separate here
172		if(isset($indexedFieldTitleMapping[$key])) {
173		$aggDO->Name = $indexedFieldTitleMapping[$key];
174		} else {
175		$aggDO->Name = $key;
176		}
177
178		// now the buckets
179		if(isset($aggs[$key]['buckets'])) {
180		$bucketsAL = new \ArrayList();
181		foreach($aggs[$key]['buckets'] as $value) {
182		$ct = new \DataObject();
183		$ct->Key = $value['key'];
184		$ct->DocumentCount = $value['doc_count'];
185		$query[$key] = $value;
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report `$query` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$query = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
186		if($prefixAmp) {
187		$url = $baseURL . '&';
188		} else {
189		$url = $baseURL;
190		$prefixAmp = true;
191		}
192
193		// check if currently selected
194		if(isset($this->filters[$key])) {
195
196		if($this->filters[$key] === (string)$value['key']) {
197		$ct->IsSelected = true;
198		// mark this facet as having been selected, so optional toggling
199		// of the display of the facet can be done via the template.
200		$aggDO->IsSelected = true;
201
202		$urlParam = $key . '=' . urlencode($this->filters[$key]);
203
204		// possible ampersand combos to remove
205		$v2 = '&' . $urlParam;
206		$v3 = $urlParam . '&';
207		$url = str_replace($v2, '', $url);
208		$url = str_replace($v3, '', $url);
209		$url = str_replace($urlParam, '', $url);
210		$ct->URL = $url;
211		}
212		} else {
213		$url .= $key . '=' . urlencode($value['key']);
214		$prefixAmp = true;
215		}
216
217		$url = rtrim($url, '&');
218
219		$ct->URL = $url;
220		$bucketsAL->push($ct);
221		}
222
223		// in the case of range queries we wish to remove the non selected ones
224		if($aggDO->IsSelected) {
225		$newList = new \ArrayList();
226		foreach($bucketsAL->getIterator() as $bucket) {
227		if($bucket->IsSelected) {
228		$newList->push($bucket);
229		break;
230		}
231		}
232
233		$bucketsAL = $newList;
234		}
235		$aggDO->Buckets = $bucketsAL;
236
237
238		}
239		$aggsTemplate->push($aggDO);
240	1	}
241	1	$this->aggregations = $aggsTemplate;
		0 ignored issues – show Documentation Bug introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report It seems like `$aggsTemplate` of type `object<ArrayList>` is incompatible with the declared type `object<SilverStripe\Elastica\ArrayList>` of property `$aggregations`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
242	1	}
243	1	return $this->_cachedResults;
244		}
245
246
247	1	public function getTotalItems() {
248	1	$this->getResults();
249	1	return $this->TotalItems;
250		}
251
252
253		public function getTotalTime() {
254		return $this->TotalTime;
255		}
256
257		public function getIterator() {
258		return $this->toArrayList()->getIterator();
259		}
260
261		public function limit($limit, $offset = 0) {
262		$list = clone $this;
263
264		$list->getQuery()->setSize($limit);
265		$list->getQuery()->setFrom($offset);
266
267		return $list;
268		}
269
270		/**
271		* Converts results of type {@link \Elastica\Result}
272		* into their respective {@link DataObject} counterparts.
273		*
274		* @return array DataObject[]
275		*/
276	1	public function toArray() {
277	1	$result = array();
278
279		/** @var $found \Elastica\Result[] */
280	1	$found = $this->getResults();
281	1	$needed = array();
282	1	$retrieved = array();
283
284	1	foreach($found as $item) {
285	1	$type = $item->getType();
286
287	1	if(!array_key_exists($type, $needed)) {
288	1	$needed[$type] = array($item->getId());
289	1	$retrieved[$type] = array();
290	1	} else {
291	1	$needed[$type][] = $item->getId();
292		}
293	1	}
294
295	1	foreach($needed as $class => $ids) {
296	1	foreach($class::get()->byIDs($ids) as $record) {
297	1	$retrieved[$class][$record->ID] = $record;
298	1	}
299	1	}
300
301		// Title and Link are special cases
302	1	$ignore = array('Title', 'Link', 'Title.standard', 'Link.standard');
303
304	1	foreach($found as $item) {
305		// Safeguards against indexed items which might no longer be in the DB
306	1	if(array_key_exists($item->getId(), $retrieved[$item->getType()])) {
307
308	1	$data_object = $retrieved[$item->getType()][$item->getId()];
309	1	$data_object->setElasticaResult($item);
310	1	$highlights = $item->getHighlights();
311
312		//$snippets will contain the highlights shown in the body of the search result
313		//$namedSnippets will be used to add highlights to the Link and Title
314	1	$snippets = new \ArrayList();
315	1	$namedSnippets = new \ArrayList();
316
317	1	foreach(array_keys($highlights) as $fieldName) {
318	1	$fieldSnippets = new \ArrayList();
319
320	1	foreach($highlights[$fieldName] as $snippet) {
321	1	$do = new \DataObject();
322	1	$do->Snippet = $snippet;
323
324		// skip title and link in the summary of highlights
325	1	if(!in_array($fieldName, $ignore)) {
326	1	$snippets->push($do);
327	1	}
328
329	1	$fieldSnippets->push($do);
330	1	}
331
332	1	if($fieldSnippets->count() > 0) {
333		//Fields may have a dot in their name, e.g. Title.standard - take this into account
334		//As dots are an issue with template syntax, store as Title_standard
335	1	$splits = explode('.', $fieldName);
336	1	if(sizeof($splits) == 1) {
337		$namedSnippets->$fieldName = $fieldSnippets;
338		} else {
339		// The Title.standard case, for example
340	1	$splits = explode('.', $fieldName);
341	1	$compositeFielddName = $splits[0] . '_' . $splits[1];
342	1	$namedSnippets->$compositeFielddName = $fieldSnippets;
343		}
344
345	1	}
346
347
348	1	}
349
350
351	1	$data_object->SearchHighlights = $snippets;
352	1	$data_object->SearchHighlightsByField = $namedSnippets;
353
354	1	$result[] = $data_object;
355
356	1	}
357	1	}
358
359
360	1	return $result;
361		}
362
363		public function toArrayList() {
364		return new \ArrayList($this->toArray());
365		}
366
367		public function toNestedArray() {
368		$result = array();
369
370		foreach($this as $record) {
371		$result[] = $record->toMap();
372		}
373
374		return $result;
375		}
376
377		public function first() {
378		// TODO
379		throw new \Exception('Not implemented');
380		}
381
382		public function last() {
383		// TODO: Implement last() method
384		throw new \Exception('Not implemented');
385		}
386
387		public function map($key = 'ID', $title = 'Title') {
388		return $this->toArrayList()->map($key, $title);
389		}
390
391		public function column($col = 'ID') {
392		if($col == 'ID') {
393		$ids = array();
394
395		foreach($this->getResults() as $result) {
396		$ids[] = $result->getId();
397		}
398
399		return $ids;
400		} else {
401		return $this->toArrayList()->column($col);
402		}
403		}
404
405		public function each($callback) {
406		return $this->toArrayList()->each($callback);
407		}
408
409		public function count() {
410		return count($this->toArray());
411		}
412
413		/**
414		* @ignore
415		*/
416		public function offsetExists($offset) {
417		throw new \Exception('Not implemented');
418		}
419
420		/**
421		* @ignore
422		*/
423		public function offsetGet($offset) {
424		throw new \Exception('Not implemented');
425		}
426
427		/**
428		* @ignore
429		*/
430		public function offsetSet($offset, $value) {
431		throw new \Exception('Not implemented');
432		}
433
434		/**
435		* @ignore
436		*/
437		public function offsetUnset($offset) {
438		throw new \Exception('Not implemented');
439		}
440
441		/**
442		* @ignore
443		*/
444		public function add($item) {
445		throw new \Exception('Not implemented');
446		}
447
448		/**
449		* @ignore
450		*/
451		public function remove($item) {
452		throw new \Exception('Not implemented');
453		}
454
455		/**
456		* @ignore
457		*/
458		public function find($key, $value) {
459		throw new \Exception('Not implemented');
460		}
461
462		}
463

gordonbanderson / silverstripe-elastica

Push — dev2 ( 764ed3...9e10b9 )

ResultList::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like